Michael Gerz wrote:
> Peter Kümmel wrote:
>
>> I've fixed it:
>>
>> Index: QPrefsDialog.C
>> ===================================================================
>> --- QPrefsDialog.C (revision 15726)
>> +++ QPrefsDialog.C (working copy)
>> @@ -938,10 +938,13 @@
>>
>> void PrefConverters::switch_converter(int nr)
>> {
>> - if (nr<0)
>> + if (nr < 0)
>> return;
>>
>> int const cnr = convertersLW->currentItem()->type();
>> + // FIXME: why is there now valid current item?
>> + if (cnr < 0)
>> + return;
>> Converter const & c(form_->converters().get(cnr));
>>
>> converterFromCO->setCurrentIndex(form_->formats().getNumber(c.from));
>> converterToCO->setCurrentIndex(form_->formats().getNumber(c.to));
>> @@ -970,6 +973,9 @@
>> || from.name() == to.name());
>>
>> int const cnr = convertersLW->currentItem()->type();
>> + // FIXME: why is there now valid current item?
>> + if (cnr < 0)
>> + return;
>> Converter const & c(form_->converters().get(cnr));
>> string const old_command = c.command;
>> string const old_flag = c.flags;
>>
>>
> Is this really a proper fix. It looks like a work-around for an unknown
> problem.
Yes, it's more like a hot-fix, therefore the FIXME, but I have not the time
to found a better solution.
>
>> BTW the dialog is strange, I have to click modify and save to change the
>> value.
>>
>>
> I agree.
>
> Michael
>
>
--
Peter Kümmel
