Re: Re: Gettext removed from master

2013-06-02 Thread Kornel Benko
Am Sonntag, 2. Juni 2013 um 11:16:26, schrieb Vincent van Ravesteijn > > > > > > I'd like to commit. > > > > > > > > > Can you commit today ? > > Vincent Immediately. Kornel signature.asc Description: This is a digitally signed message part.

Re: Gettext removed from master

2013-06-02 Thread Vincent van Ravesteijn
Op 2-6-2013 10:10, Kornel Benko schreef: Am Samstag, 1. Juni 2013 um 22:09:48, schrieb Vincent van Ravesteijn > > > > I have now a cmake-version which > > > > 1.) checks, whether gettext and python are available > > > > 1a) if yes, then use them to create .gmo files > > In the build d

Re: Re: Re: Re: Gettext removed from master

2013-06-02 Thread Kornel Benko
Am Samstag, 1. Juni 2013 um 22:09:48, schrieb Vincent van Ravesteijn > > > > I have now a cmake-version which > > > > 1.) checks, whether gettext and python are available > > > > 1a) if yes, then use them to create .gmo files > > In the build dir I assume ? And this uses a different target than

Re: Re: Re: Gettext removed from master

2013-06-01 Thread Vincent van Ravesteijn
> > I have now a cmake-version which > > 1.) checks, whether gettext and python are available > > 1a) if yes, then use them to create .gmo files In the build dir I assume ? And this uses a different target than update-po? > > 1b) else installs only in source provided .gmo-files > > .. > > I'd lik

Re: Re: Re: Gettext removed from master

2013-06-01 Thread Kornel Benko
Am Samstag, 1. Juni 2013 um 19:09:53, schrieb Kornel Benko > Am Samstag, 1. Juni 2013 um 18:50:34, schrieb Jean-Marc Lasgouttes > > > Le 01/06/13 17:38, Kornel Benko a écrit : > > > > I thought your latest proposal was to add gmo files to the git > > > repository? > > > > > > Yes, it is. But ru

Re: Re: Gettext removed from master

2013-06-01 Thread Kornel Benko
Am Samstag, 1. Juni 2013 um 18:50:34, schrieb Jean-Marc Lasgouttes > Le 01/06/13 17:38, Kornel Benko a écrit : > > > I thought your latest proposal was to add gmo files to the git > > repository? > > > > Yes, it is. But running lyx from the build-directory should get the > > newly created > > .g

Re: Gettext removed from master

2013-06-01 Thread Jean-Marc Lasgouttes
Le 01/06/13 17:38, Kornel Benko a écrit : > I thought your latest proposal was to add gmo files to the git repository? Yes, it is. But running lyx from the build-directory should get the newly created .gmo files (iff existent) But don't you create them in source directory anyway? > So is t

Re: Re: Gettext removed from master

2013-06-01 Thread Kornel Benko
Am Samstag, 1. Juni 2013 um 17:06:14, schrieb Jean-Marc Lasgouttes > Le 01/06/13 16:27, Kornel Benko a écrit : > > Ah, OK then. I should have make myself clear too, as I was describing my > > wished behaviour. > > > > Therefore, is the proposed patch OK for you? > > I thought your latest proposa

Re: Gettext removed from master

2013-06-01 Thread Jean-Marc Lasgouttes
Le 01/06/13 16:27, Kornel Benko a écrit : Ah, OK then. I should have make myself clear too, as I was describing my wished behaviour. Therefore, is the proposed patch OK for you? I thought your latest proposal was to add gmo files to the git repository? So is the plan the require gettext tools

Re: Re: Re: Re: Gettext removed from master

2013-06-01 Thread Kornel Benko
Am Samstag, 1. Juni 2013 um 13:02:06, schrieb Vincent van Ravesteijn > > > No, at runtime LyX searches the source dir, not the build dir. > > > > > Vincent > > > > Is this an order? Why? > > > > Kornel > > No. I was merely describing LyX's current behaviour. I proposed myself to > adapt this beh

Re: Re: Re: Gettext removed from master

2013-06-01 Thread Vincent van Ravesteijn
> > No, at runtime LyX searches the source dir, not the build dir. > > > Vincent > > Is this an order? Why? > > Kornel No. I was merely describing LyX's current behaviour. I proposed myself to adapt this behaviour in the first place. Vincent

Re: Re: Re: Re: Gettext removed from master

2013-06-01 Thread Kornel Benko
Am Samstag, 1. Juni 2013 um 09:29:38, schrieb Kornel Benko > > No, at runtime LyX searches the source dir, not the build dir. > > > > Vincent > > Is this an order? Why? With this patch (search first in build-dir) it should work for automake and for cmake. Korneldiff --git a/src/suppor

Re: Re: Re: Gettext removed from master

2013-06-01 Thread Kornel Benko
Am Freitag, 31. Mai 2013 um 22:52:08, schrieb Vincent van Ravesteijn > Op 31 mei 2013 18:53 schreef "Kornel Benko" het volgende: > > > > Am Freitag, 31. Mai 2013 um 18:49:24, schrieb Vincent van Ravesteijn < > v...@lyx.org> > > > > > Op 31 mei 2013 18:32 schreef "Jean-Marc Lasgouttes" > > > > >

Re: Re: Gettext removed from master

2013-05-31 Thread Vincent van Ravesteijn
Op 31 mei 2013 18:53 schreef "Kornel Benko" het volgende: > > Am Freitag, 31. Mai 2013 um 18:49:24, schrieb Vincent van Ravesteijn < v...@lyx.org> > > > Op 31 mei 2013 18:32 schreef "Jean-Marc Lasgouttes" > > > het volgende: > > > > > > > > Le 31/05/2013 18:25, Kornel Benko a écrit : > > > > > >

Re: Re: Gettext removed from master

2013-05-31 Thread Kornel Benko
Am Freitag, 31. Mai 2013 um 18:49:24, schrieb Vincent van Ravesteijn > Op 31 mei 2013 18:32 schreef "Jean-Marc Lasgouttes" > het volgende: > > > > Le 31/05/2013 18:25, Kornel Benko a écrit : > > > >> That way > >> > >> 1.) No changes for automake > >> > >> 2.) cmake: still installs from the buil

Re: Gettext removed from master

2013-05-31 Thread Vincent van Ravesteijn
Op 31 mei 2013 18:32 schreef "Jean-Marc Lasgouttes" het volgende: > > Le 31/05/2013 18:25, Kornel Benko a écrit : > >> That way >> >> 1.) No changes for automake >> >> 2.) cmake: still installs from the build-dir (No changes) >> >> 3.) cmake: with "#make update-po" overwrite .gmo-files in source (

Re: Gettext removed from master

2013-05-31 Thread Jean-Marc Lasgouttes
Le 31/05/2013 18:25, Kornel Benko a écrit : That way 1.) No changes for automake 2.) cmake: still installs from the build-dir (No changes) 3.) cmake: with "#make update-po" overwrite .gmo-files in source (To be commited) 4.) cmake: src-tar (make git-archive) will include .gmo-files automatica

Re: Re: Gettext removed from master

2013-05-31 Thread Kornel Benko
Am Freitag, 31. Mai 2013 um 15:11:39, schrieb Jean-Marc Lasgouttes > 31/05/2013 13:13, Kornel Benko: > > I would not oppose, if the .gmo files were part of the source (under git > > control). (Like the po-files are restructured on remerge) > > That makes sense. I do not know what is the reason f

Re: Gettext removed from master

2013-05-31 Thread Jean-Marc Lasgouttes
31/05/2013 13:13, Kornel Benko: I would not oppose, if the .gmo files were part of the source (under git control). (Like the po-files are restructured on remerge) That makes sense. I do not know what is the reason for not having gmo files in git. Since they are not regenerated by mistake, ther

Re: Re: Gettext removed from master

2013-05-31 Thread Kornel Benko
Am Freitag, 31. Mai 2013 um 12:50:58, schrieb Jean-Marc Lasgouttes > 31/05/2013 12:43, Kornel Benko: > > But they are expected to create the moc files? > > Yes, because moc files are dependent of the Qt version AFAIK. Complain > to trolltech/nokia/... > > > Could we make at least some extra di

Re: Gettext removed from master

2013-05-31 Thread Jean-Marc Lasgouttes
31/05/2013 12:43, Kornel Benko: But they are expected to create the moc files? Yes, because moc files are dependent of the Qt version AFAIK. Complain to trolltech/nokia/... Could we make at least some extra directory (possibly subdirectory of po) for this? I really, really don't like chang

Re: Re: Gettext removed from master

2013-05-31 Thread Kornel Benko
Am Freitag, 31. Mai 2013 um 12:24:23, schrieb Jean-Marc Lasgouttes > 31/05/2013 11:23, Kornel Benko: > > I don't get it. Why should they be packaged with source? > > > > Anyone having source and wants to use lyx, is building too, or not? > > Because this is adding yet another dependency on the g

Re: Gettext removed from master

2013-05-31 Thread Jean-Marc Lasgouttes
31/05/2013 11:23, Kornel Benko: I don't get it. Why should they be packaged with source? Anyone having source and wants to use lyx, is building too, or not? Because this is adding yet another dependency on the gettext tools. People who intend to build LyX are not going to fiddle with po files

Re: Gettext removed from master

2013-05-31 Thread Jean-Marc Lasgouttes
31/05/2013 10:50, Vincent van Ravesteijn: You mean that CMake does not have to put the gmo files in the source directory when building, as long as they will be packaged along with the source. Yes. JMarc

Re: Re: Gettext removed from master

2013-05-31 Thread Kornel Benko
Am Freitag, 31. Mai 2013 um 10:50:05, schrieb Vincent van Ravesteijn > Op 31-5-2013 10:32, Jean-Marc Lasgouttes schreef: > > 31/05/2013 09:53, Vincent van Ravesteijn: > >> First, I don't like to litter the source directory, so I would prefer to > >> adapt the source code to find the gmo files in

Re: Gettext removed from master

2013-05-31 Thread Vincent van Ravesteijn
Op 31-5-2013 10:32, Jean-Marc Lasgouttes schreef: 31/05/2013 09:53, Vincent van Ravesteijn: First, I don't like to litter the source directory, so I would prefer to adapt the source code to find the gmo files in the build directory. On the other hand, I would like to hear the opinion of the aut

Re: Gettext removed from master

2013-05-31 Thread Jean-Marc Lasgouttes
31/05/2013 09:53, Vincent van Ravesteijn: First, I don't like to litter the source directory, so I would prefer to adapt the source code to find the gmo files in the build directory. On the other hand, I would like to hear the opinion of the autotools users. Would they be bothered by having CMak

Re: Gettext removed from master

2013-05-31 Thread Vincent van Ravesteijn
Op 31-5-2013 9:39, Jean-Marc Lasgouttes schreef: 30/05/2013 22:26, Vincent van Ravesteijn: Dear all, I just pushed a few commits that were developed by Jean-Marc (and me). From now on, LyX reads the po (gmo) files natively, which means we don't need gettext anymore. As this is quite an intrusi

Re: Gettext removed from master

2013-05-31 Thread Jean-Marc Lasgouttes
30/05/2013 22:26, Vincent van Ravesteijn: Dear all, I just pushed a few commits that were developed by Jean-Marc (and me). From now on, LyX reads the po (gmo) files natively, which means we don't need gettext anymore. As this is quite an intrusive change, I want to inform you about it in this w

Re: Gettext removed from master

2013-05-30 Thread Uwe Stöhr
Am 30.05.2013 22:26, schrieb Vincent van Ravesteijn: I just pushed a few commits that were developed by Jean-Marc (and me). From now on, LyX reads the po (gmo) files natively, which means we don't need gettext anymore. Many thanks! gettext for Windows always lacked behind the current gettext