Re: [patch] Re: Crash with RTL

2007-05-16 Thread José Matos
On Tuesday 15 May 2007 21:38:02 Dov Feldstern wrote: > The only thing (with turning RTL off again) is, as Darren (who already > ran into the crash due to this) pointed out, how are we going to find > out what problems there are with it if we don't leave it on? Wouldn't it > be better to keep it in,

Re: [patch] Re: Crash with RTL

2007-05-16 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Dov Feldstern wrote: >> Again, if this doesn't go in, RTL should be turned off, because >> that *will* cause crashes without this! Abdelrazak> Jose, as far as I see this patch seems OK but I didn't Abdelrazak> look at

Re: [patch] Re: Crash with RTL

2007-05-15 Thread Dov Feldstern
Abdelrazak Younes wrote: Dov Feldstern wrote: Again, if this doesn't go in, RTL should be turned off, because that *will* cause crashes without this! Jose, as far as I see this patch seems OK but I didn't look at it very closely nor tested it. JMarc will probably do a better job than me revi

Re: [patch] Re: Crash with RTL

2007-05-15 Thread Abdelrazak Younes
Dov Feldstern wrote: Again, if this doesn't go in, RTL should be turned off, because that *will* cause crashes without this! Jose, as far as I see this patch seems OK but I didn't look at it very closely nor tested it. JMarc will probably do a better job than me reviewing it. If JMarc cannot

Re: [patch] Re: Crash with RTL

2007-05-14 Thread Dov Feldstern
Dov Feldstern wrote: Dov Feldstern wrote: Dov Feldstern wrote: Fixed. Everything seems to be working fine now. I would still appreciate it if someone could review the whole patch carefully, because this does affect general code (not just RTL). Not everything: I just ran into a new crash whi

Re: [patch] Re: Crash with RTL

2007-05-13 Thread Dov Feldstern
Dov Feldstern wrote: Dov Feldstern wrote: Fixed. Everything seems to be working fine now. I would still appreciate it if someone could review the whole patch carefully, because this does affect general code (not just RTL). Not everything: I just ran into a new crash which was introduced by m

Re: [patch] Re: Crash with RTL

2007-05-12 Thread Dov Feldstern
Dov Feldstern wrote: Dov Feldstern wrote: Abdelrazak Younes wrote: One problem with the current patch --- it breaks the solutions we've been working on for cursor movement --- exiting insets from the beginning seems to be broken again --- either with or without my fix. I'm sure it can be work

Re: [patch] Re: Crash with RTL

2007-05-11 Thread Dov Feldstern
Abdelrazak Younes wrote: Looks sensible. Sorry Dov, I won't have time to work on this before the next beta. Sure, thanks for letting me know, though. That'll give me a little time to work out the kinks. Abdel.

Re: [patch] Re: Crash with RTL

2007-05-11 Thread Abdelrazak Younes
Dov Feldstern wrote: Abdelrazak Younes wrote: I had a crash while navigating with the right and left arrow keys with the attached document. The problem is that (pos - start_ = -1) in: pos_type Bidi::level(pos_type pos) const { return (start_ == -1) ? 0 : levels_[pos - start_]; } pos = 33

Re: [patch] Re: Crash with RTL

2007-05-11 Thread Dov Feldstern
Dov Feldstern wrote: Abdelrazak Younes wrote: One problem with the current patch --- it breaks the solutions we've been working on for cursor movement --- exiting insets from the beginning seems to be broken again --- either with or without my fix. I'm sure it can be worked out, but it'll requ

[patch] Re: Crash with RTL

2007-05-11 Thread Dov Feldstern
Abdelrazak Younes wrote: I had a crash while navigating with the right and left arrow keys with the attached document. The problem is that (pos - start_ = -1) in: pos_type Bidi::level(pos_type pos) const { return (start_ == -1) ? 0 : levels_[pos - start_]; } pos = 33 and start_ = 34. The

Re: Crash with RTL

2007-05-10 Thread Dov Feldstern
Dov Feldstern wrote: Dov Feldstern wrote: Okay, this time I have something a little more concrete, but I still don't know what it means: If you make the screen wide enough such that there is enough room for the text after the inset to appear on the same line as the inset (and the text befo

Re: Crash with RTL

2007-05-10 Thread Dov Feldstern
Dov Feldstern wrote: Okay, this time I have something a little more concrete, but I still don't know what it means: If you make the screen wide enough such that there is enough room for the text after the inset to appear on the same line as the inset (and the text before it), then there's n

Re: Crash with RTL

2007-05-10 Thread Dov Feldstern
Abdelrazak Younes wrote: Abdelrazak Younes wrote: I had a crash while navigating with the right and left arrow keys with the attached document. This is probably related to this comment from Lars in Text::setCurrentFont(): else // potentional bug... BUG (Lgb) if (par.isSe

Re: Crash with RTL

2007-05-10 Thread Dov Feldstern
Dov Feldstern wrote: *) If you move to one space after (to the left of) the inset while it's closed, and then open the inset, you suddenly find yourself inside it! Sorry --- I guess this is a feature. I see that even if you're totally somewhere else in the document, when you open an inset you

Re: Crash with RTL

2007-05-10 Thread Dov Feldstern
Dov Feldstern wrote: Abdelrazak Younes wrote: Abdelrazak Younes wrote: I had a crash while navigating with the right and left arrow keys with the attached document. This is probably related to this comment from Lars in Text::setCurrentFont(): else // potentional bug... BUG (Lgb)

Re: Crash with RTL

2007-05-10 Thread Dov Feldstern
Abdelrazak Younes wrote: Abdelrazak Younes wrote: I had a crash while navigating with the right and left arrow keys with the attached document. This is probably related to this comment from Lars in Text::setCurrentFont(): else // potentional bug... BUG (Lgb) if (par.isSe

Re: Crash with RTL

2007-05-10 Thread Abdelrazak Younes
Abdelrazak Younes wrote: I had a crash while navigating with the right and left arrow keys with the attached document. This is probably related to this comment from Lars in Text::setCurrentFont(): else // potentional bug... BUG (Lgb) if (par.isSeparato

Re: Crash with RTL

2007-05-10 Thread Dov Feldstern
Abdelrazak Younes wrote: I had a crash while navigating with the right and left arrow keys with the attached document. The problem is that (pos - start_ = -1) in: pos_type Bidi::level(pos_type pos) const { return (start_ == -1) ? 0 : levels_[pos - start_]; } pos = 33 and start_ = 34. The