Re: [patch] Re: Crash with RTL

[Dov Feldstern]

Dov Feldstern wrote:
Dov Feldstern wrote:
Fixed. Everything seems to be working fine now. I would still appreciate 
it if someone could review the whole patch carefully, because this does 
affect general code (not just RTL).

Not everything: I just ran into a new crash which was introduced by my 
patch (although this time it'll only be apparent, I think, in documents 
which are truly bidi):

*) start a new document (or new paragraph). At some point, switch the 
language to an RTL language. Now, the boundary is true. you can continue 
typing, but as long as the cursor is at the tip, backspace will cause a 
crash.

Something weird is going on at that last space, because you're 
perpetually on a boundary there: if you move back with an arrow, the 
first time you move back the cursor won't actually move --- all that 
will change is that the boundary will become false. I think this is the 
real problem: the boundary should never be "where the cursor is", which 
is what's happening here. Rather, boundary is just something the cursor 
sometimes "moves through". If this is the case, then in truth my patch 
has actually only exposed something wrong which is already going on. ;)

Anyhow, I'll try to take a look at this tomorrow night (or if anyone 
else wants to take a stab at this in the meantime...)

Dov