Re: Compilation Failure in Master

2025-05-16 Thread Scott Kostyshak
On Fri, May 16, 2025 at 04:54:25PM +0200, Kornel Benko wrote: > Am Fri, 16 May 2025 16:20:04 +0200 > schrieb Scott Kostyshak : > > > On Fri, May 16, 2025 at 03:47:24PM +0200, Jean-Marc Lasgouttes wrote: > > > Le 16/05/2025 à 15:40, Scott Kostyshak a écrit : > > > > From what I understand, this

Re: Compilation Failure in Master

2025-05-16 Thread Kornel Benko
Am Fri, 16 May 2025 16:20:04 +0200 schrieb Scott Kostyshak : > On Fri, May 16, 2025 at 03:47:24PM +0200, Jean-Marc Lasgouttes wrote: > > Le 16/05/2025 à 15:40, Scott Kostyshak a écrit : > > > From what I understand, this would set BOOST, Z, DTL, HUNSPELL, and > > > ICONV to default to ON? > > >

Re: Compilation Failure in Master

2025-05-16 Thread Jean-Marc Lasgouttes
Le 16/05/2025 à 16:31, Kornel Benko a écrit : External libs: Yes, it was anyway the default for prerelease|release build-types. While debugging the default was OFF for development|gprof build-types. Now the default would be always ON except for Windows. This was also done with autoconf when gcc

Re: Compilation Failure in Master

2025-05-16 Thread Kornel Benko
Am Fri, 16 May 2025 15:47:24 +0200 schrieb Jean-Marc Lasgouttes : > Le 16/05/2025 à 15:40, Scott Kostyshak a écrit : > > From what I understand, this would set BOOST, Z, DTL, HUNSPELL, and > > ICONV to default to ON? External libs: Yes, it was anyway the default for prerelease|release build-type

Re: Compilation Failure in Master

2025-05-16 Thread Scott Kostyshak
On Fri, May 16, 2025 at 03:47:24PM +0200, Jean-Marc Lasgouttes wrote: > Le 16/05/2025 à 15:40, Scott Kostyshak a écrit : > > From what I understand, this would set BOOST, Z, DTL, HUNSPELL, and > > ICONV to default to ON? > > > > I don't have any personal preference since it's easy for me to chang

Re: Compilation Failure in Master

2025-05-16 Thread Jean-Marc Lasgouttes
Le 16/05/2025 à 15:40, Scott Kostyshak a écrit : From what I understand, this would set BOOST, Z, DTL, HUNSPELL, and ICONV to default to ON? I don't have any personal preference since it's easy for me to change my build script accordingly, but I don't know if JMarc's original argument of being

Re: Compilation Failure in Master

2025-05-16 Thread Scott Kostyshak
On Fri, May 16, 2025 at 02:50:43PM +0200, Kornel Benko wrote: > Am Fri, 16 May 2025 14:08:02 +0200 > schrieb Scott Kostyshak : > > > > Could you set LYX_EXTERNAL_ICONV to on by default, except for windows? > > > This > > > is a standard part of Unix. > > > > Kornel, any thoughts on this? > >

Re: Compilation Failure in Master

2025-05-16 Thread Kornel Benko
Am Fri, 16 May 2025 14:08:02 +0200 schrieb Scott Kostyshak : > > Could you set LYX_EXTERNAL_ICONV to on by default, except for windows? This > > is a standard part of Unix. > > Kornel, any thoughts on this? No problem. Maybe something like the attached. > Scott Kornel diff --git a/CM

Re: Compilation Failure in Master

2025-05-16 Thread Scott Kostyshak
On Fri, May 16, 2025 at 12:02:41PM +0200, Jean-Marc Lasgouttes wrote: > Le 16/05/2025 à 10:13, Kornel Benko a écrit : > > Am Thu, 15 May 2025 17:50:26 +0200 > > schrieb Scott Kostyshak : > > > > > Do you mean CMake should turn set LYX_EXTERNAL_ICONV passed on the > > > version of the compiler? > >

Re: Compilation Failure in Master

2025-05-16 Thread Jean-Marc Lasgouttes
Le 16/05/2025 à 10:13, Kornel Benko a écrit : Am Thu, 15 May 2025 17:50:26 +0200 schrieb Scott Kostyshak : Do you mean CMake should turn set LYX_EXTERNAL_ICONV passed on the version of the compiler? I still don't know why it succeeds for me (with the default of LYX_EXTERNAL_ICONV=OFF) and not

Re: Compilation Failure in Master

2025-05-16 Thread Scott Kostyshak
On Fri, May 16, 2025 at 10:13:22AM +0200, Kornel Benko wrote: > Am Thu, 15 May 2025 17:50:26 +0200 > schrieb Scott Kostyshak : > > > Do you mean CMake should turn set LYX_EXTERNAL_ICONV passed on the > > version of the compiler? > > > > I still don't know why it succeeds for me (with the default

Re: Compilation Failure in Master

2025-05-16 Thread Kornel Benko
Am Thu, 15 May 2025 17:50:26 +0200 schrieb Scott Kostyshak : > Do you mean CMake should turn set LYX_EXTERNAL_ICONV passed on the > version of the compiler? > > I still don't know why it succeeds for me (with the default of > LYX_EXTERNAL_ICONV=OFF) and not for Riki. Could be different compiler >

Re: Compilation Failure in Master

2025-05-16 Thread Pavel Sanda
On Thu, May 15, 2025 at 04:48:55PM +0200, Jean-Marc Lasgouttes wrote: > At this time, upgrading libiconv seems a lot of work for a dubious return. I agree, the right fix seems to be changing cmake defaults and mess with libiconv only if mingw folks deem it necessary. Pavel -- lyx-devel mailing l

Re: Compilation Failure in Master

2025-05-15 Thread Scott Kostyshak
On Thu, May 15, 2025 at 05:59:45PM +0200, Jean-Marc Lasgouttes wrote: > Le 15/05/2025 à 17:50, Scott Kostyshak a écrit : > > I still don't know why it succeeds for me (with the default of > > LYX_EXTERNAL_ICONV=OFF) and not for Riki. Could be different compiler > > versions or could be different ot

Re: Compilation Failure in Master

2025-05-15 Thread Richard Kimberly Heck
On 5/15/25 10:48 AM, Jean-Marc Lasgouttes wrote: My question is thus: Riki, do you _need_ this to work, or is it just that cmake is proposing the wrong defaults? I was just using the defaults. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org https://lists.lyx.org/mailman/listinfo/lyx-d

Re: Compilation Failure in Master

2025-05-15 Thread Jean-Marc Lasgouttes
Le 15/05/2025 à 17:50, Scott Kostyshak a écrit : I still don't know why it succeeds for me (with the default of LYX_EXTERNAL_ICONV=OFF) and not for Riki. Could be different compiler versions or could be different othe CMake flags. Kornel does it compile successfully (although with warnings) for y

Re: Compilation Failure in Master

2025-05-15 Thread Scott Kostyshak
On Thu, May 15, 2025 at 04:48:55PM +0200, Jean-Marc Lasgouttes wrote: > Le 15/05/2025 à 12:31, Scott Kostyshak a écrit : > > On Thu, May 15, 2025 at 08:49:32AM +0200, Jean-Marc Lasgouttes wrote: > > > Le 15 mai 2025 01:46:37 GMT+02:00, Richard Kimberly Heck > > > a écrit : > > > > > > > > I was

Re: Compilation Failure in Master

2025-05-15 Thread Jean-Marc Lasgouttes
Le 15/05/2025 à 12:31, Scott Kostyshak a écrit : On Thu, May 15, 2025 at 08:49:32AM +0200, Jean-Marc Lasgouttes wrote: Le 15 mai 2025 01:46:37 GMT+02:00, Richard Kimberly Heck a écrit : I was just using defaults: mkdir build cd buildcmake ..; and that's it. If I set LYX_EXTERNAL_ICONV to ON

Re: Compilation Failure in Master

2025-05-15 Thread Scott Kostyshak
On Thu, May 15, 2025 at 08:49:32AM +0200, Jean-Marc Lasgouttes wrote: > Le 15 mai 2025 01:46:37 GMT+02:00, Richard Kimberly Heck > a écrit : > > > >I was just using defaults: > > > >mkdir build > >cd buildcmake ..; and that's it. If I set LYX_EXTERNAL_ICONV to ON, then it > >builds. The error se

Re: Compilation Failure in Master

2025-05-14 Thread Jean-Marc Lasgouttes
Le 15 mai 2025 01:46:37 GMT+02:00, Richard Kimberly Heck a écrit : > >I was just using defaults: > >mkdir build >cd buildcmake ..; and that's it. If I set LYX_EXTERNAL_ICONV to ON, then it >builds. The error seems to be in building iconv itself. > We ship libinconv 1.15. It might be that the la

Re: Compilation Failure in Master

2025-05-14 Thread Richard Kimberly Heck
On 5/14/25 4:41 PM, Scott Kostyshak wrote: On Wed, May 14, 2025 at 12:00:20PM -0400, Richard Kimberly Heck wrote: In file included from /cvs/lyx/lyx-devel/3rdparty/libiconv/1.15/lib/loops.h:23, from /cvs/lyx/lyx-devel/3rdparty/libiconv/1.15/lib/iconv.c:136: /cvs/lyx/lyx-devel/3r

Re: Compilation Failure in Master

2025-05-14 Thread Richard Kimberly Heck
On 5/14/25 4:41 PM, Scott Kostyshak wrote: On Wed, May 14, 2025 at 12:00:20PM -0400, Richard Kimberly Heck wrote: In file included from /cvs/lyx/lyx-devel/3rdparty/libiconv/1.15/lib/loops.h:23, from /cvs/lyx/lyx-devel/3rdparty/libiconv/1.15/lib/iconv.c:136: /cvs/lyx/lyx-devel/3r

Re: Compilation Failure in Master

2025-05-14 Thread Scott Kostyshak
On Wed, May 14, 2025 at 12:00:20PM -0400, Richard Kimberly Heck wrote: > > In file included from > /cvs/lyx/lyx-devel/3rdparty/libiconv/1.15/lib/loops.h:23, > from > /cvs/lyx/lyx-devel/3rdparty/libiconv/1.15/lib/iconv.c:136: > /cvs/lyx/lyx-devel/3rdparty/libiconv/1.15/lib/loop_wcha