Re: [patch] number localization

2009-01-19 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > What are your environment settings wrt the variables I mentionned? juer...@whisper:~/lyx/lyx-qt> echo $LANGUAGE de juer...@whisper:~/lyx/lyx-15x> locale LANG=de_DE.UTF-8 LC_CTYPE="de_DE.UTF-8" LC_NUMERIC="de_DE.UTF-8" LC_TIME="de_DE.UTF-8" LC_COLLATE="de_DE.UTF-8" LC_

Re: [patch] number localization

2009-01-19 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller writes: > Jean-Marc Lasgouttes wrote: >> > I see. LANGUAGE=en_EN works as expected. >> >> So, is there a bug that remains? > > Well, still "LC_NUMERIC=C lyx" does not work. I expect it to set the decimal > separator to "." even in a German localization, but it is still "," (yo

Re: [patch] number localization

2009-01-19 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > > I see. LANGUAGE=en_EN works as expected. > > So, is there a bug that remains? Well, still "LC_NUMERIC=C lyx" does not work. I expect it to set the decimal separator to "." even in a German localization, but it is still "," (you can also check yourself; some widget

Re: [patch] number localization

2009-01-19 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller writes: > Jean-Marc Lasgouttes wrote: >> LANG does not have priority over LC_xxx. Order is LANGUAGE, LC_ALL, >> LC_xxx and LANG. > > I see. LANGUAGE=en_EN works as expected. So, is there a bug that remains? JMarc

Re: [patch] number localization

2009-01-19 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > LANG does not have priority over LC_xxx. Order is LANGUAGE, LC_ALL, > LC_xxx and LANG. I see. LANGUAGE=en_EN works as expected. Jürgen

Re: [patch] number localization

2009-01-19 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller writes: > juer...@whisper:~/lyx/lyx-qt> LANG=en_EN src/lyx -dbg locale > Setting debug level to locale > Debugging `locale' (Locale/Internationalisation) > GuiApplication.cpp(1080): Tring to set default locale to: de > GuiApplication.cpp(1097): Successfully installed Qt translat

Re: [patch] number localization

2009-01-19 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > This part of the patch is probably helpful. Could you try it out? It does not seem to help, the decimal separator is still localized with LC_NUMERIC=C. Th console shows this: juer...@whisper:~/lyx/lyx-qt> LC_NUMERIC=C src/lyx -dbg locale Setting debug level to local

Re: [patch] number localization

2009-01-19 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller writes: > Where I'm heading to, is to make LyX aware of manual LC_NUMERIC changes. So > that LyX respects me requesting "LC_NUMERIC=C lyx". Currently, the value is > overwritten by the LANG (or LANGUAGE?) setting. Unless I miss something, I > don't think your patch changes th

Re: [patch] number localization

2009-01-17 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > While I am not sure about whre you are headed, here is a patch that > might help in the translation dept. It gets rid of the > setDefaultLanguage thing, and reuses the trick currently used in > i18nLibFileName that lets gettext itself tell us what is the currently > lo

Re: [patch] number localization

2009-01-16 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > You are definitely right. The return value should be ::setenv(...) == 0, > like for putenv. I just committed a change to trunk. I also chenged the thir argument to an int. I'll commit to branch as well in a minute. Jürgen

Re: [patch] number localization

2009-01-16 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller writes: > Jean-Marc, is this OK, or should we rather try to make the backend aware of > LC_NUMERIC? If so, I need your help. While I am not sure about whre you are headed, here is a patch that might help in the translation dept. It gets rid of the setDefaultLanguage thing, and

Re: [patch] number localization

2009-01-16 Thread Jean-Marc Lasgouttes
Jürgen Spitzmüller writes: > BTW, I noticed that LyX::setRcGuiLanguage() always reports a failure > when trying to set a different language from rc.gui_language. My > inpression is that this report is wrong. Looking at Environment.cpp, I > see the bool SetEnv return ::setenv(name.c_str(), encoded.

Re: [patch] number localization

2009-01-16 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > Jürgen Spitzmüller wrote: > > It is supposed to respect the user's settings. However, our language > > setting (GuiApplication::setGuiLanguage()) is broken. It always uses > > Messages::defaultLanguage(), which overwrites manual LC_NUMERIC changes > > (the latter might be a bug

Re: [patch] number localization

2009-01-15 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > It is supposed to respect the user's settings. However, our language setting > (GuiApplication::setGuiLanguage()) is broken. It always uses > Messages::defaultLanguage(), which overwrites manual LC_NUMERIC changes (the > latter might be a bug in itself). > > The atta

Re: [patch] number localization

2009-01-15 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > i think we should use this only if there is some way how _not_ to have > localized numbers. either by our settings or to force lyx/qt respect > LC_NUMERIC variable of the environment. maybe i just dont use correct > syntax, but i'm not able to get rid of this localization when

Re: [patch] number localization

2009-01-14 Thread Jean-Marc Lasgouttes
What is the trimmed() good for? QString::toDouble() cannot handle trailing whitespace. Oh, I see. JMarc

Re: [patch] number localization

2009-01-14 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > Le 14 janv. 09 à 20:05, Jürgen Spitzmüller a écrit : > > The attached patch (for trunk only) introduces number localization,   > > something > > I wanted for a long time (I wasn't aware it was so easy). > > What is the trimmed() good for? QString::toDouble() cannot ha

Re: [patch] number localization

2009-01-14 Thread Jean-Marc Lasgouttes
Le 14 janv. 09 à 20:05, Jürgen Spitzmüller a écrit : The attached patch (for trunk only) introduces number localization, something I wanted for a long time (I wasn't aware it was so easy). What is the trimmed() good for? So you can now, in German localization, enter 1,2 instead of 1.2 (the

Re: [patch] number localization

2009-01-14 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > The attached patch (for trunk only) introduces number localization, something > I wanted for a long time (I wasn't aware it was so easy). > > So you can now, in German localization, enter 1,2 instead of 1.2 (the latter > is still possible, but the numbers will be disp