Re: [PATCH] cleanups

2001-11-12 Thread Jean-Marc Lasgouttes
> "John" == John Levon <[EMAIL PROTECTED]> writes: John> I merged some code for startPipe - the fix makes sure : John> 1) we open the two pipes in the right modes (so we can write to John> one) John> 2) that the callback is not registered for both (leading to lyx John> reading its own INFO:

Re: [PATCH] cleanups

2001-11-12 Thread John Levon
On Mon, Nov 12, 2001 at 06:27:45PM +0100, Jean-Marc Lasgouttes wrote: > What does the "fix" part do? sorry. I merged some code for startPipe - the fix makes sure : 1) we open the two pipes in the right modes (so we can write to one) 2) that the callback is not registered for both (leading to

Re: [PATCH] cleanups

2001-11-12 Thread Jean-Marc Lasgouttes
> "John" == John Levon <[EMAIL PROTECTED]> writes: John> On Mon, Nov 12, 2001 at 10:27:44AM +0100, Jean-Marc Lasgouttes John> wrote: >> I think it was having inPipeName() and outPipeName() to replace all >> the places where we have explicitely pipename + ".in" in the code. John> here it is.

Re: [PATCH] cleanups

2001-11-12 Thread John Levon
On Mon, Nov 12, 2001 at 10:27:44AM +0100, Jean-Marc Lasgouttes wrote: > I think it was having inPipeName() and outPipeName() to replace all > the places where we have explicitely > pipename + ".in" > in the code. here it is. I also made lyxserver work again (don't shout at me, it's not friday

Re: [PATCH] cleanups

2001-11-12 Thread Jean-Marc Lasgouttes
> "John" == John Levon <[EMAIL PROTECTED]> writes: John> (what did you want me to clean up in lyxserver again ? the John> pipenames somehow ?) I think it was having inPipeName() and outPipeName() to replace all the places where we have explicitely pipename + ".in" in the code. JMarc

Re: [PATCH] cleanups

2001-11-09 Thread John Levon
On Fri, Nov 09, 2001 at 11:19:37AM +0100, Jean-Marc Lasgouttes wrote: > When I see a patch named 'cleanup' I expect to understand easily what > it does. Saying that all these --- and +++ are just a reorg og > GetVisibleRow is enough for me, but it needs to be said. sorry, I /was/ a bit brief !

Re: [PATCH] cleanups

2001-11-09 Thread Jean-Marc Lasgouttes
> "John" == John Levon <[EMAIL PROTECTED]> writes: John> On Thu, Nov 08, 2001 at 12:15:30PM +0100, Jean-Marc Lasgouttes John> wrote: several cleanups. Lars, I added ::WORKAREA instead of John> removing the debug. >> Concerning the helpers you added: John> argh, why do people only complain w

Re: [PATCH] cleanups

2001-11-08 Thread John Levon
On Thu, Nov 08, 2001 at 12:15:30PM +0100, Jean-Marc Lasgouttes wrote: > John> several cleanups. Lars, I added ::WORKAREA instead of removing > John> the debug. > Concerning the helpers you added: argh, why do people only complain when I've done a changelog ?!! > - isMetaInset should be renamed

Re: [PATCH] cleanups

2001-11-08 Thread Jean-Marc Lasgouttes
> "John" == John Levon <[EMAIL PROTECTED]> writes: John> several cleanups. Lars, I added ::WORKAREA instead of removing John> the debug. Concerning the helpers you added: - isMetaInset should be renamed to isInset (we don't care about meta) - isEditableInset(inset) is equivalent to inset->

Re: [PATCH] cleanups

2000-11-30 Thread John Levon
On Thu, 30 Nov 2000, Allan Rae wrote: > Seems some systems implementation of sort respond slightly differently to > the -f and -d flags. > > Allan. (ARRae) RH Linux 6.2 p40:1001 rpm -qf `which sort` textutils-2.0e-6 john -- "Creating laws which cannot be universally enforced leads to arbit

Re: [PATCH] cleanups

2000-11-29 Thread Allan Rae
On Wed, 29 Nov 2000, John Levon wrote: > p.s. is there any chance POTFILES.in can get cvs removed ? It is very > galling having to delete it each time from the diff Then don't delete it. It is possible to build POTFILES.in from autogen.sh (if we copy it back in there from po/Makefile.in.in (not