>>>>> "John" == John Levon <[EMAIL PROTECTED]> writes:
John> On Thu, Nov 08, 2001 at 12:15:30PM +0100, Jean-Marc Lasgouttes John> wrote: several cleanups. Lars, I added ::WORKAREA instead of John> removing the debug. >> Concerning the helpers you added: John> argh, why do people only complain when I've done a changelog ?!! Actually I read the previous one, but did not have time to complain. >> - isEditableInset(inset) is equivalent to inset->editable(). Use >> the instead >> >> - similarly you could add a "bool Inset::highlyEditable()" method. John> This is not true, it checks for non-null inset too. Look at John> insettext.C I stand corrected. >> Concerning the drawRowParam stuff, I do not know what it does, so I >> cannot comment. John> I thought it was fairly obvious -a re-org of GetVisibleRow John> (which I think is not a very descriptive name anyway) into John> smaller, more readable functions. When I see a patch named 'cleanup' I expect to understand easily what it does. Saying that all these --- and +++ are just a reorg og GetVisibleRow is enough for me, but it needs to be said. John> Is there any chance you can apply it then I can send a further John> patch to change isMetaInset into isInset ? Consider it done. JMarc
