On Thu, Nov 08, 2001 at 12:15:30PM +0100, Jean-Marc Lasgouttes wrote:
> John> several cleanups. Lars, I added ::WORKAREA instead of removing
> John> the debug.
> Concerning the helpers you added:
argh, why do people only complain when I've done a changelog ?!!
> - isMetaInset should be renamed to isInset (we don't care about meta)
ok-doke
> - isEditableInset(inset) is equivalent to inset->editable(). Use the
> instead
>
> - similarly you could add a "bool Inset::highlyEditable()" method.
This is not true, it checks for non-null inset too. Look at insettext.C
> Concerning the drawRowParam stuff, I do not know what it does, so I
> cannot comment.
I thought it was fairly obvious -a re-org of GetVisibleRow (which I think
is not a very descriptive name anyway) into smaller, more readable functions.
Is there any chance you can apply it then I can send a further patch to change
isMetaInset into isInset ?
thanks
john
--
"This bulletin discusses three security vulnerabilities that are unrelated
except in the sense that both affect ISA Server 2000"
- Microsoft Product Security
