Abdelrazak Younes a écrit :
Jean-Marc Lasgouttes a écrit :
"Abdelrazak" == Abdelrazak Younes
<[EMAIL PROTECTED]> writes:
Abdelrazak> Jean-Marc Lasgouttes a écrit :
bool needsUpdateCounters(Buffer const & buf, ParIterator & it) { if
(it->layout()->counter.empty()) {
Abdelrazak> Apparently, t
Andre Poenitz a écrit :
Two empty lines between functions, please.
OK,
Abdel.
On Wed, Apr 05, 2006 at 03:53:22PM +0200, Abdelrazak Younes wrote:
> Index: buffer_funcs.C
> ===
> --- buffer_funcs.C(revision 13538)
> +++ buffer_funcs.C(working copy)
> @@ -328,7 +328,6 @@
> }
> }
>
> -
> bool needE
Jean-Marc Lasgouttes a écrit :
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Jean-Marc Lasgouttes a écrit :
bool needsUpdateCounters(Buffer const & buf, ParIterator & it) { if
(it->layout()->counter.empty()) {
Abdelrazak> Apparently, this is not a good test for en
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Jean-Marc Lasgouttes a écrit :
>> bool needsUpdateCounters(Buffer const & buf, ParIterator & it) { if
>> (it->layout()->counter.empty()) {
Abdelrazak> Apparently, this is not a good test for enumerate (returns
Abdelra
On Apr 5, 2006, at 9:53 AM, Abdelrazak Younes wrote:
Bennett Helm a écrit :
On Apr 5, 2006, at 6:27 AM, Abdelrazak Younes wrote:
I seem to remember remember some problem like this on Mac also.
Bennet could you try test this patch?
I haven't been following this carefully. What exactly should I
Jean-Marc Lasgouttes a écrit :
bool needsUpdateCounters(Buffer const & buf, ParIterator & it)
{
if (it->layout()->counter.empty()) {
Apparently, this is not a good test for enumerate (returns true). Do you
know why?
setCounter(buf, it);
return false;
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> I don't know the LyX API by heart yet ;-) Are we sure that
Abdelrazak> the cursor is on the right paragraph after a deletion or a
Abdelrazak> creation?
The cursor is moved later in breakParagraph, so you may have to m
Bennett Helm a écrit :
On Apr 5, 2006, at 6:27 AM, Abdelrazak Younes wrote:
I seem to remember remember some problem like this on Mac also. Bennet
could you try test this patch?
I haven't been following this carefully. What exactly should I be testing?
Paragraph creation/deletion induce a d
On Apr 5, 2006, at 6:27 AM, Abdelrazak Younes wrote:
I seem to remember remember some problem like this on Mac also.
Bennet could you try test this patch?
I haven't been following this carefully. What exactly should I be
testing?
Bennett
Jean-Marc Lasgouttes a écrit :
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
[...]
I would be OK with that. OTOH if you manage not to call setItemLabel
directly in 1.4 but setCounter instead, you could leave the remainder
of the code as it stands (with one bug setCounter functio
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Jean-Marc Lasgouttes a écrit :
>>> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Fine! Then I'll commit it to 1.5 if nobody object. If
Abdelrazak> somebody want to object, speak now plea
Jean-Marc Lasgouttes a écrit :
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Fine! Then I'll commit it to 1.5 if nobody object. If
Abdelrazak> somebody want to object, speak now please.
If it is still time, I have a few comments:
Are those comments only for the 1.
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Fine! Then I'll commit it to 1.5 if nobody object. If
Abdelrazak> somebody want to object, speak now please.
If it is still time, I have a few comments:
- I like the setItemLabel separation (and the setEnumLabel in t
Martin Vermeer a écrit :
On Mon, Apr 03, 2006 at 05:05:56PM +0200, Abdelrazak Younes wrote:
Martin Vermeer a écrit :
On Mon, 2006-04-03 at 14:44 +0200, Abdelrazak Younes wrote:
Is it the use of
needsUpdateCounters (should maybe be needsCountersUpdate) that helps?
Yes.
This is important. I
On Mon, Apr 03, 2006 at 05:05:56PM +0200, Abdelrazak Younes wrote:
> Martin Vermeer a écrit :
> >On Mon, 2006-04-03 at 14:44 +0200, Abdelrazak Younes wrote:
> >
> >>> Is it the use of
> >>>needsUpdateCounters (should maybe be needsCountersUpdate) that helps?
> >>>
> >>Yes.
> >
> >This is importan
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| This would be closer to the XML way indeed but I didn't dare to say
| it. I know that you guys are thinking about a switch to XML; a real
| switch would mean more than a format.
Only if we want it to.
The plan so far has been that when we move to a
Andre Poenitz a écrit :
On Tue, Apr 04, 2006 at 04:24:49PM +0200, Abdelrazak Younes wrote:
We should instead maintains lists of interdependent numbered
paragraphs and update only those paragraphs that need updates. In
this context, a kind of DocIterator that will iterates other one of
these li
On Tue, Apr 04, 2006 at 04:24:49PM +0200, Abdelrazak Younes wrote:
> >>We should instead maintains lists of interdependent numbered
> >>paragraphs and update only those paragraphs that need updates. In
> >>this context, a kind of DocIterator that will iterates other one of
> >>these lists would
On Mon, Apr 03, 2006 at 02:44:16PM +0200, Abdelrazak Younes wrote:
> Anyway, do what you want with the patch. I will maintain my own version
> locally.
Hm.. Jean-Marc is not the enemy.
Never was.
Andre'
On Mon, Apr 03, 2006 at 03:07:57PM +0200, Abdelrazak Younes wrote:
> Angus Leeming a écrit :
> >Abdelrazak Younes <[EMAIL PROTECTED]> writes:
> >>Anyway, do what you want with the patch. I will maintain my own version
> >>locally.
> >
> >Hey, Abdel! Don't get stroppy;
>
> I am not. I just don't h
On Mon, Apr 03, 2006 at 04:09:44PM +0200, Abdelrazak Younes wrote:
> IMHO even if there's no performance penalty on linux (which I really
> doubt on slow machine) the way the counters are updated is too heavy. We
> should instead maintains lists of interdependent numbered paragraphs and
> update
Andre Poenitz a écrit :
On Mon, Apr 03, 2006 at 04:09:44PM +0200, Abdelrazak Younes wrote:
IMHO even if there's no performance penalty on linux (which I really
doubt on slow machine) the way the counters are updated is too heavy.
We should instead maintains lists of interdependent numbered
p
On Mon, Apr 03, 2006 at 05:05:56PM +0200, Abdelrazak Younes wrote:
> Martin Vermeer a écrit :
> >On Mon, 2006-04-03 at 14:44 +0200, Abdelrazak Younes wrote:
> >
> >>> Is it the use of
> >>>needsUpdateCounters (should maybe be needsCountersUpdate) that helps?
> >>>
> >>Yes.
> >
> >This is importan
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> IMHO even if there's no performance penalty on linux
Abdelrazak> (which I really doubt on slow machine) the way the
Abdelrazak> counters are updated is too heavy. We should instead
Abdelrazak> maintains lists of interd
Martin Vermeer a écrit :
On Mon, 2006-04-03 at 14:44 +0200, Abdelrazak Younes wrote:
Is it the use of
needsUpdateCounters (should maybe be needsCountersUpdate) that helps?
Yes.
This is important. I suggest you create a minimal patch doing only this.
We test it, make sure it's OK, have it
Jean-Marc Lasgouttes a écrit :
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Sorry but I do not see why modifying an enum in one
Abdelrazak> footnote should impact a caption inside a float inset.
I put some of the 'interesting' constructs in the attached file.
I u
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Sorry but I do not see why modifying an enum in one
Abdelrazak> footnote should impact a caption inside a float inset.
Jean-Marc> I put some of the
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
>> JMarc PS: Hmm, ``stroppy''. One more word in the weekly english
>> lesson. Thanks Angus. Webster says it is a contraction of
>> obstreperous. This one looks even better in a casual conversation !
Abdelrazak> Google translate t
Jean-Marc Lasgouttes a écrit :
"Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
Angus> Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Anyway, do what you want with the patch. I will maintain my own
version locally.
Angus> Hey, Abdel! Don't get stroppy; JMarc is one of the good guys!
Angus
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Sorry but I do not see why modifying an enum in one
Abdelrazak> footnote should impact a caption inside a float inset.
I put some of the 'interesting' constructs in the attached file.
Abdelrazak> Beside, counters ins
On Mon, 2006-04-03 at 14:44 +0200, Abdelrazak Younes wrote:
> > Is it the use of
> > needsUpdateCounters (should maybe be needsCountersUpdate) that helps?
> >
> Yes.
This is important. I suggest you create a minimal patch doing only this.
We test it, make sure it's OK, have it in, and continu
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
Angus> Abdelrazak Younes <[EMAIL PROTECTED]> writes:
>> Anyway, do what you want with the patch. I will maintain my own
>> version locally.
Angus> Hey, Abdel! Don't get stroppy; JMarc is one of the good guys!
Angus> And besides, you Frenc
Angus Leeming a écrit :
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Anyway, do what you want with the patch. I will maintain my own version
locally.
Hey, Abdel! Don't get stroppy;
I am not. I just don't have the courage nor the time to argue for days.
So I just gave up. Nothing to be upse
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
> Anyway, do what you want with the patch. I will maintain my own version
> locally.
Hey, Abdel! Don't get stroppy; JMarc is one of the good guys! And besides, you
Frenchies should stick together ;-)
Angus
Jean-Marc Lasgouttes a écrit :
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> IMHO, this is because the code is not object oriented. In
Abdelrazak> this context docIterator is an advantage. When/if we move
Abdelrazak> to a truly object oriented way of dea
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> IMHO, this is because the code is not object oriented. In
Abdelrazak> this context docIterator is an advantage. When/if we move
Abdelrazak> to a truly object oriented way of dealing with insets I
Abdelrazak> believe th
Lars Gullik Bjønnes a écrit :
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
[...]
| IMHO, this is because the code is not object oriented. In this context
| docIterator is an advantage.
The code is not 'not object oriented' either.
IMHO, it is not _much_ object oriented. That's just an opin
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Jean-Marc Lasgouttes a écrit :
| >> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| >>
| >
| > Abdelrazak> bool needEnumCounterReset(ParagraphList & pars, size_t
| > const pos) Abdelrazak> Maybe I am missing something but this
39 matches
Mail list logo
