>>>>> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Jean-Marc Lasgouttes a écrit : >>>>>>> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Fine! Then I'll commit it to 1.5 if nobody object. If Abdelrazak> somebody want to object, speak now please. >> If it is still time, I have a few comments: Abdelrazak> Are those comments only for the 1.5 version or for 1.4 Abdelrazak> also? For 1.4, I would prefer to let the patch as-is but Abdelrazak> you decide. For 1.4, I'd like to have a solution that covers all the easy cases equally (there are many which have a static label, after all) since it seems easy to do. The fact that we see a really good solution in sight for 1.5 makes me more willing to accepts some hacks to alleviate the problems in 1.4 (like needsUpdateCounters). >> - I like the setItemLabel separation (and the setEnumLabel in the >> other patch) as a general cleanup. setCounter should probably be >> renamed to setLabel or setParLabel. Abdelrazak> OK, shall I do the same for the other (big) cases? I would be OK with that. OTOH if you manage not to call setItemLabel directly in 1.4 but setCounter instead, you could leave the remainder of the code as it stands (with one bug setCounter function). We do not need to cleanup the 1.4 code. Abdelrazak> If I do this I would need to construct a ParIterator in Abdelrazak> BreakParagraph. But "ParIterator::ParIterator(InsetBase &, Abdelrazak> lyx::pit_type pit)" is not implemented and should be Abdelrazak> implemented first (it is too costly to advance the Abdelrazak> ParIterator up to pit). You have a cursor. Can't you use ParIterator::ParIterator(DocIterator const & cur) ? >> - I like very much the proposal of having counter-enabled >> paragraphs register themselves in a special structure. Abdelrazak> Fine, I'll try to draft a proposal this week-end. Great.
