On Tue, Aug 30, 2016 at 05:03:11PM +0200, Jean-Marc Lasgouttes wrote:
> Le 30/08/2016 à 16:55, Scott Kostyshak a écrit :
> > OK I pushed at 03684ae0. I wonder if the misunderstanding comes back to
> > what we agreed on before, which is that it is weird that both
> >
> > buffer-zoom-in 4
> > bu
Le 30/08/2016 à 16:55, Scott Kostyshak a écrit :
OK I pushed at 03684ae0. I wonder if the misunderstanding comes back to
what we agreed on before, which is that it is weird that both
buffer-zoom-in 4
buffer-zoom-out 4
have the same behavior.
No, it probably come from my laziness about rea
On Tue, Aug 30, 2016 at 04:41:38PM +0200, Jean-Marc Lasgouttes wrote:
> Le 30/08/2016 à 16:36, Scott Kostyshak a écrit :
> > It would go down to 10%, both with my patch and without it.
>
> It is OK, then.
>
> Do what you think is best.
OK I pushed at 03684ae0. I wonder if the misunderstanding co
On Tue, Aug 30, 2016 at 10:51:13AM +0200, Jean-Marc Lasgouttes wrote:
> Le 30/08/2016 à 03:52, Scott Kostyshak a écrit :
> > On current master, if zoom is at 10% and you run
> >
> > buffer-zoom-in -1
> >
> > then the LFUN is not disabled and status shows:
> >
> > Zoom level is now 10% (buffe
Le 30/08/2016 à 03:52, Scott Kostyshak a écrit :
On current master, if zoom is at 10% and you run
buffer-zoom-in -1
then the LFUN is not disabled and status shows:
Zoom level is now 10% (buffer-zoom-in -1)
With my patch, I think the LFUN is disabled and status shows the same as
buffer-
On Mon, Aug 29, 2016 at 02:11:17PM +0200, Jean-Marc Lasgouttes wrote:
> Le 27/08/2016 à 17:11, Scott Kostyshak a écrit :
> > > It is not clear to me that we want to do that. If the current zoom is
> > > 15, and the user does
> > >
> > > buffer-zoom-out
> > >
> > > Do we want it to be disabled? Or
Le 27/08/2016 à 17:11, Scott Kostyshak a écrit :
It is not clear to me that we want to do that. If the current zoom is
15, and the user does
buffer-zoom-out
Do we want it to be disabled? Or do we want to enable it but just change
the zoom from 15 to 10? I prefer the second.
JMarc any thoughts
Le 27/08/2016 à 17:10, Scott Kostyshak a écrit :
This also fixes #9485. Can we close that? I did not do it myself since
I'm not sure if the 10% limit hides the potential assertion or if the
unsigned int fixed it so I'll let you make the decision.
JMarc do you think we can close #9485?
Sorry I
On Tue, Jul 19, 2016 at 08:26:30PM -0400, Scott Kostyshak wrote:
> On Tue, Jul 19, 2016 at 12:12:25PM +0200, Jean-Marc Lasgouttes wrote:
> > Le 19/07/2016 à 08:17, Scott Kostyshak a écrit :
> >
> > > The status checking in this commit ignores that buffer-zoom-out can zoom
> > > in and that buffer-
On Tue, Jul 19, 2016 at 02:08:25AM -0400, Scott Kostyshak wrote:
> On Mon, Jul 18, 2016 at 05:05:42PM +0200, Jean-Marc Lasgouttes wrote:
> > commit 8884c4044d7c1d29526aca7b0be1734231c89207
> > Author: Jean-Marc Lasgouttes
> > Date: Mon Jul 18 16:44:06 2016 +0200
> >
> > Add feedback in stat
On Tue, Jul 19, 2016 at 12:12:25PM +0200, Jean-Marc Lasgouttes wrote:
> Le 19/07/2016 à 08:17, Scott Kostyshak a écrit :
>
> > The status checking in this commit ignores that buffer-zoom-out can zoom
> > in and that buffer-zoom-in can zoom out (in fact our implementation of
> > zooming with the sc
Le 19/07/2016 à 08:17, Scott Kostyshak a écrit :
The status checking in this commit ignores that buffer-zoom-out can zoom
in and that buffer-zoom-in can zoom out (in fact our implementation of
zooming with the scroll wheel only uses buffer-zoom-in). They both
accept positive and negative argumen
On Mon, Jul 18, 2016 at 05:05:42PM +0200, Jean-Marc Lasgouttes wrote:
> commit 8884c4044d7c1d29526aca7b0be1734231c89207
> Author: Jean-Marc Lasgouttes
> Date: Mon Jul 18 16:44:06 2016 +0200
>
> Add feedback in status bar when zooming
>
> Moreover enforce better the lower limit of 1
On Mon, Jul 18, 2016 at 05:05:42PM +0200, Jean-Marc Lasgouttes wrote:
> commit 8884c4044d7c1d29526aca7b0be1734231c89207
> Author: Jean-Marc Lasgouttes
> Date: Mon Jul 18 16:44:06 2016 +0200
>
> Add feedback in status bar when zooming
>
> Moreover enforce better the lower limit of 1
14 matches
Mail list logo
