On Sat, Nov 10, 2007 at 07:01:57PM +0100, Enrico Forestieri wrote:
> + static size_t
> + length(char_type const * s)
> + {
> + char_type const * p = s;
> + while (*p)
> + +p;
Gotcha... should be ++p, of course.
> + return (p - s
On Sat, Nov 10, 2007 at 01:08:41PM +0100, Andre Poenitz wrote:
> On Fri, Nov 09, 2007 at 12:22:25AM +0100, Enrico Forestieri wrote:
> > > Hm... the easy way out would probably be an #include or such
> > > guarded by #ifdef SOMETHING_CYGWIN_SPECIFIC.
> > >
> > > But there should be something chea
On Sat, Nov 10, 2007 at 12:49:44PM +0100, Andre Poenitz wrote:
> On Thu, Nov 08, 2007 at 11:58:19PM +0100, Enrico Forestieri wrote:
> > > Hm... the easy way out would probably be an #include or such
> > > guarded by #ifdef SOMETHING_CYGWIN_SPECIFIC.
> >
> > I don't think this is cygwin specific,
On Fri, Nov 09, 2007 at 12:22:25AM +0100, Enrico Forestieri wrote:
> > Hm... the easy way out would probably be an #include or such
> > guarded by #ifdef SOMETHING_CYGWIN_SPECIFIC.
> >
> > But there should be something cheaper.
> >
> > Is USE_WCHAR_T defined for you?
> > What type is lyx::char_t
On Thu, Nov 08, 2007 at 11:58:19PM +0100, Enrico Forestieri wrote:
> > Hm... the easy way out would probably be an #include or such
> > guarded by #ifdef SOMETHING_CYGWIN_SPECIFIC.
>
> I don't think this is cygwin specific, though.
Possibly. But as long as we don't have
> > But there should be
On Fri, Nov 09, 2007 at 11:33:30AM +0100, Abdelrazak Younes wrote:
> Enrico Forestieri wrote:
> > On Thu, Nov 08, 2007 at 10:31:02PM +0100, Andre Poenitz wrote:
> >> On Thu, Nov 08, 2007 at 10:10:48PM +0100, Enrico Forestieri wrote:
> >>> [...]
> The Standard says how basic_istream<> etc shoul
Enrico Forestieri wrote:
On Thu, Nov 08, 2007 at 10:31:02PM +0100, Andre Poenitz wrote:
On Thu, Nov 08, 2007 at 10:10:48PM +0100, Enrico Forestieri wrote:
[...]
The Standard says how basic_istream<> etc should be defined. It does not
mandate that #include is the only way to get it. Doing it '
On Thu, Nov 08, 2007 at 10:31:02PM +0100, Andre Poenitz wrote:
> On Thu, Nov 08, 2007 at 10:10:48PM +0100, Enrico Forestieri wrote:
> > [...]
> > > The Standard says how basic_istream<> etc should be defined. It does not
> > > mandate that #include is the only way to get it. Doing it 'by
> > > han
On Thu, Nov 08, 2007 at 11:43:36PM +0100, Andre Poenitz wrote:
> On Thu, Nov 08, 2007 at 10:58:00PM +0100, Enrico Forestieri wrote:
> > On Thu, Nov 08, 2007 at 10:31:02PM +0100, Andre Poenitz wrote:
> >
> > > I am currently compiling with the attached changes. Would be nice if you
> > > could veri
On Thu, Nov 08, 2007 at 11:43:36PM +0100, Andre Poenitz wrote:
> On Thu, Nov 08, 2007 at 10:58:00PM +0100, Enrico Forestieri wrote:
> > On Thu, Nov 08, 2007 at 10:31:02PM +0100, Andre Poenitz wrote:
> >
> > > I am currently compiling with the attached changes. Would be nice if you
> > > could veri
On Thu, Nov 08, 2007 at 10:58:00PM +0100, Enrico Forestieri wrote:
> On Thu, Nov 08, 2007 at 10:31:02PM +0100, Andre Poenitz wrote:
>
> > I am currently compiling with the attached changes. Would be nice if you
> > could verify that it would work for you as well.
>
> I get the following error:
>
On Thu, Nov 08, 2007 at 10:31:02PM +0100, Andre Poenitz wrote:
> I am currently compiling with the attached changes. Would be nice if you
> could verify that it would work for you as well.
I get the following error:
g++ -DHAVE_CONFIG_H -I. -I../../../src/support -I../../src
-I../../../src/suppo
On Thu, Nov 08, 2007 at 10:10:48PM +0100, Enrico Forestieri wrote:
> [...]
> > The Standard says how basic_istream<> etc should be defined. It does not
> > mandate that #include is the only way to get it. Doing it 'by
> > hand' is as legal even if less convienient than the #include.
>
> Then do i
On Thu, Nov 08, 2007 at 10:06:36PM +0100, Andre Poenitz wrote:
> On Thu, Nov 08, 2007 at 09:41:33PM +0100, Enrico Forestieri wrote:
> > > Because it voids 30% of the effect of having strfwd.h at all and it is
> > > not needed here and therefore probably on ~100% of the Linux systems out
> > > there
On Thu, Nov 08, 2007 at 09:41:33PM +0100, Enrico Forestieri wrote:
> > Because it voids 30% of the effect of having strfwd.h at all and it is
> > not needed here and therefore probably on ~100% of the Linux systems out
> > there.
>
> Even if that doesn't matter for you, there are other systems tha
On Thu, Nov 08, 2007 at 08:58:06PM +, José Matos wrote:
> On Thursday 08 November 2007 20:41:33 Enrico Forestieri wrote:
> > Even if that doesn't matter for you, there are other systems than
> > Linux out there and doing things the standard way usually helps.
>
> Not wanting to enter in a di
On Thursday 08 November 2007 20:41:33 Enrico Forestieri wrote:
> Even if that doesn't matter for you, there are other systems than
> Linux out there and doing things the standard way usually helps.
Not wanting to enter in a discussion with you, but the standard way is the
linux way. ;-)
Fort
On Thu, Nov 08, 2007 at 09:44:46PM +0100, Andre Poenitz wrote:
> On Thu, Nov 08, 2007 at 09:30:55PM +0100, Enrico Forestieri wrote:
> > > On second thoughts: I would agree to a solution using some kind of
> > > #ifdef as long as it does not lead to a #include on vanilla
> > > Linux.
> >
> > There
On Thu, Nov 08, 2007 at 09:30:55PM +0100, Enrico Forestieri wrote:
> > On second thoughts: I would agree to a solution using some kind of
> > #ifdef as long as it does not lead to a #include on vanilla
> > Linux.
>
> There's no need for any #ifdef. If you want forward declarations,
> then the ios
On Thu, Nov 08, 2007 at 09:38:08PM +0100, Andre Poenitz wrote:
> On Thu, Nov 08, 2007 at 09:19:25PM +0100, Enrico Forestieri wrote:
> > On Thu, Nov 08, 2007 at 09:04:37PM +0100, Andre Poenitz wrote:
> > > On Thu, Nov 08, 2007 at 07:53:13PM +0100, Enrico Forestieri wrote:
> > > > On Thu, Nov 08, 200
On Thu, Nov 08, 2007 at 09:26:52PM +0100, Enrico Forestieri wrote:
> > If we re-use other people's code, leaving their copyright messages
> > intact is the least we can do.
>
> Hmm, there was no other people's code left, me thinks.
Then please say so in the commit message.
Andre'
On Thu, Nov 08, 2007 at 09:19:25PM +0100, Enrico Forestieri wrote:
> On Thu, Nov 08, 2007 at 09:04:37PM +0100, Andre Poenitz wrote:
> > On Thu, Nov 08, 2007 at 07:53:13PM +0100, Enrico Forestieri wrote:
> > > On Thu, Nov 08, 2007 at 06:13:15PM +0100, Andre Poenitz wrote:
> > > > On Thu, Nov 08, 200
On Thu, Nov 08, 2007 at 09:27:53PM +0100, Andre Poenitz wrote:
> On Thu, Nov 08, 2007 at 07:53:13PM +0100, Enrico Forestieri wrote:
> > On Thu, Nov 08, 2007 at 06:13:15PM +0100, Andre Poenitz wrote:
> > > On Thu, Nov 08, 2007 at 01:55:44PM +0100, Enrico Forestieri wrote:
> > > > At least, I would s
On Thu, Nov 08, 2007 at 09:13:37PM +0100, Andre Poenitz wrote:
> On Thu, Nov 08, 2007 at 09:01:55PM +0100, Andre Poenitz wrote:
> > On Thu, Nov 08, 2007 at 06:05:20AM -, [EMAIL PROTECTED] wrote:
> > > Author: forenr
> > > Date: Thu Nov 8 07:05:19 2007
> > > New Revision: 21513
> > >
> > > URL
On Thu, Nov 08, 2007 at 07:53:13PM +0100, Enrico Forestieri wrote:
> On Thu, Nov 08, 2007 at 06:13:15PM +0100, Andre Poenitz wrote:
> > On Thu, Nov 08, 2007 at 01:55:44PM +0100, Enrico Forestieri wrote:
> > > At least, I would suggest changing
> > >
> > > #ifdef _MSC_VER
> > >
> > > into
> > >
On Thu, Nov 08, 2007 at 09:01:55PM +0100, Andre Poenitz wrote:
> On Thu, Nov 08, 2007 at 06:05:20AM -, [EMAIL PROTECTED] wrote:
> > Author: forenr
> > Date: Thu Nov 8 07:05:19 2007
> > New Revision: 21513
> >
> > URL: http://www.lyx.org/trac/changeset/21513
> > Log:
> > Fix problems with odoc
On Thu, Nov 08, 2007 at 09:04:37PM +0100, Andre Poenitz wrote:
> On Thu, Nov 08, 2007 at 07:53:13PM +0100, Enrico Forestieri wrote:
> > On Thu, Nov 08, 2007 at 06:13:15PM +0100, Andre Poenitz wrote:
> > > On Thu, Nov 08, 2007 at 01:55:44PM +0100, Enrico Forestieri wrote:
> > > > At least, I would s
On Thu, Nov 08, 2007 at 09:01:55PM +0100, Andre Poenitz wrote:
> On Thu, Nov 08, 2007 at 06:05:20AM -, [EMAIL PROTECTED] wrote:
> > Author: forenr
> > Date: Thu Nov 8 07:05:19 2007
> > New Revision: 21513
> >
> > URL: http://www.lyx.org/trac/changeset/21513
> > Log:
> > Fix problems with odoc
On Thu, Nov 08, 2007 at 07:53:13PM +0100, Enrico Forestieri wrote:
> On Thu, Nov 08, 2007 at 06:13:15PM +0100, Andre Poenitz wrote:
> > On Thu, Nov 08, 2007 at 01:55:44PM +0100, Enrico Forestieri wrote:
> > > At least, I would suggest changing
> > >
> > > #ifdef _MSC_VER
> > >
> > > into
> > >
On Thu, Nov 08, 2007 at 06:05:20AM -, [EMAIL PROTECTED] wrote:
> Author: forenr
> Date: Thu Nov 8 07:05:19 2007
> New Revision: 21513
>
> URL: http://www.lyx.org/trac/changeset/21513
> Log:
> Fix problems with odocstream on "exotic" systems caused by the strfwd gimmick.
>
> * src/suppo
On Thu, Nov 08, 2007 at 06:13:15PM +0100, Andre Poenitz wrote:
> On Thu, Nov 08, 2007 at 01:55:44PM +0100, Enrico Forestieri wrote:
> > At least, I would suggest changing
> >
> > #ifdef _MSC_VER
> >
> > into
> >
> > #if ! defined(__GNUC__)
> >
> > as I think that forward declaring string is a
On Thu, Nov 08, 2007 at 01:55:44PM +0100, Enrico Forestieri wrote:
> At least, I would suggest changing
>
> #ifdef _MSC_VER
>
> into
>
> #if ! defined(__GNUC__)
>
> as I think that forward declaring string is a gcc-ism.
On what foundations did you base your thinking?
Andre'
On Thu, Nov 08, 2007 at 02:01:05PM +0100, Abdelrazak Younes wrote:
> Hum, there is even more than I though; in strfwd.h:
>
> #ifdef USE_WCHAR_T
>
> // Prefer this if possible because GNU libstdc++ has usable
> // std::ctype locale facets but not
> // std::ctype. gcc older than 3.4 is also missing
>
On Thu, Nov 08, 2007 at 08:24:49AM +0100, Abdelrazak Younes wrote:
> Enrico Forestieri wrote:
>> On Thu, Nov 08, 2007 at 06:05:20AM -, [EMAIL PROTECTED] wrote:
>>> Author: forenr
>>> Date: Thu Nov 8 07:05:19 2007
>>> New Revision: 21513
>>>
>>> URL: http://www.lyx.org/trac/changeset/21513
>>>
On Thu, Nov 08, 2007 at 03:40:11PM +0100, Abdelrazak Younes wrote:
> Enrico Forestieri wrote:
> > On Thu, Nov 08, 2007 at 02:45:36PM +0100, Enrico Forestieri wrote:
> >> On Thu, Nov 08, 2007 at 02:25:29PM +0100, Abdelrazak Younes wrote:
> >>> Enrico Forestieri wrote:
> >> [...]
> I don't have
Enrico Forestieri wrote:
On Thu, Nov 08, 2007 at 02:45:36PM +0100, Enrico Forestieri wrote:
On Thu, Nov 08, 2007 at 02:25:29PM +0100, Abdelrazak Younes wrote:
Enrico Forestieri wrote:
[...]
I don't have gcc 3.3 and could not test it. I'd rather not change it
unless someone reports problems.
S
On Thu, Nov 08, 2007 at 02:45:36PM +0100, Enrico Forestieri wrote:
> On Thu, Nov 08, 2007 at 02:25:29PM +0100, Abdelrazak Younes wrote:
> > Enrico Forestieri wrote:
> [...]
> > > I don't have gcc 3.3 and could not test it. I'd rather not change it
> > > unless someone reports problems.
> >
> > So
On Thu, Nov 08, 2007 at 02:01:44PM +0100, Abdelrazak Younes wrote:
> Enrico Forestieri wrote:
[...]
> > Maybe we could
> > simply forward declare string for every platform. Will make some tests.
>
> Right. Be my guest ;-)
I did it:
http://www.lyx.org/trac/changeset/21518
--
Enrico
On Thu, Nov 08, 2007 at 02:25:29PM +0100, Abdelrazak Younes wrote:
> Enrico Forestieri wrote:
[...]
> > I don't have gcc 3.3 and could not test it. I'd rather not change it
> > unless someone reports problems.
>
> So I am wrong and USE_WCHAR_T is correctly detected and used. Then why
> did you pu
On Thu, Nov 08, 2007 at 02:28:26PM +0100, Abdelrazak Younes wrote:
> You are of course. Still, why don't we just generalised the code to use
> boost::uint32_t on all platforms? This would allow us to get rid of the
> configure testing for wchar_t etc.
Look at the comment in strfwd.h ;-)
Moreov
Enrico Forestieri wrote:
On Thu, Nov 08, 2007 at 01:54:33PM +0100, Abdelrazak Younes wrote:
Enrico Forestieri wrote:
On Thu, Nov 08, 2007 at 06:05:20AM -, [EMAIL PROTECTED] wrote:
Author: forenr
Date: Thu Nov 8 07:05:19 2007
New Revision: 21513
URL: http://www.lyx.org/trac/changeset/2151
Enrico Forestieri wrote:
On Thu, Nov 08, 2007 at 02:01:05PM +0100, Abdelrazak Younes wrote:
Hum, there is even more than I though; in strfwd.h:
#ifdef USE_WCHAR_T
// Prefer this if possible because GNU libstdc++ has usable
// std::ctype locale facets but not
// std::ctype. gcc older than 3.4
Abdelrazak Younes wrote:
Jean-Marc Lasgouttes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
By the way, IIUC you did this move because USE_WCHAR_T is defined in
which is included only in the cpp, right?
In this case you might also want to do the same for the char_traits
implementation
On Thu, Nov 08, 2007 at 02:01:05PM +0100, Abdelrazak Younes wrote:
> Hum, there is even more than I though; in strfwd.h:
>
> #ifdef USE_WCHAR_T
>
> // Prefer this if possible because GNU libstdc++ has usable
> // std::ctype locale facets but not
> // std::ctype. gcc older than 3.4 is also missin
On Thu, Nov 08, 2007 at 01:54:33PM +0100, Abdelrazak Younes wrote:
> Enrico Forestieri wrote:
> > On Thu, Nov 08, 2007 at 06:05:20AM -, [EMAIL PROTECTED] wrote:
> >> Author: forenr
> >> Date: Thu Nov 8 07:05:19 2007
> >> New Revision: 21513
> >>
> >> URL: http://www.lyx.org/trac/changeset/2151
Jean-Marc Lasgouttes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
By the way, IIUC you did this move because USE_WCHAR_T is defined in
which is included only in the cpp, right?
In this case you might also want to do the same for the char_traits
implementation beginning at docstring.h:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
> By the way, IIUC you did this move because USE_WCHAR_T is defined in
> which is included only in the cpp, right?
>
> In this case you might also want to do the same for the char_traits
> implementation beginning at docstring.h:92:
>
In any case, whe
Enrico Forestieri wrote:
On Thu, Nov 08, 2007 at 01:45:42PM +0100, Abdelrazak Younes wrote:
Enrico Forestieri wrote:
On Thu, Nov 08, 2007 at 08:51:06AM +0100, Abdelrazak Younes wrote:
Enrico Forestieri wrote:
Abdel, I am not sure it is ok with MSVC. Can you confirm it?
This did the trick:
H
Abdelrazak Younes wrote:
Enrico Forestieri wrote:
On Thu, Nov 08, 2007 at 06:05:20AM -,
[EMAIL PROTECTED] wrote:
Author: forenr
Date: Thu Nov 8 07:05:19 2007
New Revision: 21513
URL: http://www.lyx.org/trac/changeset/21513
Log:
Fix problems with odocstream on "exotic" systems caused by th
On Thu, Nov 08, 2007 at 01:45:42PM +0100, Abdelrazak Younes wrote:
> Enrico Forestieri wrote:
> > On Thu, Nov 08, 2007 at 08:51:06AM +0100, Abdelrazak Younes wrote:
> >> Enrico Forestieri wrote:
> >
> >>> Abdel, I am not sure it is ok with MSVC. Can you confirm it?
> >> This did the trick:
> >
>
Enrico Forestieri wrote:
On Thu, Nov 08, 2007 at 06:05:20AM -, [EMAIL PROTECTED] wrote:
Author: forenr
Date: Thu Nov 8 07:05:19 2007
New Revision: 21513
URL: http://www.lyx.org/trac/changeset/21513
Log:
Fix problems with odocstream on "exotic" systems caused by the strfwd gimmick.
Enrico Forestieri wrote:
On Thu, Nov 08, 2007 at 08:51:06AM +0100, Abdelrazak Younes wrote:
Enrico Forestieri wrote:
Abdel, I am not sure it is ok with MSVC. Can you confirm it?
This did the trick:
Hmm, yep. Looking at
http://msdn2.microsoft.com/en-us/library/1af12yty(VS.80).aspx
I see tha
On Thu, Nov 08, 2007 at 08:51:06AM +0100, Abdelrazak Younes wrote:
> Enrico Forestieri wrote:
> > Abdel, I am not sure it is ok with MSVC. Can you confirm it?
>
> This did the trick:
Hmm, yep. Looking at
http://msdn2.microsoft.com/en-us/library/1af12yty(VS.80).aspx
I see that the forward declara
Enrico Forestieri wrote:
On Thu, Nov 08, 2007 at 06:05:20AM -, [EMAIL PROTECTED] wrote:
Author: forenr
Date: Thu Nov 8 07:05:19 2007
New Revision: 21513
URL: http://www.lyx.org/trac/changeset/21513
Log:
Fix problems with odocstream on "exotic" systems caused by the strfwd gimmick.
Enrico Forestieri wrote:
On Thu, Nov 08, 2007 at 06:05:20AM -, [EMAIL PROTECTED] wrote:
Author: forenr
Date: Thu Nov 8 07:05:19 2007
New Revision: 21513
URL: http://www.lyx.org/trac/changeset/21513
Log:
Fix problems with odocstream on "exotic" systems caused by the strfwd gimmick.
On Thu, Nov 08, 2007 at 06:05:20AM -, [EMAIL PROTECTED] wrote:
> Author: forenr
> Date: Thu Nov 8 07:05:19 2007
> New Revision: 21513
>
> URL: http://www.lyx.org/trac/changeset/21513
> Log:
> Fix problems with odocstream on "exotic" systems caused by the strfwd gimmick.
>
> * src/suppo
56 matches
Mail list logo
