On Thu, Nov 08, 2007 at 07:53:13PM +0100, Enrico Forestieri wrote:
> On Thu, Nov 08, 2007 at 06:13:15PM +0100, Andre Poenitz wrote:
> > On Thu, Nov 08, 2007 at 01:55:44PM +0100, Enrico Forestieri wrote:
> > > At least, I would suggest changing
> > >
> > > #ifdef _MSC_VER
> > >
> > > into
> > >
> > > #if ! defined(__GNUC__)
> > >
> > > as I think that forward declaring string is a gcc-ism.
> >
> > On what foundations did you base your thinking?
>
> That should have been read in its context. I agree that I should
> have said "as I think that forward declaring string in the iosfwd
> header is a gcc-ism", but I didn't think it would have been so
> difficult to understand.
I seem to have a bigger problem with what you do and how you do it.
Index: strfwd.h
===================================================================
--- strfwd.h (revision 21517)
+++ strfwd.h (revision 21518)
@@ -28,23 +28,23 @@
#endif
-#include<iosfwd>
+#include <iosfwd>
-#ifdef _MSC_VER
-namespace std {
+// We have to forward declare the string type as not all compilers
+// do that in the iosfwd header.
+namespace std
+{
+
template<typename Char, typename Traits, typename Alloc> class basic_string;
typedef basic_string<char, char_traits<char>, allocator<char> > string;
+
}
Why the uncalled-for stylistic changes that deviates from LyX practice?
There is not a single precedence in src/* unless
grep -R '^namespace ' | grep -v = | grep -v '{'
lies to me.
As long as such "accidents" happen I certainly would prefer if you post
your patches to list and let a few hours pass before committing them.
The fact that a few people commit first and discuss later (if at all)
does not necessarily mean everybody is entitled to do so.
Andre'
