Enrico Forestieri wrote:
On Thu, Nov 08, 2007 at 01:45:42PM +0100, Abdelrazak Younes wrote:
Enrico Forestieri wrote:
On Thu, Nov 08, 2007 at 08:51:06AM +0100, Abdelrazak Younes wrote:
Enrico Forestieri wrote:
Abdel, I am not sure it is ok with MSVC. Can you confirm it?
This did the trick:
Hmm, yep. Looking at
http://msdn2.microsoft.com/en-us/library/1af12yty(VS.80).aspx
I see that the forward declaration for the string type is missing,
while the gcc iosfwd includes it through the (compiler specific)
stringfwd.h header. Maybe MSVC has a similar header?
Nope, I've looked for it before committing my fix :-)
Otherwise
we could revert to the original (ugly) code by André.
Not needed IMHO, current state is OK with me. I'd much prefer that we
switch to a docstring class personally.
At least, I would suggest changing
#ifdef _MSC_VER
into
#if ! defined(__GNUC__)
as I think that forward declaring string is a gcc-ism. Maybe we could
simply forward declare string for every platform. Will make some tests.
Right. Be my guest ;-)
Abdel.
