Re: Metrics-related crashes in branch

2025-02-20 Thread Jean-Marc Lasgouttes
Le 29/01/2025 à 14:18, Pavel Sanda a écrit : JMarc, unless you have some other fix in mind we should perhaps backport? I have backported the two patches now. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org https://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Metrics-related crashes in branch

2025-02-10 Thread Jean-Marc Lasgouttes
Le 10/02/2025 à 22:41, Pavel Sanda a écrit : On Mon, Feb 10, 2025 at 12:42:05AM +0100, Jean-Marc Lasgouttes wrote: I mean try it on 8a181862d. I suspect this is the core reason for the crashes. If this is the case, the patch could be applied in addition to the others. I can confirm that with y

Re: Metrics-related crashes in branch

2025-02-10 Thread Pavel Sanda
On Mon, Feb 10, 2025 at 12:42:05AM +0100, Jean-Marc Lasgouttes wrote: > I mean try it on 8a181862d. I suspect this is the core reason for the > crashes. If this is the case, the patch could be applied in addition to the > others. I can confirm that with your posted patch, 8a181862d does not crash

Re: Metrics-related crashes in branch

2025-02-09 Thread Pavel Sanda
On Sat, Feb 08, 2025 at 09:21:33PM +0100, Jean-Marc Lasgouttes wrote: > Le 11/01/2025 ?? 23:53, Pavel Sanda a écrit : > > checkout the commit 8a181862d > > 0) load the file I sent you earlier > > 1) set cursor on line 1.4 > > 2) scroll 1.4 it to be the last line of the screen > > 3) close lyx > > 4

Re: Metrics-related crashes in branch

2025-02-08 Thread Jean-Marc Lasgouttes
Le 11/01/2025 à 23:53, Pavel Sanda a écrit : checkout the commit 8a181862d 0) load the file I sent you earlier 1) set cursor on line 1.4 2) scroll 1.4 it to be the last line of the screen 3) close lyx 4) remove figure cache 5) relaunch lyx & wait for figures on screen to load if not crash got

Re: Metrics-related crashes in branch

2025-01-29 Thread Pavel Sanda
On Thu, Jan 09, 2025 at 03:22:34PM +0100, Jean-Marc Lasgouttes wrote: > Le 21/12/2024 ?? 19:15, Pavel Sanda a écrit : > > Actually you are right, once the figures are loaded, the caret tends to > > stay on similar position of the screen. But not initially, it probably > > gets shifted by the onload

Re: Metrics-related crashes in branch

2025-01-11 Thread Pavel Sanda
On Fri, Jan 10, 2025 at 11:23:09AM +0100, Pavel Sanda wrote: > As it happens I have troubles to get my own recipy reliably working in > (unupdated) > master (mainly due to the fact that I can't get the pg-down to jump to first > line > of 1.4 anymore. Ok, I could find new recipy for the crash in

Re: Metrics-related crashes in branch

2025-01-10 Thread Pavel Sanda
On Thu, Jan 09, 2025 at 03:22:34PM +0100, Jean-Marc Lasgouttes wrote: > Le 21/12/2024 ?? 19:15, Pavel Sanda a écrit : > > Actually you are right, once the figures are loaded, the caret tends to > > stay on similar position of the screen. But not initially, it probably > > gets shifted by the onload

Re: Metrics-related crashes in branch

2025-01-09 Thread Jean-Marc Lasgouttes
Le 21/12/2024 à 19:15, Pavel Sanda a écrit : Actually you are right, once the figures are loaded, the caret tends to stay on similar position of the screen. But not initially, it probably gets shifted by the onloading of images above. I pushed a solution to master at 0fa3aba5c6e, if it works we

Re: Metrics-related crashes in branch

2024-12-21 Thread Pavel Sanda
On Sat, Dec 21, 2024 at 06:38:52PM +0100, Pavel Sanda wrote: > On Sat, Dec 21, 2024 at 03:06:25PM +0100, Jean-Marc Lasgouttes wrote: > > Le 20/12/2024 ?? 21:42, Pavel Sanda a écrit : > > > Not with our docs, but see the archive I sent you privately. > > > > > > 0) unpack the archive > > > 1) open

Re: Metrics-related crashes in branch

2024-12-21 Thread Pavel Sanda
On Sat, Dec 21, 2024 at 03:06:25PM +0100, Jean-Marc Lasgouttes wrote: > Le 20/12/2024 ?? 21:42, Pavel Sanda a écrit : > > Not with our docs, but see the archive I sent you privately. > > > > 0) unpack the archive > > 1) open the lyx file > > 2) the geometry of the window has to be so that first li

Re: Metrics-related crashes in branch

2024-12-21 Thread Jean-Marc Lasgouttes
Le 20/12/2024 à 21:42, Pavel Sanda a écrit : Not with our docs, but see the archive I sent you privately. 0) unpack the archive 1) open the lyx file 2) the geometry of the window has to be so that first line of section 1.1.1 is approx at the bottom of the window. see cursor.jpg screenshot. 2) c

Re: Metrics-related crashes in branch

2024-12-20 Thread Pavel Sanda
On Fri, Dec 20, 2024 at 11:12:13PM +0100, Jean-Marc Lasgouttes wrote: > What I want is to find where the missing update is. Thanks :) > But it is on branch too, right? I removed less updates there, it should be > less fragile than master. Right, I originally got the problem in the branch. The or

Re: Metrics-related crashes in branch

2024-12-20 Thread Jean-Marc Lasgouttes
Le 20/12/2024 à 21:42, Pavel Sanda a écrit : On Fri, Dec 20, 2024 at 04:07:03PM +0100, Jean-Marc Lasgouttes wrote: Does this new patch help? It contains the previous one. Yes, I can confirm that this patch "fixes" the assertion. Can you give me a recipe using one of our documentation files,

Re: Metrics-related crashes in branch

2024-12-20 Thread Pavel Sanda
On Fri, Dec 20, 2024 at 04:07:03PM +0100, Jean-Marc Lasgouttes wrote: > Does this new patch help? It contains the previous one. Yes, I can confirm that this patch "fixes" the assertion. > Can you give me a recipe using one of our documentation files, for example? Not with our docs, but see the a

Re: Metrics-related crashes in branch

2024-12-20 Thread Jean-Marc Lasgouttes
Le 20/12/2024 à 01:25, Pavel Sanda a écrit : On Wed, Dec 18, 2024 at 02:08:13PM +0100, Jean-Marc Lasgouttes wrote: Thanks for the backtrace. So is it only a thing in branch? Note that the assertion in ParagraphMetrics::position() is new, so this might be an old problem that we detect only now.

Re: Metrics-related crashes in branch

2024-12-19 Thread Pavel Sanda
On Wed, Dec 18, 2024 at 02:08:13PM +0100, Jean-Marc Lasgouttes wrote: > > Thanks for the backtrace. So is it only a thing in branch? Note that the > > assertion in ParagraphMetrics::position() is new, so this might be an > > old problem that we detect only now. > > The patch below should fix the s

Re: Metrics-related crashes in branch

2024-12-18 Thread Jean-Marc Lasgouttes
me up with something in the next days. Currently I am strugling to reproduce even on branch with different machine but the same document... This looks indeed tricky. What the backtrace says is that the cursor is in a paragraph for which metrics are not known (is it out of screen? I do not know). There

Re: Metrics-related crashes in branch

2024-12-18 Thread Pavel Sanda
On Wed, Dec 18, 2024 at 02:08:13PM +0100, Jean-Marc Lasgouttes wrote: > Le 17/12/2024 ?? 23:07, Jean-Marc Lasgouttes a écrit : > > Le 17/12/2024 ?? 23:01, Pavel Sanda a écrit : > > > On Tue, Dec 17, 2024 at 10:38:08PM +0100, Pavel Sanda wrote: > > > > Hi, > > > > > > > > this happened couple times

Re: Metrics-related crashes in branch

2024-12-18 Thread Jean-Marc Lasgouttes
Le 17/12/2024 à 23:07, Jean-Marc Lasgouttes a écrit : Le 17/12/2024 à 23:01, Pavel Sanda a écrit : On Tue, Dec 17, 2024 at 10:38:08PM +0100, Pavel Sanda wrote: Hi, this happened couple times today in the particular document, which loads ton of pdf images, somewhere in the middle of initial lo

Re: Metrics-related crashes in branch

2024-12-17 Thread Jean-Marc Lasgouttes
Le 17/12/2024 à 23:01, Pavel Sanda a écrit : On Tue, Dec 17, 2024 at 10:38:08PM +0100, Pavel Sanda wrote: Hi, this happened couple times today in the particular document, which loads ton of pdf images, somewhere in the middle of initial loading and scrolling (at the same time). I'll try to co

Re: Metrics-related crashes in branch

2024-12-17 Thread Pavel Sanda
On Tue, Dec 17, 2024 at 10:38:08PM +0100, Pavel Sanda wrote: > Hi, > > this happened couple times today in the particular document, which loads ton > of pdf images, > somewhere in the middle of initial loading and scrolling (at the same time). > > I'll try to come up with some recipe, but it see

Metrics-related crashes in branch

2024-12-17 Thread Pavel Sanda
Hi, this happened couple times today in the particular document, which loads ton of pdf images, somewhere in the middle of initial loading and scrolling (at the same time). I'll try to come up with some recipe, but it seems very hard to reproduce on demand, I need to load it like 20x to get it

Re: [LyX/master] Avoid some full metrics computations related to math previews

2024-12-02 Thread Scott Kostyshak
On Mon, Dec 02, 2024 at 04:05:26PM +0100, Jean-Marc Lasgouttes wrote: > Le 01/12/2024 à 11:12, Scott Kostyshak a écrit : > > A bisect led me here. I was trying to reproduce an issue that Andrew > > reported, but I think it is actually a different issue. I attach > > Andrew's example file. > > > >

Re: [LyX/master] Avoid some full metrics computations related to math previews

2024-12-02 Thread Jean-Marc Lasgouttes
Le 02/12/2024 à 18:22, Scott Kostyshak a écrit : I can reproduce, but not necessarily understand what happens. Can you create a ticket please? Opened here: https://www.lyx.org/trac/ticket/13128 Thanks Scott! JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org https://lists.lyx.org/ma

Re: [LyX/master] Avoid some full metrics computations related to math previews

2024-12-02 Thread Jean-Marc Lasgouttes
Le 01/12/2024 à 11:12, Scott Kostyshak a écrit : A bisect led me here. I was trying to reproduce an issue that Andrew reported, but I think it is actually a different issue. I attach Andrew's example file. Recipe: 1. Enable preview in preferences. 2. Click on the math equation row 1. 3. Click s

Re: [LyX/master] Avoid some full metrics computations related to math previews

2024-12-01 Thread Scott Kostyshak
On Fri, Apr 05, 2024 at 01:58:16PM +, Jean-Marc Lasgouttes wrote: > commit 5e8578837fea0321998eac04222102986261666d > Author: Jean-Marc Lasgouttes > Date: Mon Nov 27 15:13:56 2023 +0100 > > Avoid some full metrics computations related to math previews > >

Re: [LyX/master] Fix up 'Reduce metrics updates from 4 to 1 when loading file'

2024-05-07 Thread Scott Kostyshak
On Tue, May 07, 2024 at 12:16:24PM GMT, Jean-Marc Lasgouttes wrote: > Le 07/05/2024 à 04:49, Scott Kostyshak a écrit : > > > Yes, I am aware of that, I'll try to fix it tomorrow. I hoped to do that > > > before anyone noticed ;) > > > > Sounds good! No rush. > > It is fixed now. I guess macOS wa

Re: [LyX/master] Fix up 'Reduce metrics updates from 4 to 1 when loading file'

2024-05-07 Thread Jean-Marc Lasgouttes
Le 07/05/2024 à 04:49, Scott Kostyshak a écrit : Yes, I am aware of that, I'll try to fix it tomorrow. I hoped to do that before anyone noticed ;) Sounds good! No rush. It is fixed now. I guess macOS was affected too. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.ly

Re: [LyX/master] Fix up 'Reduce metrics updates from 4 to 1 when loading file'

2024-05-06 Thread Scott Kostyshak
On Mon, May 06, 2024 at 10:20:34PM GMT, Jean-Marc Lasgouttes wrote: > > > Le 6 mai 2024 18:06:43 GMT+02:00, Scott Kostyshak a écrit : > >> Now when I start up LyX with no document (such that it shows the splash > >> screen), and then start a new document, there seems to be a missing > >> update.

Re: [LyX/master] Fix up 'Reduce metrics updates from 4 to 1 when loading file'

2024-05-06 Thread Jean-Marc Lasgouttes
Le 6 mai 2024 18:06:43 GMT+02:00, Scott Kostyshak a écrit : >> Now when I start up LyX with no document (such that it shows the splash >> screen), and then start a new document, there seems to be a missing >> update. See attached. > Hi Scott, Yes, I am aware of that, I'll try to fix it tomorro

Re: [LyX/master] Fix up 'Reduce metrics updates from 4 to 1 when loading file'

2024-05-06 Thread Scott Kostyshak
On Mon, May 06, 2024 at 12:00:58PM GMT, Scott Kostyshak wrote: > On Tue, Apr 30, 2024 at 10:11:29AM GMT, Jean-Marc Lasgouttes wrote: > > commit 527984ed2e0269861f5e1efc021fa0302d80819b > > Author: Jean-Marc Lasgouttes > > Date: Mon Apr 29 14:22:57 2024 +0200 > > >

Re: [LyX/master] Fix up 'Reduce metrics updates from 4 to 1 when loading file'

2024-05-06 Thread Scott Kostyshak
On Tue, Apr 30, 2024 at 10:11:29AM GMT, Jean-Marc Lasgouttes wrote: > commit 527984ed2e0269861f5e1efc021fa0302d80819b > Author: Jean-Marc Lasgouttes > Date: Mon Apr 29 14:22:57 2024 +0200 > > Fix up 'Reduce metrics updates from 4 to 1 when loading file' >

Re: [LyX features/biginset] Indicate that, by default, mouse LFUN do not require a metrics update

2023-11-27 Thread Jean-Marc Lasgouttes
{ LFUN_MOUSE_RELEASE, "", ReadOnly, Hidden }, + { LFUN_MOUSE_RELEASE, "", ReadOnly | NoUpdate, Hidden }, I know nothing about this, just thinking whether triggered DEPM or (un)collapsing insets when clicking away should not tigger metrics update? I _think_ that

Re: [LyX features/biginset] Indicate that, by default, mouse LFUN do not require a metrics update

2023-11-27 Thread Pavel Sanda
RELEASE, "", ReadOnly, Hidden }, > + { LFUN_MOUSE_RELEASE, "", ReadOnly | NoUpdate, Hidden }, I know nothing about this, just thinking whether triggered DEPM or (un)collapsing insets when clicking away should not tigger metrics update? Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX features/biginset] Reduce metrics updates from 4 to 1 when loading file

2023-11-26 Thread Richard Kimberly Heck
at least that bugs will be easy to fix). Patches that avoid full metrics computation are different : these extra metrics computation steps have often been used as an easy (and robust but inefficient) way to fix real issues. Before removing these extra calls, one has to understand what bug they

Re: [LyX features/biginset] Reduce metrics updates from 4 to 1 when loading file

2023-11-26 Thread Jean-Marc Lasgouttes
that avoid full metrics computation are different : these extra metrics computation steps have often been used as an easy (and robust but inefficient) way to fix real issues. Before removing these extra calls, one has to understand what bug they fix, and whether we can be convinced that the new

Re: [LyX features/biginset] Reduce metrics updates from 4 to 1 when loading file

2023-11-24 Thread Richard Kimberly Heck
On 11/24/23 14:25, Jean-Marc Lasgouttes wrote: Le 24/11/2023 à 19:28, Richard Kimberly Heck a écrit : On 11/24/23 07:46, Jean-Marc Lasgouttes wrote: commit c81ec3c7e934f1ba30e3933655cd7a53cf9c23c2 Author: Jean-Marc Lasgouttes Date:   Wed Nov 22 12:07:51 2023 +0100 Reduce metrics updates

Re: [LyX features/biginset] Reduce metrics updates from 4 to 1 when loading file

2023-11-24 Thread Scott Kostyshak
; > > Date:   Wed Nov 22 12:07:51 2023 +0100 > > > > > > Reduce metrics updates from 4 to 1 when loading file > > > > Well done! I'm looking forward to seeing this in 2.4.1! > > Since such changes can lead to nasty bugs, my plan was to backport

Re: [LyX features/biginset] Reduce metrics updates from 4 to 1 when loading file

2023-11-24 Thread Jean-Marc Lasgouttes
Le 24/11/2023 à 19:28, Richard Kimberly Heck a écrit : On 11/24/23 07:46, Jean-Marc Lasgouttes wrote: commit c81ec3c7e934f1ba30e3933655cd7a53cf9c23c2 Author: Jean-Marc Lasgouttes Date:   Wed Nov 22 12:07:51 2023 +0100 Reduce metrics updates from 4 to 1 when loading file Well done! I&#

Re: [LyX features/biginset] Reduce metrics updates from 4 to 1 when loading file

2023-11-24 Thread Richard Kimberly Heck
On 11/24/23 07:46, Jean-Marc Lasgouttes wrote: commit c81ec3c7e934f1ba30e3933655cd7a53cf9c23c2 Author: Jean-Marc Lasgouttes Date: Wed Nov 22 12:07:51 2023 +0100 Reduce metrics updates from 4 to 1 when loading file Well done! I'm looking forward to seeing this in 2.4.1! Riki -

Re: [LyX features/breakrows] Increase metrics cache maximal size

2021-10-07 Thread Jean-Marc Lasgouttes
Le 07/10/2021 à 04:30, Scott Kostyshak a écrit : Nice! Thanks for working on this. This piques my curiosity about what other cache levers can be adjusted. I really like that Okular (see attachment) let's me control the tradeoff between memory usage and performance. For example, in LyX, is it p

Re: [LyX features/breakrows] Increase metrics cache maximal size

2021-10-06 Thread Scott Kostyshak
Date: Tue Oct 5 15:52:31 2021 +0200 > > Increase metrics cache maximal size > > Increase the maximal size of the breakString cache (to compute where > to break lines) from 512kB to 10MB. This has a big impact of cache > hits on large file like the

Re: [LyX/master] Improve (modestly) the performance of font metrics caches

2021-09-24 Thread Jean-Marc Lasgouttes
Le 24/09/2021 à 17:23, Kornel Benko a écrit : Am Fri, 24 Sep 2021 16:51:35 +0200 (CEST) schrieb Jean-Marc Lasgouttes : commit 6bbd88accfb76248d00346f308ba1f67f186e094 Author: Jean-Marc Lasgouttes Date: Fri Sep 24 16:57:05 2021 +0200 Improve (modestly) the performance of font metrics

Re: [LyX/master] Improve (modestly) the performance of font metrics caches

2021-09-24 Thread Kornel Benko
Am Fri, 24 Sep 2021 16:51:35 +0200 (CEST) schrieb Jean-Marc Lasgouttes : > commit 6bbd88accfb76248d00346f308ba1f67f186e094 > Author: Jean-Marc Lasgouttes > Date: Fri Sep 24 16:57:05 2021 +0200 > > Improve (modestly) the performance of font metrics caches /usr2/src/

Re: [LyX/master] Improve metrics for \limits in display mode

2020-07-18 Thread Jean-Marc Lasgouttes
Le 18/07/2020 à 16:57, Richard Kimberly Heck a écrit : This is purely cosmetic and candidate for branch. Riki? OK. Thanks, done. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/master] Improve metrics for \limits in display mode

2020-07-18 Thread Richard Kimberly Heck
On 7/17/20 4:21 PM, Jean-Marc Lasgouttes wrote: > Le 17/07/2020 à 21:55, Jean-Marc Lasgouttes a écrit : >> commit 8d54457dbf6ab41083b5c769be22b8333f764037 >> Author: Jean-Marc Lasgouttes >> Date:   Fri Jul 17 18:48:39 2020 +0200 >> >> Improve metrics for \l

Re: [LyX/master] Improve metrics for \limits in display mode

2020-07-17 Thread Jean-Marc Lasgouttes
Le 17/07/2020 à 21:55, Jean-Marc Lasgouttes a écrit : commit 8d54457dbf6ab41083b5c769be22b8333f764037 Author: Jean-Marc Lasgouttes Date: Fri Jul 17 18:48:39 2020 +0200 Improve metrics for \limits in display mode This is purely cosmetic and candidate for branch. Riki? JMarc

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2020-05-28 Thread Scott Kostyshak
On Thu, May 28, 2020 at 08:44:18PM +0200, Jean-Marc Lasgouttes wrote: > Le 25/05/2020 à 16:37, Jean-Marc Lasgouttes a écrit : > > Le 25/05/2020 à 16:23, Scott Kostyshak a écrit : > > > > Rereading your mail ... if we use another character (e.g. > > > > \alpha), the box is OK. > > > > Checking all G

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2020-05-28 Thread Jean-Marc Lasgouttes
Le 25/05/2020 à 16:37, Jean-Marc Lasgouttes a écrit : Le 25/05/2020 à 16:23, Scott Kostyshak a écrit : Rereading your mail ... if we use another character (e.g. \alpha), the box is OK. Checking all Greek chars, only epsilon box looks bad. (and \omicron 'ο' is missing, while \textomicron exists

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2020-05-25 Thread Scott Kostyshak
On Mon, May 25, 2020 at 04:37:01PM +0200, Jean-Marc Lasgouttes wrote: > Le 25/05/2020 à 16:23, Scott Kostyshak a écrit : > > > Rereading your mail ... if we use another character (e.g. \alpha), the > > > box is OK. > > > Checking all Greek chars, only epsilon box looks bad. (and \omicron 'ο' > >

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2020-05-25 Thread Scott Kostyshak
uthor: Jean-Marc Lasgouttes > > > Date: Mon Feb 19 18:24:29 2018 +0100 > > > > > > Improve metrics of equations. More work remains to be done. > > > > > > Use proper value for above/below skip (12pt) instead of the hardcoded > >

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2020-05-25 Thread Enrico Forestieri
On Sun, May 24, 2020 at 09:43:55PM -0400, Scott Kostyshak wrote: > On Mon, Feb 19, 2018 at 06:36:36PM +0100, Jean-Marc Lasgouttes wrote: > > commit 56e012be83fd4fec1e21d750e961ff936cc8c889 > > Author: Jean-Marc Lasgouttes > > Date: Mon Feb 19 18:24:29 2018 +0100 > >

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2020-05-25 Thread Jean-Marc Lasgouttes
Le 25/05/2020 à 16:23, Scott Kostyshak a écrit : Rereading your mail ... if we use another character (e.g. \alpha), the box is OK. Checking all Greek chars, only epsilon box looks bad. (and \omicron 'ο' is missing, while \textomicron exists) It also seems not to depend on the zoom level. So

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2020-05-25 Thread Scott Kostyshak
ak : > > > > > > > On Mon, Feb 19, 2018 at 06:36:36PM +0100, Jean-Marc Lasgouttes wrote: > > > > > commit 56e012be83fd4fec1e21d750e961ff936cc8c889 > > > > > Author: Jean-Marc Lasgouttes > > > > > Date: Mon Feb 19 18:2

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2020-05-25 Thread Kornel Benko
outtes wrote: > > > > commit 56e012be83fd4fec1e21d750e961ff936cc8c889 > > > > Author: Jean-Marc Lasgouttes > > > > Date: Mon Feb 19 18:24:29 2018 +0100 > > > > > > > > Improve metrics of equations. More work remains to be

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2020-05-25 Thread Scott Kostyshak
> Author: Jean-Marc Lasgouttes > > > Date: Mon Feb 19 18:24:29 2018 +0100 > > > > > > Improve metrics of equations. More work remains to be done. > > > > > > Use proper value for above/below skip (12pt) instead of the hardcoded > >

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2020-05-25 Thread Kornel Benko
Am Sun, 24 May 2020 21:43:55 -0400 schrieb Scott Kostyshak : > On Mon, Feb 19, 2018 at 06:36:36PM +0100, Jean-Marc Lasgouttes wrote: > > commit 56e012be83fd4fec1e21d750e961ff936cc8c889 > > Author: Jean-Marc Lasgouttes > > Date: Mon Feb 19 18:24:29 2018 +0100 > >

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2020-05-24 Thread Scott Kostyshak
On Mon, Feb 19, 2018 at 06:36:36PM +0100, Jean-Marc Lasgouttes wrote: > commit 56e012be83fd4fec1e21d750e961ff936cc8c889 > Author: Jean-Marc Lasgouttes > Date: Mon Feb 19 18:24:29 2018 +0100 > > Improve metrics of equations. More work remains to be done. > >

Re: metrics of *(Ly|Te)X* logos

2019-05-10 Thread Guenter Milde
On 2019-05-10, Jean-Marc Lasgouttes wrote: > Le 09/05/2019 à 21:20, Guenter Milde a écrit : >> Just tested with a wide range of fonts: EB Garamond has the problem as well, >> only monospaced fonts don't show this overprinting and Gentium only slightly. > Fixed at 3a7346b0cbb. Confirmed. Thank y

Re: metrics of *(Ly|Te)X* logos

2019-05-10 Thread Jean-Marc Lasgouttes
Le 09/05/2019 à 21:20, Guenter Milde a écrit : Just tested with a wide range of fonts: EB Garamond has the problem as well, only monospaced fonts don't show this overprinting and Gentium only slightly. Fixed at 3a7346b0cbb. Sorry that it took so long for me to see the issue. JMarc

Re: metrics of *(Ly|Te)X* logos

2019-05-09 Thread jungok
"by the LyX > >>> Team") > >>>with whitespace between LyX and Team) > >>> * "?" printed over the "X" in "What is LyX?". > >>> > >>> Hope this helps a bit, > >> > >> You me

Re: metrics of *(Ly|Te)X* logos

2019-05-09 Thread Guenter Milde
over the "X" in "What is LyX?". >>> Hope this helps a bit, >> You mean in LyX work area, right? >> I'll have a go on a linux machine. > I just checked and do not see any effect while editing. The issue I saw > was with the EB Garamond font, which

Re: metrics of *(Ly|Te)X* logos

2019-05-09 Thread Jean-Marc Lasgouttes
hine. I just checked and do not see any effect while editing. The issue I saw was with the EB Garamond font, which led to too wide metrics. My patch gets correct metrics with the font I tried. Do you use a specific screen font? JMarc

Re: metrics of *(Ly|Te)X* logos

2019-05-08 Thread Jean-Marc Lasgouttes
Le 08/05/2019 à 22:23, Guenter Milde a écrit : No screenshot, sorry, but some description for doc/Intro.lyx: * no problem, if LyX is the last word in a line "Introduction to LyX", "Philosophy of LyX", ... * author line becomes "by the LyXTeam"[foot] (in the PDF "by the LyX Team") with whi

Re: metrics of *(Ly|Te)X* logos

2019-05-08 Thread Guenter Milde
On 2019-05-08, Jean-Marc Lasgouttes wrote: > Le 08/05/2019 à 19:38, Jean-Marc Lasgouttes a écrit : >> Le 08/05/2019 à 14:58, Guenter Milde a écrit : >>> Dear LyX developers, >>> after recompiling, I see run-together words in the UserGuide (German, >>> Arab, >>> Japanese, ...), more precisely a ne

Re: metrics of *(Ly|Te)X* logos

2019-05-08 Thread Jean-Marc Lasgouttes
Le 08/05/2019 à 19:38, Jean-Marc Lasgouttes a écrit : Le 08/05/2019 à 14:58, Guenter Milde a écrit : Dear LyX developers, after recompiling, I see run-together words in the UserGuide (German, Arab, Japanese, ...), more precisely a negative spacing after the LyX logo. Could this be caused by

Re: metrics of *(Ly|Te)X* logos

2019-05-08 Thread Jean-Marc Lasgouttes
Le 08/05/2019 à 14:58, Guenter Milde a écrit : Dear LyX developers, after recompiling, I see run-together words in the UserGuide (German, Arab, Japanese, ...), more precisely a negative spacing after the LyX logo. Could this be caused by 12fcaf86528ff? Does anyone else see it? Do I have to reco

Re: metrics of *(Ly|Te)X* logos

2019-05-08 Thread jungok
Am Mittwoch, 8. Mai 2019, 12:58:58 CEST schrieb Guenter Milde: > Dear LyX developers, > > after recompiling, I see run-together words in the UserGuide (German, Arab, > Japanese, ...), more precisely a negative spacing after the LyX logo. > > Could this be caused by 12fcaf86528ff? > Does anyone el

metrics of *(Ly|Te)X* logos

2019-05-08 Thread Guenter Milde
Dear LyX developers, after recompiling, I see run-together words in the UserGuide (German, Arab, Japanese, ...), more precisely a negative spacing after the LyX logo. Could this be caused by 12fcaf86528ff? Does anyone else see it? Do I have to reconfigure, clean or something else to fix? Günter

Re: [LyX/master] Compute metrics of *TeX* logos using draw and a null painter

2019-05-07 Thread Jean-Marc Lasgouttes
Le 07/05/2019 à 10:46, Jean-Marc Lasgouttes a écrit : commit 12fcaf86528fff162c6edb81fe36aa9c1dcae38a Author: Jean-Marc Lasgouttes Date: Tue May 7 10:47:49 2019 +0200 Compute metrics of *TeX* logos using draw and a null painter Instead of writing a metrics() method that

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-04-04 Thread Jean-Marc Lasgouttes
Le 04/04/2018 à 16:50, Pavel Sanda a écrit : Jean-Marc Lasgouttes wrote: I pushed it to master. Please try it out and let me know whether it is ready for 2.3.x, especially with small font size. I am working with it. The most striking of small cursor is if you type operator first, e.g. hit minu

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-04-04 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > I pushed it to master. Please try it out and let me know whether it is > ready for 2.3.x, especially with small font size. I am working with it. The most striking of small cursor is if you type operator first, e.g. hit minus ("-") in mathed first and see the cursor s

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-04-04 Thread Jean-Marc Lasgouttes
Le 03/04/2018 à 17:41, Pavel Sanda a écrit : Jean-Marc Lasgouttes wrote: Can you confirm that these go away when preview are disabled? No, I get the assertion even with preview off. I also found recipy to reproduce: 1. open math manual, go to section 3.1 2. enter with cursor the large math inse

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-04-03 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: >>> Can you confirm that these go away when preview are disabled? >> No, I get the assertion even with preview off. >> I also found recipy to reproduce: >> 1. open math manual, go to section 3.1 >> 2. enter with cursor the large math inset showing nested fractions with

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-04-03 Thread Jean-Marc Lasgouttes
1:59 +0100 Subject: [PATCH] Set current cursor font in MathData::metrics() Also make sure that caret dimension in mathed is not larger than inset height. This makes size of the cursor closer to current font in mathed. --- src/BufferView.cpp | 12 ++-- src/mathed/MathData.cpp | 9 ++

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-21 Thread Pavel Sanda
Kornel Benko wrote: > > No, I get the assertion even with preview off. > > > > I also found recipy to reproduce: > > 1. open math manual, go to section 3.1 > > You mean 3.2 here? Yes, sorry. > > 2. enter with cursor the large math inset showing nested fractions with > > cfrac 3. scroll down via

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-21 Thread Kornel Benko
Am Mittwoch, 21. März 2018 13:09:02 CET schrieb Pavel Sanda : > Jean-Marc Lasgouttes wrote: > > Le 20/03/2018 ?? 17:39, Pavel Sanda a écrit : > >> Unf I also am getting assertion when navigating through complex fractions > >> and scrolling with mouse wheel at the same time. > >> Not sure whether yo

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-21 Thread Pavel Sanda
Pavel Sanda wrote: > Jean-Marc Lasgouttes wrote: > > Le 20/03/2018 ?? 17:39, Pavel Sanda a écrit : > >> Unf I also am getting assertion when navigating through complex fractions > >> and scrolling with mouse wheel at the same time. > >> Not sure whether your patch is involved. > > > > Can you confi

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-21 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > Le 20/03/2018 ?? 17:39, Pavel Sanda a écrit : >> Unf I also am getting assertion when navigating through complex fractions >> and scrolling with mouse wheel at the same time. >> Not sure whether your patch is involved. > > Can you confirm that these go away when previe

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-21 Thread Jean-Marc Lasgouttes
Le 20/03/2018 à 17:39, Pavel Sanda a écrit : Unf I also am getting assertion when navigating through complex fractions and scrolling with mouse wheel at the same time. Not sure whether your patch is involved. Can you confirm that these go away when preview are disabled? JMarc

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Jean-Marc Lasgouttes
Le 20 mars 2018 17:49:44 GMT+01:00, Pavel Sanda a écrit : >Pavel Sanda wrote: >> Unf I also am getting assertion when navigating through complex >fractions >> and scrolling with mouse wheel at the same time. >> Not sure whether your patch is involved. > >limited testing indicates it's part of the

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Pavel Sanda
Pavel Sanda wrote: > Unf I also am getting assertion when navigating through complex fractions > and scrolling with mouse wheel at the same time. > Not sure whether your patch is involved. limited testing indicates it's part of the second patch.p

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > Le 20/03/2018 ?? 16:57, Pavel Sanda a écrit : >> This is already huge improvement to the current situation. >> It might still make sense to decrease little bit, I can try >> different patch if you have another variant at hand. > > This, for example. I am not sure how r

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Jean-Marc Lasgouttes
. JMarc From 22841811d75df5aee35691c7709eebfd0b7ea8e7 Mon Sep 17 00:00:00 2001 From: Jean-Marc Lasgouttes Date: Tue, 20 Mar 2018 16:41:59 +0100 Subject: [PATCH] Set current cursor font in MathData::metrics() Also make sure that caret dimension in mathed is not larger than inset height. This makes

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Jean-Marc Lasgouttes
Le 20/03/2018 à 15:37, Scott Kostyshak a écrit : It is probably a good time to have this discussion: do we want the UI element size/thickness to depend from dpi/zoom? My first thought is that it makes sense to zoom. What do other applications do in similar situations? Is the symbol indicating

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > Le 20/03/2018 ?? 16:23, Jean-Marc Lasgouttes a écrit : >> I have the same issue with the cursor. The problem I have for fixing this >> is that the font is not known outside of the metrics or draw calls. It >> could be possible to set Cursor::rea

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Jean-Marc Lasgouttes
Le 20/03/2018 à 16:23, Jean-Marc Lasgouttes a écrit : I have the same issue with the cursor. The problem I have for fixing this is that the font is not known outside of the metrics or draw calls. It could be possible to set Cursor::real_current_font inside some metrics call, though. I'll

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Kornel Benko
Am Montag, 19. März 2018 21:46:05 CET schrieb Scott Kostyshak : > On Mon, Feb 19, 2018 at 05:36:36PM +, Jean-Marc Lasgouttes wrote: > > commit 56e012be83fd4fec1e21d750e961ff936cc8c889 > > Author: Jean-Marc Lasgouttes > > Date: Mon Feb 19 18:24:29 2018 +0100 > >

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Jean-Marc Lasgouttes
r. The problem I have for fixing this is that the font is not known outside of the metrics or draw calls. It could be possible to set Cursor::real_current_font inside some metrics call, though. I'll think about it. JMarc

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Scott Kostyshak
On Tue, Mar 20, 2018 at 11:38:12AM +, Jean-Marc Lasgouttes wrote: > Le 20/03/2018 à 02:46, Scott Kostyshak a écrit : > > Starting with this commit, when I view lib/fonts/test/stmary10.lyx and > > turn preview on, I see several previews marked with red. Attached is a > > screenshot. Is this chan

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Kornel Benko
Am Dienstag, 20. März 2018 13:34:53 CET schrieb Pavel Sanda : > Be my guest and don't touch the rest :) OK. Done. Kornel signature.asc Description: This is a digitally signed message part.

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Pavel Sanda
Kornel Benko wrote: > > > Why can't you use it if it is at other place? > > > Copying would mean, that I had to copy (and commit) every time a change is > > > done. > > > Adding this directory to the tests is a possibility, but complicates even > > > more the tests IMHO. > > > > I do not think you

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Kornel Benko
Am Dienstag, 20. März 2018 12:58:34 CET schrieb Pavel Sanda : > Kornel Benko wrote: > > > > I propose to move it to > > > > > > > > autotests/export/fonts/stmary10.lyx > > > > > > > > instead, and leave a readme in lib/fonts/test showing the new path. > > > > > > No, please don't move it

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > Similarly, I have a work in progress that changes the length and width of > mathed corners depending on zoom. > > It is probably a good time to have this discussion: do we want the UI > element size/thickness to depend from dpi/zoom? This is hard to say until one se

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Pavel Sanda
Kornel Benko wrote: > > > I propose to move it to > > > > > > autotests/export/fonts/stmary10.lyx > > > > > > instead, and leave a readme in lib/fonts/test showing the new path. > > > > No, please don't move it. But feel free to copy it to whatever test you have > > in mind. I'm working on the

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Jean-Marc Lasgouttes
Le 20/03/2018 à 02:46, Scott Kostyshak a écrit : Starting with this commit, when I view lib/fonts/test/stmary10.lyx and turn preview on, I see several previews marked with red. Attached is a screenshot. Is this change expected? Here is the part that causes the issue, if I understand well: +boo

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Kornel Benko
Am Dienstag, 20. März 2018 11:42:18 CET schrieb Pavel Sanda : > Kornel Benko wrote: > > Don't see it after latest commit from Riki. > > > > Apropo, why is this test-file not part of the test suite? > > What do you want to test there? If it compiles of course. > > I propose to move it to > > >

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Pavel Sanda
Kornel Benko wrote: > Don't see it after latest commit from Riki. > > Apropo, why is this test-file not part of the test suite? What do you want to test there? > I propose to move it to > autotests/export/fonts/stmary10.lyx > instead, and leave a readme in lib/fonts/test showing the new pa

Re: [LyX/master] Improve metrics of equations. More work remains to be done.

2018-03-20 Thread Kornel Benko
Am Montag, 19. März 2018 21:46:05 CET schrieb Scott Kostyshak : > On Mon, Feb 19, 2018 at 05:36:36PM +, Jean-Marc Lasgouttes wrote: > > commit 56e012be83fd4fec1e21d750e961ff936cc8c889 > > Author: Jean-Marc Lasgouttes > > Date: Mon Feb 19 18:24:29 2018 +0100 > >

  1   2   3   4   >