Re: [PATCH] new Provide directive for layout files (was: Re: Getting citep etc. to work for egs.cls)

2007-04-03 Thread Martin Vermeer
On Tue, 03 Apr 2007 12:20:39 +0100 José Matos <[EMAIL PROTECTED]> wrote: > On Tuesday 03 April 2007 12:15:22 pm Georg Baum wrote: > > I would say commit it. > > +1 > > > Georg +1 Martin

Re: [PATCH] new Provide directive for layout files (was: Re: Getting citep etc. to work for egs.cls)

2007-04-03 Thread José Matos
On Tuesday 03 April 2007 12:15:22 pm Georg Baum wrote: > I would say commit it. +1 > Georg -- José Abílio

Re: [PATCH] new Provide directive for layout files (was: Re: Getting citep etc. to work for egs.cls)

2007-04-03 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Georg> This is the updated patch with layout2layout support. I needed > Georg> to change one other place as well (compile error due to > Georg> Martin's recent natbib change). > > This is finally the working and tested patch. The only thing missing > is the documenta

[PATCH] new Provide directive for layout files (was: Re: Getting citep etc. to work for egs.cls)

2007-04-03 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> This is the updated patch with layout2layout support. I needed Georg> to change one other place as well (compile error due to Georg> Martin's recent natbib change). This is finally the working and tested patch. The only thing missing

Re: Getting citep etc. to work for egs.cls

2007-04-02 Thread Jean-Marc Lasgouttes
> "Michael" == Michael Gerz <[EMAIL PROTECTED]> writes: >> This is the updated patch with layout2layout support. I needed to >> change one other place as well (compile error due to Martin's >> recent natbib change). >> Michael> While cleaning up my email folder, I stumbled over this Michael

Re: Getting citep etc. to work for egs.cls

2007-04-02 Thread Michael Gerz
Georg Baum schrieb: Am Donnerstag, 22. März 2007 09:41 schrieb Jean-Marc Lasgouttes: OK, here is the still untested second iteration. I introduce a helper isNeeded, which is equivalent to "isRequired && ! provided" (if you have a better name, please tell). With this change, any feature known

Re: Getting citep etc. to work for egs.cls

2007-03-28 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: >> - I did not keep the 0/1 value, because I do not think it is >> useful. Georg> IMHO it is. Otherwise it is not possible to "undefine" such a Georg> feature that comes from a .inc file (this is used in Georg> ijmpc.layout). These uses ar

Re: Getting citep etc. to work for egs.cls

2007-03-27 Thread José Matos
On Tuesday 27 March 2007 2:32:50 pm Georg Baum wrote: > Writing > > match.group(1).lower() > > instead of > > match.group(1) should give you the lowercase version (or maybe > string.lower(match.group(1)), I don't know by heart if the former works). Both work, but as you said the former is prefer

Re: Getting citep etc. to work for egs.cls

2007-03-27 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Georg, the layout2layout code does not work because the wanted syntax is > Provides amsmath > instead of > Provides Amsmath 1 > > There are two problems: > > - I did not keep the 0/1 value, because I do not think it is useful. IMHO it is. Otherwise it is not po

Re: Getting citep etc. to work for egs.cls

2007-03-27 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> This is the updated patch with layout2layout support. I needed Georg> to change one other place as well (compile error due to Georg> Martin's recent natbib change). Georg, the layout2layout code does not work because the wanted syntax

Re: Getting citep etc. to work for egs.cls

2007-03-27 Thread Abdelrazak Younes
Bernhard Roider wrote: Abdelrazak Younes wrote: José Matos wrote: On Saturday 24 March 2007 11:24:17 pm Abdelrazak Younes wrote: I can't believe this is still not applied :-) Could you apply it please? done. Thank you. I just read the log you used and it is from my first mail contain

Re: Getting citep etc. to work for egs.cls

2007-03-26 Thread Bernhard Roider
Abdelrazak Younes wrote: José Matos wrote: On Saturday 24 March 2007 11:24:17 pm Abdelrazak Younes wrote: I can't believe this is still not applied :-) Could you apply it please? done. Thank you. I just read the log you used and it is from my first mail containing this patch. There wa

Re: Getting citep etc. to work for egs.cls

2007-03-26 Thread Abdelrazak Younes
José Matos wrote: On Saturday 24 March 2007 11:24:17 pm Abdelrazak Younes wrote: I can't believe this is still not applied :-) Could you apply it please? done.

Re: Getting citep etc. to work for egs.cls

2007-03-26 Thread Abdelrazak Younes
José Matos wrote: On Saturday 24 March 2007 11:24:17 pm Abdelrazak Younes wrote: I can't believe this is still not applied :-) Could you apply it please? OK (even if I think Bernard should apply it himself). Bernard, I need a log before committing this. Could you please write that for me

Re: Getting citep etc. to work for egs.cls

2007-03-26 Thread José Matos
On Saturday 24 March 2007 11:24:17 pm Abdelrazak Younes wrote: > I can't believe this is still not applied :-) Could you apply it please? > Abdel. -- José Abílio

Re: Getting citep etc. to work for egs.cls

2007-03-26 Thread Abdelrazak Younes
Leuven, E. wrote: Abdel wrote: I think that waiting for the last minute before beta 2 is not a good idea for this one... why not? I mean that we should apply it ASAP, not two minute before beta 2. it fixes a critical bug and would get some testing. (and i haven't experienced any problem

RE: Re: Getting citep etc. to work for egs.cls

2007-03-26 Thread Leuven, E.
Abdel wrote: > I think that waiting for the last minute before beta 2 is > not a good idea for this one... why not? it fixes a critical bug and would get some testing. (and i haven't experienced any problems myself with it...)

Re: Getting citep etc. to work for egs.cls

2007-03-26 Thread Abdelrazak Younes
Edwin Leuven wrote: José Matos wrote: On Monday 19 March 2007 6:02:18 pm Leuven, E. wrote: José Matos wrote: What needs to be done? release 1.5 asap... AS long as critical bugs are fixed I don't have any problem with that. :-) bernhard patch fixes one... shall i apply it? I think tha

Re: Getting citep etc. to work for egs.cls

2007-03-24 Thread Abdelrazak Younes
Edwin Leuven wrote: José Matos wrote: On Monday 19 March 2007 6:02:18 pm Leuven, E. wrote: José Matos wrote: What needs to be done? release 1.5 asap... AS long as critical bugs are fixed I don't have any problem with that. :-) bernhard patch fixes one... shall i apply it? I can't bel

Re: Getting citep etc. to work for egs.cls

2007-03-24 Thread Abdelrazak Younes
Martin Vermeer wrote: On Thu, Mar 01, 2007 at 01:27:17PM +0100, Juergen Spitzmueller wrote: Martin Vermeer wrote: Yes, indeed. Still, the question remains, is this sensible. No. Numerical needs the styles as well, so it should be supported likewise. Jürgen Attached an updated version of th

Re: Getting citep etc. to work for egs.cls

2007-03-24 Thread Georg Baum
Am Donnerstag, 22. März 2007 09:41 schrieb Jean-Marc Lasgouttes: > OK, here is the still untested second iteration. I introduce a helper > isNeeded, which is equivalent to "isRequired && ! provided" (if you > have a better name, please tell). With this change, any feature known > to LyX can be pro

Re: Getting citep etc. to work for egs.cls

2007-03-23 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> OK, here is the still untested second iteration. I introduce a >> helper isNeeded, which is equivalent to "isRequired && ! provided" >> (if you have a better name, please tell). With this change, any >> feature known to LyX can be pr

Re: Getting citep etc. to work for egs.cls

2007-03-22 Thread Martin Vermeer
On Thu, 22 Mar 2007 09:41:07 +0100 Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote: > > "José" == José Matos <[EMAIL PROTECTED]> writes: > > José> On Tuesday 20 March 2007 9:23:56 am Jean-Marc Lasgouttes wrote: > >> One solution would be to define a isNeeded() for this use case, > >> and stil

Re: Getting citep etc. to work for egs.cls

2007-03-22 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > What needs to be done > > - update layout2layout. I need help there pretty please. I can have a look over the weekend. I need to fix a bug in layout2lyaout anyway (conversion from version 1 to 3 does not work). Georg

Re: Getting citep etc. to work for egs.cls

2007-03-22 Thread Jean-Marc Lasgouttes
> "José" == José Matos <[EMAIL PROTECTED]> writes: José> On Tuesday 20 March 2007 9:23:56 am Jean-Marc Lasgouttes wrote: >> One solution would be to define a isNeeded() for this use case, >> and still use isRequired in the few cases where this makes sense. José> The patch seems quite inter

Re: Getting citep etc. to work for egs.cls

2007-03-21 Thread José Matos
On Tuesday 20 March 2007 9:23:56 am Jean-Marc Lasgouttes wrote: > > One solution would be to define a isNeeded() for this use case, and > still use isRequired in the few cases where this makes sense. The patch seems quite interesting indeed. I think that it is not yet ready to beta 2 but I woul

Re: Getting citep etc. to work for egs.cls

2007-03-21 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> I forgot to add that I do not know how std::set works, so my code >> could be bogus (but at least it compiles :). Martin> From what I remember it is valid... Very good. JMarc

Re: Getting citep etc. to work for egs.cls

2007-03-21 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> On Tue, Mar 20, 2007 at 06:48:24PM +0100, Jürgen Spitzmüller Martin> wrote: >> Martin Vermeer wrote: > Which changelog? They haven't been updated >> since somewhere october last > year. >> >> Look twice: http://www.lyx.org/trac/

Re: Getting citep etc. to work for egs.cls

2007-03-20 Thread Martin Vermeer
On Tue, Mar 20, 2007 at 10:24:52AM +0100, Jean-Marc Lasgouttes wrote: > > "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > > > "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > Jean-Marc> The idea is to replace it with a std::set and > Jean-Marc> change LyX

Re: Getting citep etc. to work for egs.cls

2007-03-20 Thread Martin Vermeer
On Tue, Mar 20, 2007 at 06:48:24PM +0100, Jürgen Spitzmüller wrote: > Martin Vermeer wrote: > > Which changelog? They haven't been updated since somewhere october last > > year. > > Look twice: > http://www.lyx.org/trac/changeset/17480 OK, done. Seems I hadn't updated _or_ committed in branch sin

Re: Getting citep etc. to work for egs.cls

2007-03-20 Thread Jürgen Spitzmüller
Martin Vermeer wrote: > Which changelog? They haven't been updated since somewhere october last > year. Look twice: http://www.lyx.org/trac/changeset/17480 Jürgen

Re: Getting citep etc. to work for egs.cls

2007-03-20 Thread Martin Vermeer
On Tue, Mar 20, 2007 at 04:59:44PM +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: ... > Martin> It's committed. Log: > > Thanks. > > You forgot status.14x, didn't you? And changelog too, of course. Oops... status.14x is in now. Which change

Re: Getting citep etc. to work for egs.cls

2007-03-20 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> On Mon, 19 Mar 2007 18:08:48 +0100 Martin> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote: >> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> Martin> Yes indeed, why not ;-/ Getting dumber by the day. >> Martin>

Re: Getting citep etc. to work for egs.cls

2007-03-20 Thread Martin Vermeer
On Mon, 19 Mar 2007 18:08:48 +0100 Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> Yes indeed, why not ;-/ Getting dumber by the day. > > Martin> New attached. > > Very good. If you think it is good enough and working fo

Re: Getting citep etc. to work for egs.cls

2007-03-20 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> The idea is to replace it with a std::set and Jean-Marc> change LyXTextClass::provides() accordingly. The rest is Jean-Marc> purely mechanical (rep

Re: Getting citep etc. to work for egs.cls

2007-03-20 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> The idea is to replace it with a std::set and Jean-Marc> change LyXTextClass::provides() accordingly. The rest is Jean-Marc> purely mechanical (replace enum by string). It could be Jean-Marc> possible to simplify furt

Re: Getting citep etc. to work for egs.cls

2007-03-19 Thread Martin Vermeer
On Mon, Mar 19, 2007 at 11:03:18PM +0100, Jean-Marc Lasgouttes wrote: > > "José" == José Matos <[EMAIL PROTECTED]> writes: > > José> On Monday 19 March 2007 5:08:48 pm Jean-Marc Lasgouttes wrote: > >> Or have ProvidesNatbib and ProvidesNumNatbib (but the two should > >> be exclusive). In the

Re: Getting citep etc. to work for egs.cls

2007-03-19 Thread Edwin Leuven
José Matos wrote: On Monday 19 March 2007 6:02:18 pm Leuven, E. wrote: José Matos wrote: What needs to be done? release 1.5 asap... AS long as critical bugs are fixed I don't have any problem with that. :-) bernhard patch fixes one... shall i apply it?

Re: Getting citep etc. to work for egs.cls

2007-03-19 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Here is the version for 1.4, tried and works as advertised for Martin> me. I will apply this tomorrow if nobody spots a problem. It is OK, but please remove the debug commands in getEngine(). JMarc

Re: Getting citep etc. to work for egs.cls

2007-03-19 Thread Jean-Marc Lasgouttes
> "José" == José Matos <[EMAIL PROTECTED]> writes: José> On Monday 19 March 2007 5:08:48 pm Jean-Marc Lasgouttes wrote: >> Or have ProvidesNatbib and ProvidesNumNatbib (but the two should >> be exclusive). In the future, the idea is to move to something like >> Provides "foo" where "foo" is a

Re: Getting citep etc. to work for egs.cls

2007-03-19 Thread Martin Vermeer
On Mon, Mar 19, 2007 at 06:08:48PM +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> Yes indeed, why not ;-/ Getting dumber by the day. > > Martin> New attached. > > Very good. If you think it is good enough and working for 1.4, you can

Re: Getting citep etc. to work for egs.cls

2007-03-19 Thread Martin Vermeer
On Mon, Mar 19, 2007 at 06:14:25PM +0100, Andre Poenitz wrote: > On Mon, Mar 19, 2007 at 06:42:53PM +0200, Martin Vermeer wrote: > > On Mon, 2007-03-19 at 11:14 +0100, Jean-Marc Lasgouttes wrote: > > > Why not use > > > cite_engine = p.getEngine(); > > > in the code below? > > > > > > + // FI

Re: Getting citep etc. to work for egs.cls

2007-03-19 Thread José Matos
On Monday 19 March 2007 6:02:18 pm Leuven, E. wrote: > José Matos wrote: > > What needs to be done? > > release 1.5 asap... AS long as critical bugs are fixed I don't have any problem with that. :-) -- José Abílio

RE : Getting citep etc. to work for egs.cls

2007-03-19 Thread Leuven, E.
José Matos wrote: > What needs to be done? release 1.5 asap...

Re: Getting citep etc. to work for egs.cls

2007-03-19 Thread José Matos
On Monday 19 March 2007 5:08:48 pm Jean-Marc Lasgouttes wrote: > > Or have ProvidesNatbib and ProvidesNumNatbib (but the two should be > exclusive). In the future, the idea is to move to something like > Provides "foo" > where "foo" is an arbitrary feature. It would have been good to do > that be

Re: Getting citep etc. to work for egs.cls

2007-03-19 Thread Andre Poenitz
On Mon, Mar 19, 2007 at 06:42:53PM +0200, Martin Vermeer wrote: > On Mon, 2007-03-19 at 11:14 +0100, Jean-Marc Lasgouttes wrote: > > Why not use > > cite_engine = p.getEngine(); > > in the code below? > > > > + // FIXME the class should also provide > > + // the numerical/ authoryear cho

Re: Getting citep etc. to work for egs.cls

2007-03-19 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Yes indeed, why not ;-/ Getting dumber by the day. Martin> New attached. Very good. If you think it is good enough and working for 1.4, you can apply it (since having egs working better in 1.4 would be valuable, from what I und

Re: Getting citep etc. to work for egs.cls

2007-03-19 Thread Martin Vermeer
On Mon, 2007-03-19 at 11:14 +0100, Jean-Marc Lasgouttes wrote: > Why not use > cite_engine = p.getEngine(); > in the code below? > > + // FIXME the class should also provide > + // the numerical/ authoryear choce > + if (p.getLyXTextClass().provides(LyXTextClass::natbib) > +

Re: Getting citep etc. to work for egs.cls

2007-03-19 Thread Jean-Marc Lasgouttes
Why not use cite_engine = p.getEngine(); in the code below? + // FIXME the class should also provide + // the numerical/ authoryear choce + if (p.getLyXTextClass().provides(LyXTextClass::natbib) + && p.cite_engine != biblio::ENGINE_NATBIB_NUMERICAL) +

Re: Getting citep etc. to work for egs.cls

2007-03-18 Thread Martin Vermeer
On Thu, Mar 01, 2007 at 01:27:17PM +0100, Juergen Spitzmueller wrote: > Martin Vermeer wrote: > > > Yes, indeed. Still, the question remains, is this sensible. > > No. Numerical needs the styles as well, so it should be supported likewise. > > Jürgen Attached an updated version of this patch, s

Re: Getting citep etc. to work for egs.cls

2007-03-06 Thread Martin Vermeer
On Tue, Mar 06, 2007 at 05:32:15PM +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> It's about which "citation engine" to use. Before the patch, > Martin> it is the one specified in the document's bufferparameters -- > Martin> i.e., stuf

Re: Getting citep etc. to work for egs.cls

2007-03-06 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> It's about which "citation engine" to use. Before the patch, Martin> it is the one specified in the document's bufferparameters -- Martin> i.e., stuff settable from Document Settings, the Bibliography Martin> tab. Manually choosi

Re: Getting citep etc. to work for egs.cls

2007-03-01 Thread Juergen Spitzmueller
Martin Vermeer wrote: > Yes, indeed. Still, the question remains, is this sensible. No. Numerical needs the styles as well, so it should be supported likewise. Jürgen

Re: Getting citep etc. to work for egs.cls

2007-03-01 Thread Martin Vermeer
On Thu, 2007-03-01 at 10:58 +0100, Stephan Witt wrote: > Andre Poenitz wrote: > > On Wed, Feb 28, 2007 at 10:27:18PM +0100, Jean-Marc Lasgouttes wrote: > > > >>>"Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > >> > >>Martin> The attached patches make both these mechanisms respond to th

Re: Getting citep etc. to work for egs.cls

2007-03-01 Thread Stephan Witt
Andre Poenitz wrote: On Wed, Feb 28, 2007 at 10:27:18PM +0100, Jean-Marc Lasgouttes wrote: "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> The attached patches make both these mechanisms respond to the Martin> ProvidesNatbib textclass flag. I am not sure I did this right Martin

Re: Getting citep etc. to work for egs.cls

2007-02-28 Thread Martin Vermeer
On Thu, Mar 01, 2007 at 06:52:11AM +0100, Andre Poenitz wrote: > On Wed, Feb 28, 2007 at 10:27:18PM +0100, Jean-Marc Lasgouttes wrote: > > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > > > Martin> The attached patches make both these mechanisms respond to the > > Martin> Provide

Re: Getting citep etc. to work for egs.cls

2007-02-28 Thread Andre Poenitz
On Wed, Feb 28, 2007 at 10:27:18PM +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> The attached patches make both these mechanisms respond to the > Martin> ProvidesNatbib textclass flag. I am not sure I did this right > Martin> -- I am

Re: Getting citep etc. to work for egs.cls

2007-02-28 Thread Martin Vermeer
On Wed, Feb 28, 2007 at 10:27:18PM +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> The attached patches make both these mechanisms respond to the > Martin> ProvidesNatbib textclass flag. I am not sure I did this right > Martin> -- I am

Re: Getting citep etc. to work for egs.cls

2007-02-28 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> The attached patches make both these mechanisms respond to the Martin> ProvidesNatbib textclass flag. I am not sure I did this right Martin> -- I am especially uncertain about the handling of the numeric Martin> vs. author-year t

Re: Getting citep etc. to work for egs.cls

2007-02-28 Thread Martin Vermeer
On Wed, Feb 28, 2007 at 10:54:02PM +0200, Martin Vermeer wrote: > > I was approached by Manuel de la Torre Juáz from Jet Propulsion Lab with > this problem: it doesn't work, although it ought to. > > Digging produced the following status. > > - There is a mechanism for detecting whether the clas

Getting citep etc. to work for egs.cls

2007-02-28 Thread Martin Vermeer
I was approached by Manuel de la Torre Juáz from Jet Propulsion Lab with this problem: it doesn't work, although it ought to. Digging produced the following status. - There is a mechanism for detecting whether the class file loads by itself natbib. This is the .layout file entry ProvidesNatbib