On Mon, Mar 19, 2007 at 06:14:25PM +0100, Andre Poenitz wrote: > On Mon, Mar 19, 2007 at 06:42:53PM +0200, Martin Vermeer wrote: > > On Mon, 2007-03-19 at 11:14 +0100, Jean-Marc Lasgouttes wrote: > > > Why not use > > > cite_engine = p.getEngine(); > > > in the code below? > > > > > > + // FIXME the class should also provide > > > + // the numerical/ authoryear choce > > > + if (p.getLyXTextClass().provides(LyXTextClass::natbib) > > > + && p.cite_engine != biblio::ENGINE_NATBIB_NUMERICAL) > > > + cite_engine = biblio::ENGINE_NATBIB_AUTHORYEAR; > > > + else > > > + cite_engine = p.cite_engine; > > > > Yes indeed, why not ;-/ Getting dumber by the day. > > > > New attached. > > > > > Also, a "trick" could be to allow the value '2' for providenatbib, or > > > add a new ProvideNumericalNatbib tag. > > > > Or make it a string valued thing: "No", "Numerical", "AuthorYear". More > > legible. Have to sleep on that... > > An enum perhaps? > > Andre', usually hating enums.
That's actually what I thought. A string in the file, converted to an enum on imput (like we have already so many of). However, I think this is not for now. Certainly not for 1.4, where I think a version of the current patch (which I still have to create) should go in ASAP. - Martin
