On Mon, Jul 28, 2014 at 10:19 AM, Jean-Marc Lasgouttes
wrote:
> Le 28/07/2014 15:55, Scott Kostyshak a écrit :
>
>> No it did not. I wasn't sure if it should go in because it does not
>> fix the problem completely. It does fix "most" of the cases, I
>> believe. Should the patch go in and I can ope
Le 28/07/2014 15:55, Scott Kostyshak a écrit :
No it did not. I wasn't sure if it should go in because it does not
fix the problem completely. It does fix "most" of the cases, I
believe. Should the patch go in and I can open a bug report for the
remaining problems? Or, should I do what I describe
if (cmd.action() != LFUN_MOUSE_MOTION)], or we can not
>> worry about these cases and just put the first patch in as it solves
>> most of the empty selection issues.
>
>
> Did this patch eventually go in?
No it did not. I wasn't sure if it should go in because it does not
fi
selection issues.
Did this patch eventually go in?
JMarc
On Tue, Jul 1, 2014 at 5:24 AM, Jean-Marc Lasgouttes wrote:
> 25/06/2014 22:53, Scott Kostyshak:
>
>> It works for most of the issues. Attached is a patch.
>> As for the empty selection issues it doesn't fix, perhaps it's because of
>> the
>> FIXM
25/06/2014 22:53, Scott Kostyshak:
It works for most of the issues. Attached is a patch.
As for the empty selection issues it doesn't fix, perhaps it's because of the
FIXME: let GuiView take care of those.
in GuiWorkArea
The patch looks good. What are the remaining problems?
JMarc
or the empty selection issues it doesn't fix, perhaps it's because of the
FIXME: let GuiView take care of those.
in GuiWorkArea
Scott
From 2d14450542d5ced624eca12071a38fc66708c725 Mon Sep 17 00:00:00 2001
From: Scott Kostyshak
Date: Wed, 25 Jun 2014 16:50:31 -0400
Subject: [PATCH]
23/06/2014 12:40, Scott Kostyshak:
On Fri, Jun 20, 2014 at 10:40 AM, Jean-Marc Lasgouttes
wrote:
18/06/2014 14:49, Scott Kostyshak:
What about having Cursor::selection() return false if selection is empty?
Attached is my attempt to do this. I have no idea what this code does
though. Surpri
On Mon, Jun 23, 2014 at 7:28 AM, Jean-Marc Lasgouttes
wrote:
> 23/06/2014 12:40, Scott Kostyshak:
>
>>> What about having Cursor::selection() return false if selection is empty?
>>
>>
>> Attached is my attempt to do this. I have no idea what this code does
>> though. Surprisingly the attempt seems
23/06/2014 12:40, Scott Kostyshak:
What about having Cursor::selection() return false if selection is empty?
Attached is my attempt to do this. I have no idea what this code does
though. Surprisingly the attempt seems to partially work (although I'm
sure it's still poorly written) if the select
On Fri, Jun 20, 2014 at 10:40 AM, Jean-Marc Lasgouttes
wrote:
> 18/06/2014 14:49, Scott Kostyshak:
> What about having Cursor::selection() return false if selection is empty?
Attached is my attempt to do this. I have no idea what this code does
though. Surprisingly the attempt seems to partially
18/06/2014 14:49, Scott Kostyshak:
Often when using LyX I come across empty selections. The easiest way
to see what I mean by an empty selection is to select one character to
the right, then select one character to the left (this will undo the
first). Such issues are annoying for a few reasons:
18/06/2014 16:38, Richard Heck:
JMarc is the one who knows about selection, so he'll have more to say
than I do. But a
couple quick thoughts. The first is that I don't myself understand when
we should call
selHandle() and when we should call setSelection(). That makes me unsure
whether
the first
On 06/18/2014 08:49 AM, Scott Kostyshak wrote:
Often when using LyX I come across empty selections. The easiest way
to see what I mean by an empty selection is to select one character to
the right, then select one character to the left (this will undo the
first). Such issues are annoying for a fe
move one iota, so no need to update the screen.
cur.screenUpdateFlags(Update::SinglePar | Update::FitCursor);
--
1.8.3.2
From 0d08e55bdef4b6da05cdf7b2e9e6ccc409052177 Mon Sep 17 00:00:00 2001
From: Scott Kostyshak
Date: Sat, 7 Jun 2014 00:42:24 -0400
Subject: [PATCH 4/5] Fix empty selection issu
15 matches
Mail list logo