On Tue, Jul 1, 2014 at 5:24 AM, Jean-Marc Lasgouttes <lasgout...@lyx.org> wrote: > 25/06/2014 22:53, Scott Kostyshak: > >> It works for most of the issues. Attached is a patch. >> As for the empty selection issues it doesn't fix, perhaps it's because of >> the >> FIXME: let GuiView take care of those. >> in GuiWorkArea > > > The patch looks good. What are the remaining problems?
The video below shows three empty selections (with the previous patch applied): https://www.dropbox.com/s/v25ht58nu6lswmr/emptySelections.ogv The first one is when clicking and slightly dragging on a label inset. The second is when clicking and slightly dragging up in a table cell (it can be empty or have text). The third is similar to the first and is when slightly dragging on a reference inset. We could do the same thing as the previous patch but also in GuiWorkarea.cpp after dispatch [if I remember, we would have to do something like if (cmd.action() != LFUN_MOUSE_MOTION)], or we can not worry about these cases and just put the first patch in as it solves most of the empty selection issues. Scott
