Re: Coverity musings

2024-09-26 Thread Jean-Marc Lasgouttes
Le 19/09/2024 à 16:27, Jürgen Spitzmüller a écrit : Am Donnerstag, dem 19.09.2024 um 16:16 +0200 schrieb Jean-Marc Lasgouttes: What I have in mind as a simpler alternative is this (like the last patch, with vector instead of map). Seems to make sense. I have no time to look closer now, unfortu

Re: Coverity musings

2024-09-19 Thread Jürgen Spitzmüller
Am Donnerstag, dem 19.09.2024 um 16:16 +0200 schrieb Jean-Marc Lasgouttes: > What I have in mind as a simpler alternative is this (like the last > patch, with vector instead of map). Seems to make sense. I have no time to look closer now, unfortunately. -- Jürgen -- lyx-devel mailing list lyx-

Re: Coverity musings

2024-09-19 Thread Jean-Marc Lasgouttes
Le 19/09/2024 à 15:40, Jürgen Spitzmüller a écrit : Am Donnerstag, dem 19.09.2024 um 15:14 +0200 schrieb Jean-Marc Lasgouttes: But why go from a vector<> to a map<>? Frankly: I can't remember. What I have in mind as a simpler alternative is this (like the last patch, with vector instead o

Re: Coverity musings

2024-09-19 Thread Jürgen Spitzmüller
Am Donnerstag, dem 19.09.2024 um 15:14 +0200 schrieb Jean-Marc Lasgouttes: > But why go from a vector<> to a map<>? Frankly: I can't remember. -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Coverity musings

2024-09-19 Thread Jean-Marc Lasgouttes
Le 15/09/2024 à 18:14, Jürgen Spitzmüller a écrit : Am Samstag, dem 14.09.2024 um 20:07 +0200 schrieb Jean-Marc Lasgouttes: Back in history, the structure was not a map but a vecor. It is used to track things like "is there a line below this cell?". I am not sure why  Juergen changed it to a map

Re: Coverity musings

2024-09-16 Thread Pavel Sanda
On Sat, Sep 14, 2024 at 08:07:27PM +0200, Jean-Marc Lasgouttes wrote: > So, conveniently, the missing cells will be added and initialized to > "false". Ok, this is what I was expecting. What I was not getting is that is's actually correct to have those elements present in the structure as well, th

Re: Coverity musings

2024-09-15 Thread Jürgen Spitzmüller
Am Samstag, dem 14.09.2024 um 20:07 +0200 schrieb Jean-Marc Lasgouttes: > Back in history, the structure was not a map but a > vecor. It is used to track things like "is there a line below > this cell?". I am not sure why  Juergen changed it to a map To track whether the lines are trimmed (in boo

Re: Coverity musings

2024-09-14 Thread Jean-Marc Lasgouttes
Le 14/09/2024 à 15:40, Pavel Sanda a écrit : Can you explain what that construct works? If I understand correctly we are changing the underlying structure and that does not feel right for "search" procedure. Apart from that if we search extensively the memory will grow as well? First, for the f

Re: Coverity musings

2024-09-14 Thread Jean-Marc Lasgouttes
Le 14/09/2024 à 00:43, Richard Kimberly Heck a écrit : Do you have access to coverity? I think I did, but I do not remember how to access it. The password, etc, is probably saved in Firefox, if you just send me the URL. Have a look here. https://scan.coverity.com/projects/4164 You do have a

Re: Coverity musings

2024-09-14 Thread Pavel Sanda
On Fri, Sep 13, 2024 at 05:54:05PM +0200, Jean-Marc Lasgouttes wrote: > * still lots of places where Coverity wants us to use std::move because the > variable that is copied will not be used any more. I tend to think that we > should avoid that and reduce our use of move() to the minimum, unless >

Re: Coverity musings

2024-09-14 Thread Jürgen Spitzmüller
Am Freitag, dem 13.09.2024 um 17:54 +0200 schrieb Jean-Marc Lasgouttes: > Jürgen, could you please have a look and tell me why we should not do > that? It is too simple, I fear I am missing something. I do not understand if and why that works, but if you say so, I believe you. -- Jürgen -- lyx-

Re: Coverity musings

2024-09-13 Thread Richard Kimberly Heck
On 9/13/24 3:53 PM, Jean-Marc Lasgouttes wrote: Le 13/09/2024 à 20:44, Richard Kimberly Heck a écrit : * Places where I understand the program, but am not sure of a proper fix. * Places where I do not even understand what the issue is :( Happy to have a look at some of those. Do you have

Re: Coverity musings

2024-09-13 Thread Jean-Marc Lasgouttes
Le 13/09/2024 à 20:44, Richard Kimberly Heck a écrit : * Places where I understand the issue, but fixing requires some work and is a bit scary. Example in the patch below: Jürgen, could you please have a look and tell me why we should not do that? It is too simple, I fear I am missing something

Re: Coverity musings

2024-09-13 Thread Richard Kimberly Heck
On 9/13/24 11:54 AM, Jean-Marc Lasgouttes wrote: So what remains now? * still lots of places where Coverity wants us to use std::move because the variable that is copied will not be used any more. I tend to think that we should avoid that and reduce our use of move() to the minimum, unless pr

Coverity musings

2024-09-13 Thread Jean-Marc Lasgouttes
Hi, So I spent some quality time in front of Coverity and here is the result: since the start of this week, the number of outstanding defects is down from 246 to 87. This is in addition to the 75 identical defects that got killed in one fell swoop last week. How was that done? * fixes, ak