Re: [PATCH] Citation Dialog Broken in Trunk

2007-09-13 Thread Andre Poenitz
On Fri, Sep 14, 2007 at 02:08:10AM -0400, Richard Heck wrote: > > This seems to solve the problem. I'll commit if there's no objection. > > By the way, there's a lot of mismatch now between filenames and > classnames. E.g., the class defined in GuiCitation.cpp is > GuiCitationDialog. Which way

[PATCH] Citation Dialog Broken in Trunk

2007-09-13 Thread Richard Heck
This seems to solve the problem. I'll commit if there's no objection. By the way, there's a lot of mismatch now between filenames and classnames. E.g., the class defined in GuiCitation.cpp is GuiCitationDialog. Which way should this be resolved? Richard -- ==

Re: Citation Dialog Broken in Trunk

2007-09-13 Thread Richard Heck
Richard Heck wrote: As said. I have some idea what's wrong here, but it may be a more general problem, so someone else should have a look. Open the citation dialog. Nothing's there! Now hit restore, and it's all there. The problem is that nothing is calling GuiCitationDialog::initialisePa

Citation Dialog Broken in Trunk

2007-09-13 Thread Richard Heck
As said. I have some idea what's wrong here, but it may be a more general problem, so someone else should have a look. Open the citation dialog. Nothing's there! Now hit restore, and it's all there. The problem is that nothing is calling GuiCitationDialog::initialiseParams(). I'm not sure