Re: Attn Rob: BibTeX dialog

2002-10-24 Thread Allan Rae
On Thu, 24 Oct 2002, Rob Lahaye wrote: > Angus Leeming wrote: > >> > >>A click on [Apply] should disable the Restore/OK/Apply and > >>change "Cancel" into "Close"; at least that happens in other > >>dialogs. > >> > >>In the Bibtex dialog, OK and Apply remain enabled. > >> > >>Is that a bug in Dial

Re: Attn Rob: BibTeX dialog

2002-10-24 Thread Rob Lahaye
Angus Leeming wrote: >> >>A click on [Apply] should disable the Restore/OK/Apply and >>change "Cancel" into "Close"; at least that happens in other >>dialogs. >> >>In the Bibtex dialog, OK and Apply remain enabled. >> >>Is that a bug in Dialogs_impl.h ? > > > Indeed. That's NoRepeatedApplyReadOnl

Re: Attn Rob: BibTeX dialog

2002-10-24 Thread Angus Leeming
On Thursday 24 October 2002 3:26 am, Rob Lahaye wrote: > Angus Leeming wrote: > > On Wednesday 23 October 2002 10:08 am, Rob Lahaye wrote: > >>BTW: there are two more issues with the BibTeX dialog. > >>1) I added Restore/OK/Apply/Cancel button group to this > >>dialog. Apply is needed to activate t

Re: Attn Rob: BibTeX dialog

2002-10-23 Thread Rob Lahaye
Angus Leeming wrote: > On Wednesday 23 October 2002 10:08 am, Rob Lahaye wrote: > >>BTW: there are two more issues with the BibTeX dialog. >>1) I added Restore/OK/Apply/Cancel button group to this >>dialog. Apply is needed to activate the input without closing >>the dialog. But the Apply button is

Re: Attn Rob: BibTeX dialog

2002-10-23 Thread Angus Leeming
On Wednesday 23 October 2002 1:37 pm, Rob Lahaye wrote: > Angus Leeming wrote: > >>2001-09-08 Rob Lahaye <[EMAIL PROTECTED]> > >> > >>* FeedbackController.C: separate width as an "int const"; > > > > Seems a little excessive, as it's used only once... > > Fine with me. > Let me make this remark:

Re: Attn Rob: BibTeX dialog

2002-10-23 Thread Rob Lahaye
Angus Leeming wrote: >> >>2001-09-08 Rob Lahaye <[EMAIL PROTECTED]> >> >>* FeedbackController.C: separate width as an "int const"; > > > Seems a little excessive, as it's used only once... Fine with me. Let me make this remark: in the LyX code I have seen so very many cases of "type const var

Re: Attn Rob: BibTeX dialog

2002-10-23 Thread Rob Lahaye
Angus Leeming wrote: > > Compromise, compromise. Most of your changes went in ;-) Yes, I'm more than happy with such compromises. I only wanted to let you know that there was something else than "small-is-beautiful" that inspired me to minimize the size of dialogs. It the "small-is-the-smallest-

Re: Attn Rob: BibTeX dialog

2002-10-23 Thread Angus Leeming
On Wednesday 23 October 2002 12:39 pm, Rob Lahaye wrote: > >>You mean: remove the "false" in the FormAboutlyx.C, and > >> repair the resize/gravity for the browsers? > > > > Yes. Or at least have a go. I couldn't get the browsers to > > resize, which may be an xforms bug or may be my > > incompetan

Re: Attn Rob: BibTeX dialog

2002-10-23 Thread Rob Lahaye
Angus Leeming wrote: > > Incidentally, you can make dialogs smaller if you alter the code. > Try, in FormBase.C/FormBaseDeprecated.C, setting minw_, minh_ > to 0.9 * form()->w, h. There should be some limit because it's > possible to crash xforms otherwise. I may give this a go, but later. >>Yo

Re: Attn Rob: BibTeX dialog

2002-10-23 Thread Angus Leeming
On Wednesday 23 October 2002 11:30 am, Rob Lahaye wrote: > Angus Leeming wrote: > > You can go too far with this small-is-beautiful thing. > > No, it's not a "small-is-beautiful" issue! > My policy was: make dialogs as small as possible, and add the > proper resize/gravity, so that people like you

Re: Attn Rob: BibTeX dialog

2002-10-23 Thread Rob Lahaye
Angus Leeming wrote: > > You can go too far with this small-is-beautiful thing. No, it's not a "small-is-beautiful" issue! My policy was: make dialogs as small as possible, and add the proper resize/gravity, so that people like you still get a nice dialog after resize. I am unhappy with your big

Re: Attn Rob: BibTeX dialog

2002-10-23 Thread Angus Leeming
On Wednesday 23 October 2002 10:08 am, Rob Lahaye wrote: > BTW: there are two more issues with the BibTeX dialog. > 1) I added Restore/OK/Apply/Cancel button group to this > dialog. Apply is needed to activate the input without closing > the dialog. But the Apply button is always inactive. Is that

Re: Attn Rob: BibTeX dialog

2002-10-23 Thread Rob Lahaye
Angus Leeming wrote: > Rob, > > I'm currently looking at the changes you made to the BibTeX dialog. > > Why the freeze/unfreezes? Eg in FormBibtex::input > fl_freeze_form(form()); > fl_set_input(dialog_->input_style, style.c_str()); > fl_unfreeze_form(form()); > > It seems tota

Attn Rob: BibTeX dialog

2002-10-23 Thread Angus Leeming
Rob, I'm currently looking at the changes you made to the BibTeX dialog. Why the freeze/unfreezes? Eg in FormBibtex::input fl_freeze_form(form()); fl_set_input(dialog_->input_style, style.c_str()); fl_unfreeze_form(form()); It seems totally unnessesary, as you're updating