Angus Leeming wrote: > Rob, > > I'm currently looking at the changes you made to the BibTeX dialog. > > Why the freeze/unfreezes? Eg in FormBibtex::input > fl_freeze_form(form()); > fl_set_input(dialog_->input_style, style.c_str()); > fl_unfreeze_form(form()); > > It seems totally unnessesary, as you're updating only one widget...
Ah, wonderful. I almost removed it myself, but I didn't because I had no idea about its meaning. So I left it as it was. Must have been put there by Herbert or someone else who created this code from scratch. Yeap, throw it out, if you're sure it's not needed. BTW: there are two more issues with the BibTeX dialog. 1) I added Restore/OK/Apply/Cancel button group to this dialog. Apply is needed to activate the input without closing the dialog. But the Apply button is always inactive. Is that also at your end? Do you know why that is? (Apply is an "OK", without hiding the dialog, isn't it?) The Restore is (probably) needed for the next point. Read on... 2) A single click in the Styles browser immediately selects that style and shifts it into the style input, instead of having a button to press for the same effect (using buttons for such actions is silly, if you ask me; there are actually too many such silly buttons in the Xforms dialogs!). The restore button helps you to revert this, if needed. However, if the single-click-effect is not wanted, we could implement a "double click" in the "Available styles" browser, to shift the selection into the style input by double mouse clicking. Anything (single or double click) will do, as long as that button for style selection goes away. Regards, Rob.
