Re: Add path to original file to converter script

2009-01-21 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > Juergen, can i apply it to branch too? Yes. Jürgen

Re: Add path to original file to converter script

2009-01-21 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > Pavel Sanda writes: > >> It would be useful, but I think nevertheless that we should try to think > >> about more understandable names. Each function likes to have its own > >> variables, and we have no complete vision of this. > > > > so what is your proposal? > > N

Re: Add path to original file to converter script

2009-01-21 Thread Jean-Marc Lasgouttes
Pavel Sanda writes: >> It would be useful, but I think nevertheless that we should try to think >> about more understandable names. Each function likes to have its own >> variables, and we have no complete vision of this. > > so what is your proposal? Now: apply your patch Later: rewrite everyth

Re: Add path to original file to converter script

2009-01-21 Thread Pavel Sanda
Jean-Marc Lasgouttes wrote: > Pavel Sanda writes: > > i think the intention was that $$p is path of the input file > > not path of the original file. > > > > that said i'm not against adding new $$r variable. opinions? > > It would be useful, but I think nevertheless that we should try to think >

Re: Add path to original file to converter script

2009-01-21 Thread Jean-Marc Lasgouttes
Pavel Sanda writes: > i think the intention was that $$p is path of the input file > not path of the original file. > > that said i'm not against adding new $$r variable. opinions? It would be useful, but I think nevertheless that we should try to think about more understandable names. Each funct

Re: Add path to original file to converter script

2009-01-20 Thread Pavel Sanda
Roland Clobus wrote: > Reading the code: > * infile2 and outfile2 are made relative paths by using the path part of > from_file > * from_base is from_file with no extension. > > > possibly we can use another $$ variable > > $$p for Path to the original file looks ok to me: i think the intention

RE: Add path to original file to converter script

2009-01-19 Thread Roland Clobus
> Roland Clobus wrote: > > > Pavel Sanda wrote: > > > you are right, that there is a bug that $$p is not used. however > this > > > patch > > > looks suspicious from the first sight, as $$i is stuffed from > infile2 > > > while > > > your $$p is stuffed from orig_from. according to the doc $$p shou

Re: Add path to original file to converter script

2009-01-16 Thread Pavel Sanda
Roland Clobus wrote: > > Pavel Sanda wrote: > > you are right, that there is a bug that $$p is not used. however this > > patch > > looks suspicious from the first sight, as $$i is stuffed from infile2 > > while > > your $$p is stuffed from orig_from. according to the doc $$p should > > originate >

RE: Add path to original file to converter script

2009-01-16 Thread Roland Clobus
> > Roland Clobus wrote: > > ... > > In the > > code (Converter.cpp) I found "$$p" which was declared but not in use. > > This patch places the path to the current LyX file in $$p, which can > > be used by the converter to reach the images. > Pavel Sanda wrote: > you are right, that there is a bug

Re: Add path to original file to converter script

2009-01-15 Thread Pavel Sanda
Roland Clobus wrote: > Hello, > > I was looking for a method to modify my LyX file and let LyX parse the > modified file (LyX file -> LyX file with modifications -> PDF). I > noticed that the images would cause problems, because the directory > structure of the images is not copied to the temporar

Add path to original file to converter script

2009-01-15 Thread Roland Clobus
Hello, I was looking for a method to modify my LyX file and let LyX parse the modified file (LyX file -> LyX file with modifications -> PDF). I noticed that the images would cause problems, because the directory structure of the images is not copied to the temporary directory. In the code (Convert