Re: [patch] two fixes

2004-11-13 Thread Andre Poenitz
On Sat, Nov 13, 2004 at 09:20:32PM +0100, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > I think, inheritance is the correct default and all insets unhappy with > > this decision should override it. This also happens to be consistent > > with the explicit font insets in mathed and 'implici

Re: [patch] two fixes

2004-11-13 Thread Alfredo Braunstein
Andre Poenitz wrote: > I think, inheritance is the correct default and all insets unhappy with > this decision should override it. This also happens to be consistent > with the explicit font insets in mathed and 'implicit aspect changers' > like FracInset which reduce the font size. Would a bool

Re: [patch] two fixes

2004-11-12 Thread Andre Poenitz
On Wed, Nov 10, 2004 at 03:36:29PM +0100, Alfredo Braunstein wrote: > > I guess InsetNote and InsetBranch may need that too, but I am not sure. > > So what's the right fix? You seem to understand this much better than I do. I think, inheritance is the correct default and all insets unhappy with t

Re: [patch] two fixes

2004-11-11 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: > I do not know actually. I do not have a good understanding of what > 1.3.x did. > > Setting the default font from the context just before computing > metrics is reasonable, since the fonts contained in a paragraph are > always relative to a base font. Therefore, it d

Re: [patch] two fixes

2004-11-10 Thread Martin Vermeer
On Wed, 2004-11-10 at 17:02, Alfredo Braunstein wrote: > Jean-Marc Lasgouttes wrote: > > > Inheriting is the right thing to do in tabulars, for example. > > > > > > Alfredo> You didn't say that before. > > > > Are you sure? >

Re: [patch] two fixes

2004-11-10 Thread Jean-Marc Lasgouttes
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: Alfredo> Yes, I'm sure. ;-) One thing is "Inheriting is the right Alfredo> thing to do in tabulars, for example." another is "tabulars Alfredo> are the only latex example I can think of now" The fact that I only cited one example w

Re: [patch] two fixes

2004-11-10 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: > Inheriting is the right thing to do in tabulars, for example. > > > Alfredo> You didn't say that before. > > Are you sure? Yes, I'm sure. ;-) One thing is "Inheriting is the right thing to do in

Re: [patch] two fixes

2004-11-10 Thread Jean-Marc Lasgouttes
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: Inheriting is the right thing to do in tabulars, for example. Alfredo> You didn't say that before. Are you sure? >> I guess InsetNote and InsetBranch may need

Re: [patch] two fixes

2004-11-10 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: > Alfredo> The cur.push bit is a bug, not the behaviour of putting the > Alfredo> cursor inside (that I don't particularly like in any case). > Alfredo> The inset is already inside the cursor, this is done in > Alfredo> editXY. Pushing again the inset gives a non-valid

Re: [patch] two fixes

2004-11-10 Thread Jean-Marc Lasgouttes
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: Alfredo> The cur.push bit is a bug, not the behaviour of putting the Alfredo> cursor inside (that I don't particularly like in any case). Alfredo> The inset is already inside the cursor, this is done in Alfredo> editXY. Pushing agai

Re: [patch] two fixes

2004-11-10 Thread Alfredo Braunstein
Jean-Marc Lasgouttes wrote: >> "Alfredo" == Alfredo Braunstein >> <[EMAIL PROTECTED]> writes: > > Alfredo> I've applied these two patches to CoordBranch and the same > Alfredo> could be done for HEAD. > > Alfredo> collap.diff is a bug in insetcollapsable::dispatch, it calls > Alfredo> in

Re: [patch] two fixes

2004-11-10 Thread Jean-Marc Lasgouttes
> "Alfredo" == Alfredo Braunstein <[EMAIL PROTECTED]> writes: Alfredo> I've applied these two patches to CoordBranch and the same Alfredo> could be done for HEAD. Alfredo> collap.diff is a bug in insetcollapsable::dispatch, it calls Alfredo> insetcollapsable::edit on opening but it shouldn't

[patch] two fixes

2004-11-10 Thread Alfredo Braunstein
I've applied these two patches to CoordBranch and the same could be done for HEAD. collap.diff is a bug in insetcollapsable::dispatch, it calls insetcollapsable::edit on opening but it shouldn't (edit has an extraneous cur.push(this)). I don't know if this bug manifests itself in HEAD in some way,

Re: [PATCH] two fixes, broken

2001-12-07 Thread John Levon
On Fri, Dec 07, 2001 at 08:42:11PM +0200, Dekel Tsur wrote: > I've applied the patch with some changed. thank you. > I avoided the crash by not doing an update when the paragraph is inside an > inset. I've already had this problem in BufferView::ChangeInsets. I'm looking at what you did now.

Re: [PATCH] two fixes, broken

2001-12-07 Thread Dekel Tsur
On Tue, Dec 04, 2001 at 01:49:46AM +, John Levon wrote: > > please tell me what I need to fix with the attached. It is supposed to > fix : > > 1) errors should be inserted inside minipages etc., and converted to Standard > 2) all errors should be removed > > The first one works fine, except

Re: [PATCH] two fixes, broken (iterator questions)

2001-12-04 Thread Juergen Vigna
On 04-Dec-2001 John Levon wrote: >> >text->fullRebreak(this); >> Can someone explain to me why a full rebreak is performed after each >> error is removed? >> (The old code did this too... and also when the errors are inserted.) I >> would have thought that could wait until

Re: [PATCH] two fixes, broken (iterator questions)

2001-12-03 Thread John Levon
On Tue, Dec 04, 2001 at 01:07:52PM +1100, Ben Stanley wrote: > > text->redoParagraphs(this, cursor, > > cursor.par()->next()); > > text->fullRebreak(this); > > } > > > Can someone explain to me why a full

Re: [PATCH] two fixes, broken (iterator questions)

2001-12-03 Thread Ben Stanley
Some questions on iterators below... John Levon wrote: >+ if (par->autoDeleteInsets()) { >+ found = true; > text->redoParagraphs(this, cursor, >cursor.par()->next()); > text-

[PATCH] two fixes, broken

2001-12-03 Thread John Levon
please tell me what I need to fix with the attached. It is supposed to fix : 1) errors should be inserted inside minipages etc., and converted to Standard 2) all errors should be removed The first one works fine, except there is a need to do a proper update (as the size changed), and I don't kn