Jean-Marc Lasgouttes wrote:

> Alfredo> The cur.push bit is a bug, not the behaviour of putting the
> Alfredo> cursor inside (that I don't particularly like in any case).
> Alfredo> The inset is already inside the cursor, this is done in
> Alfredo> editXY. Pushing again the inset gives a non-valid cursor,
> Alfredo> with a redundant slice.
> 
> If the behaviour is the same, then your patch is OK.

Yes.
  
>>>  Inheriting is the right thing to do in tabulars, for example.
>>> Where would you suggest to put the code if it is not in metrics()?
> 
> Alfredo> When is inheriting the right thing to do? 1.3.x doesn't
> Alfredo> inherit the font for footnotes, for example.
> 
> As I say, tabulars are the only latex example I can think of now.

You didn't say that before.

> I guess InsetNote and InsetBranch may need that too, but I am not sure.

So what's the right fix? You seem to understand this much better than I do.

Alfredo


Reply via email to