On Fri, Mar 07, 2003 at 04:13:12PM +0100, Alfredo Braunstein wrote:
> Question 1): A Bufferview and some insets have a LyXText. There are a lot of
> LyxText methods that use bv->text->something, instead of plain something,
> to access the outermost LyXText, mainly for checking coordinates. Wouldn'
On Fri, Mar 07, 2003 at 04:13:12PM +0100, Alfredo Braunstein wrote:
> Question 2): Is it possible with current code to embed the outermost LyXText
> in an inset? Or does the outermost LyXText behave substantially different
> than some inner LyXText?
I have been trying to find an answer to that que
Alfredo Braunstein wrote:
> John Levon wrote:
>
>> Tested, applied.
>
> I accidentally slipped in two wrong changes... can someone apply the
> attached patch please?
Applied.
--
Angus
John Levon wrote:
> Tested, applied.
I accidentally slipped in two wrong changes... can someone apply the
attached patch please?
---
Also:
Question 1): A Bufferview and some insets have a LyXText. There are a lot of
LyxText methods that use bv->text->something, instead of plain something,
to ac
John Levon wrote:
> Tested, applied.
>
> thanks
> john
To you.
Alfredo
On Thu, Mar 06, 2003 at 08:20:00PM +0100, Alfredo Braunstein wrote:
> Found it. It seem that top_y(int) got called before the existence of any
> row. Should be ok now.
Tested, applied.
thanks
john
Alfredo Braunstein wrote:
> John Levon wrote:
>
>> No dice, scrolling through the user guide with the scroll bar gave me
>> this :
>>
>
> Damn, will look at it. Sorry.
> Alfredo
Found it. It seem that top_y(int) got called before the existence of any
row. Should be ok now.
Alfredo
Ind
John Levon wrote:
> No dice, scrolling through the user guide with the scroll bar gave me
> this :
>
Damn, will look at it. Sorry.
Alfredo
On Thu, Mar 06, 2003 at 06:44:51PM +0100, Alfredo Braunstein wrote:
> Here it is. Please apply.
> Alfredo
No dice, scrolling through the user guide with the scroll bar gave me
this :
#6 0x081309b6 in LyXText::getRowNearY(int&) const (this=0x0, [EMAIL PROTECTED]) at
lyxrow.h:151
#7 0x0
John Levon wrote:
> I think so, iff you mention *why* they're mutable, so cleanups on this
> can come along.
>
> john
Here it is. Please apply.
Alfredo
Index: BufferView_pimpl.C
===
RCS file: /cvs/lyx/lyx-devel/src/BufferVi
On Thu, Mar 06, 2003 at 06:18:32PM +0100, Alfredo Braunstein wrote:
> (this makes me shudder)
It makes us weep.
> I think it wont be easy. Should I prepare a patch with what I have now (your
> ws correctio + john's)?
I think so, iff you mention *why* they're mutable, so cleanups on this
can co
Lars Gullik Bjønnes wrote:
> Can you check a bit more why removeRow() is constant? Perhaps that
> should just change.
>
I don't know very well, but look:
ab:~/lyx-devel/src$ grep mutable lyxtext.h
mutable int height;
mutable unsigned int width;
mutable LyXFont current_f
Alfredo Braunstein <[EMAIL PROTECTED]> writes:
|
| It works beautifully, and I think it's clean and the right way this time.
|
| I would apply it. ;)
The only nitpick I have: can you make sure that there are two empty
lines between functions?
--
Lgb
On Thu, Mar 06, 2003 at 05:30:47PM +0100, Alfredo Braunstein wrote:
> It works beautifully, and I think it's clean and the right way this time.
Looks good to me, except please mention the units of the offset in the
comment (that is "pixel offset" not "offset")
regards
john
Alfredo Braunstein <[EMAIL PROTECTED]> writes:
| Ok, I've reworked the patch in the Row* version. That's is:
|
| private:
| mutable Row * top_row;
| mutable int top_row_offset_;
| public:
| int top_y() const
| void top_y(int newy);
|
| I've needed to put them muta
Ok, I've reworked the patch in the Row* version. That's is:
private:
mutable Row * top_row;
mutable int top_row_offset_;
public:
int top_y() const
void top_y(int newy);
I've needed to put them mutable because removeRow() is declared constant
(why?). Now in RemoveRo
16 matches
Mail list logo
