On Thu, Feb 18, 2010 at 12:08:37AM +0800, John McCabe-Dansted wrote:
> On Sun, Feb 14, 2010 at 11:27 PM, John McCabe-Dansted
> wrote:
> > http://gmatht.homelinux.net/xp/lyx/cppcheck/
>
> Attached is a possible fix for:
>
> [./src/support/os_cygwin.cpp:181]: (error) Mismatching allocation and
>
On Sun, Feb 14, 2010 at 11:27 PM, John McCabe-Dansted wrote:
> http://gmatht.homelinux.net/xp/lyx/cppcheck/
Attached is a possible fix for:
[./src/support/os_cygwin.cpp:181]: (error) Mismatching allocation and
deallocation: ptr
Does it look right?
--
John C. McCabe-Dansted
Index: lyx/src/su
On Mon, Feb 15, 2010 at 2:49 PM, Pavel Sanda wrote:
> John McCabe-Dansted wrote:
>> Well, Jürgen also prefers ++i to i++, at least in new code being
>> submitted to LyX.
>
> we have such advice in lyx coding rules, thats true and i understand its usage
> for non-POD objects, anyway using it in in
John McCabe-Dansted wrote:
> Well, Jürgen also prefers ++i to i++, at least in new code being
> submitted to LyX.
we have such advice in lyx coding rules, thats true and i understand its usage
for non-POD objects, anyway using it in int loops somewhat catches the eyes. no
to speak that i had to t
On Mon, Feb 15, 2010 at 11:54 AM, Pavel Sanda wrote:
> i fail to see why
> for (int i = 0; i < count; i++)
> is better than
> for (int i = 0; i < count; ++i)
Well, Jürgen also prefers ++i to i++, at least in new code being
submitted to LyX. Whether it is worth patching old code is another
issue
John McCabe-Dansted wrote:
> I ran cppcheck on the LyX codebase. I got a number of style warnings
> about ++i being better than i++. The attached patch fixes these
> warnings, the patch was generated by the attached
> post2pre_increment.sh.
i fail to see why
for (int i = 0; i < count; i++)
is bett
I ran cppcheck on the LyX codebase. I got a number of style warnings
about ++i being better than i++. The attached patch fixes these
warnings, the patch was generated by the attached
post2pre_increment.sh.
The following two bugs are fixed in leak_brace.patch (attached)
[./development/lyxserver/ser
On Sunday 29 November 2009 12:23:13 Jürgen Spitzmüller wrote:
> The attached patch for trunk adds the ability to view the BibTeX and
> makeindex logs, if available, in the Log dialog.
>
> I'll commit if there are no objetions.
Go ahead.
> Jürgen
--
José Abílio
The attached patch for trunk adds the ability to view the BibTeX and makeindex
logs, if available, in the Log dialog.
I'll commit if there are no objetions.
Jürgen
Index: src/frontends/qt4/GuiLog.cpp
===
--- src/frontends/qt4/GuiLog
On Thu, Aug 16, 2007 at 03:57:40PM +0200, Abdelrazak Younes wrote:
> Jean-Marc Lasgouttes wrote:
> >Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
> >
> >>The following patch introduces LabelString for counters. This
> >>labelstring will be used in several places:
> >
> >Here is the updated versi
On Thu, Aug 16, 2007 at 06:09:47PM +0200, Edwin Leuven wrote:
> >> O tempora, o mores...
> >
> > Not everybody understand Latin either ;-)
>
> i think tempora is a japanese dish...
>
> so it must mean something like
>
> "oh, how i love deep fried battered veggies"
>
> or something like that..
O tempora, o mores...
Not everybody understand Latin either ;-)
i think tempora is a japanese dish...
so it must mean something like
"oh, how i love deep fried battered veggies"
or something like that...
;-)
Enrico Forestieri wrote:
On Thu, Aug 16, 2007 at 05:18:12PM +0200, Abdelrazak Younes wrote:
Jean-Marc Lasgouttes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
(Counters::theCounter): return a representation of a given
counter using its labelstring
I'd write Counters::
On Thu, Aug 16, 2007 at 05:18:12PM +0200, Abdelrazak Younes wrote:
> Jean-Marc Lasgouttes wrote:
> > Abdelrazak Younes <[EMAIL PROTECTED]> writes:
> >
> >>(Counters::theCounter): return a representation of a given
> >>counter using its labelstring
> >>
> >> I'd write Counters::get() for t
Jean-Marc Lasgouttes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Isn't new a reserved word?
Indeed. What about newItem()?
In general I think that members should have explicit naming (I know
this is not your doing).
Rather than doing that, I think I'd prefer to expose a map-like
Jean-Marc Lasgouttes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
(Counters::theCounter): return a representation of a given
counter using its labelstring
I'd write Counters::get() for the same reason as above.
It is now what the method does really. It is an equivalen
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
> (Counters::theCounter): return a representation of a given
> counter using its labelstring
>
> I'd write Counters::get() for the same reason as above.
It is now what the method does really. It is an equivalent to LaTeX's
\thefigure, for
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
> Some cosmetic comments on the code (all IMHO):
>
> @@ -922,14 +928,31 @@ void TextClass::readCounter(Lexer & lexr
> switch (static_cast(le)) {
> case CT_NAME:
> lexrc.next();
> - n
Jean-Marc Lasgouttes wrote:
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
The following patch introduces LabelString for counters. This
labelstring will be used in several places:
Here is the updated version of the patch, the shortcoming have been
resolved and the layout files have been up
Jean-Marc Lasgouttes wrote:
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
The following patch introduces LabelString for counters. This
labelstring will be used in several places:
Here is the updated version of the patch, the shortcoming have been
resolved and the layout files have been up
Martin Vermeer <[EMAIL PROTECTED]> writes:
> And I seem to remember that in some classes, symbols are used
> like dagger, ddagger etc. Can the system (be made to) handle
> that?
I am not sure how to do that. Currently I have just removed the
numbering in the cases where we output \thanks instead
On Thu, Aug 16, 2007 at 10:40:53AM +0200, Jean-Marc Lasgouttes wrote:
> Richard Heck <[EMAIL PROTECTED]> writes:
>
> > Haven't studied it, and haven't worked with it, but I've seen the
> > counters, and they are excellent. It'll make finding footnote 22 a
> > breeze, whereas it used to be a hassle
Enrico Forestieri <[EMAIL PROTECTED]> writes:
> On Thu, Aug 16, 2007 at 03:47:28AM -0400, Richard Heck wrote:
>
>> Haven't studied it, and haven't worked with it, but I've seen the counters,
>> and they are excellent. It'll make finding footnote 22 a breeze, whereas it
>> used to be a hassle.
>
Richard Heck <[EMAIL PROTECTED]> writes:
> Haven't studied it, and haven't worked with it, but I've seen the
> counters, and they are excellent. It'll make finding footnote 22 a
> breeze, whereas it used to be a hassle.
We will have to work on the document classes to make sure that they
represent
On Thu, Aug 16, 2007 at 03:47:28AM -0400, Richard Heck wrote:
> Haven't studied it, and haven't worked with it, but I've seen the counters,
> and they are excellent. It'll make finding footnote 22 a breeze, whereas it
> used to be a hassle.
Never used reverse dvi search?
--
Enrico
Jean-Marc Lasgouttes wrote:
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
The following patch introduces LabelString for counters. This
labelstring will be used in several places:
Here is the updated version of the patch, the
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
>
>> The following patch introduces LabelString for counters. This
>> labelstring will be used in several places:
>
> Here is the updated version of the patch, the shortcoming have been
> resolved a
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
> The following patch introduces LabelString for counters. This
> labelstring will be used in several places:
Here is the updated version of the patch, the shortcoming have been
resolved and the layout files have been updated. For example floats
an
Edwin Leuven <[EMAIL PROTECTED]> writes:
> Jean-Marc Lasgouttes wrote:
>> Yes, it would be easy. But I am not sure how to display that when
>> there is a label.
>
> (# - label)
> or something like that...
I'll have to try. It may also be too large on screen.
And it will not with previews witho
Jean-Marc Lasgouttes wrote:
Yes, it would be easy. But I am not sure how to display that when
there is a label.
(# - label)
or something like that...
Edwin Leuven <[EMAIL PROTECTED]> writes:
> Jean-Marc Lasgouttes wrote:
>> What is missing? Not much.
>
> does this mean that we will also get numbered formulas?
Yes, it would be easy. But I am not sure how to display that when
there is a label.
JMarc
Jean-Marc Lasgouttes wrote:
What is missing? Not much.
does this mean that we will also get numbered formulas?
The following patch introduces LabelString for counters. This
labelstring will be used in several places:
- everytime a layout LabelString contains \thesomething, the
labelString of counter something is used (currently no layout uses
that)
- InsetCaption also uses this for numbering. As an
> "younes" == younes a <[EMAIL PROTECTED]> writes:
younes> Quoting Richard Heck <[EMAIL PROTECTED]>:
>> Abdelrazak Younes wrote: >> what about a similar design for the
>> file format and copier sections? > Yes but I don't have much time
>> to work on that (I did the Converters > one because I
Quoting Richard Heck <[EMAIL PROTECTED]>:
> Abdelrazak Younes wrote:
> >> what about a similar design for the file format and copier sections?
> > Yes but I don't have much time to work on that (I did the Converters
> > one because I wanted some spaces for the converter cache options).
> I did the
Abdelrazak Younes wrote:
what about a similar design for the file format and copier sections?
Yes but I don't have much time to work on that (I did the Converters
one because I wanted some spaces for the converter cache options).
I did these tonight while watching a baseball game on TV: File for
This patch completes my recent locale work. It ensures that the char
versions of lowercase/uppercase are only used for ASCII characters, since
they are locale dependant. Ideally, we would not implement them at all, but
if we do that the char_type versions would be used instead, so it is better
to i
Enrico Forestieri wrote:
On Tue, Oct 17, 2006 at 05:59:55PM +0200, Enrico Forestieri wrote:
On Tue, Oct 17, 2006 at 03:55:22PM +0200, Abdelrazak Younes wrote:
This patch includes the one I send earlier with the MathSupport changes.
I converted most occurrence of implicit conversion using:
On Tue, Oct 17, 2006 at 05:59:55PM +0200, Enrico Forestieri wrote:
> On Tue, Oct 17, 2006 at 03:55:22PM +0200, Abdelrazak Younes wrote:
>
> > This patch includes the one I send earlier with the MathSupport changes.
> > I converted most occurrence of implicit conversion using:
> >
> > docstrin
On Tue, Oct 17, 2006 at 03:55:22PM +0200, Abdelrazak Younes wrote:
> This patch includes the one I send earlier with the MathSupport changes.
> I converted most occurrence of implicit conversion using:
>
> docstring dstr(str.begin(), str.end())
Abdel, this is not correct, because on systems w
This patch includes the one I send earlier with the MathSupport changes.
I converted most occurrence of implicit conversion using:
docstring dstr(str.begin(), str.end())
as suggested by Georg.
Will commit soon.
Abdel.
Index: src/cursor.C
==
Georg Baum wrote:
Abdelrazak Younes wrote:
Here is an updated patch for qt3 and gtk. Shall I commit that or is
anybody interested in taking ownership and making sure it compiles?
Please commit (and remove the FIXMEs). It is easier to go from a half
working solution.
OK, done.
Abdel.
Abdelrazak Younes wrote:
> Here is an updated patch for qt3 and gtk. Shall I commit that or is
> anybody interested in taking ownership and making sure it compiles?
Please commit (and remove the FIXMEs). It is easier to go from a half
working solution.
Georg
Abdelrazak Younes wrote:
Hello,
Please find attached two patches. I intent to apply the first patch and
let some volunteer (if any) continue the work on patch 2 for qt3 and gtk.
Here is an updated patch for qt3 and gtk. Shall I commit that or is
anybody interested in taking ownership and m
Hello,
Please find attached two patches. I intent to apply the first patch and
let some volunteer (if any) continue the work on patch 2 for qt3 and gtk.
Abdel.
Patch 1 Log:
* controllers/Dialog.[Ch]
- View::title_ is now a docstring (ctor and access functions changed)
* controllers/Cont
http://bugzilla.lyx.org/show_bug.cgi?id=2779
This patch fixes button2 use in maths. It is now able to paste current
in-lyx selection when it is present.
Please test.
JMarc
Index: src/mathed/math_nestinset.C
===
--- src/mathed/math
Michael Gerz <[EMAIL PROTECTED]> writes:
| Andre Poenitz wrote:
|
| >On Mon, Jul 10, 2006 at 09:39:39PM +0200, Michael Gerz wrote:
| >
| >>Subject says it all.
| >>
| >>Michael
| >>
| >>Index: SConstruct
| >>===
| >>--- SConstruct (
Andre Poenitz wrote:
On Mon, Jul 10, 2006 at 09:39:39PM +0200, Michael Gerz wrote:
Subject says it all.
Michael
Index: SConstruct
===
--- SConstruct (Revision 14416)
+++ SConstruct (Arbeitskopie)
@@ -122,7 +122,7 @@
opts.Add
> -allowed_values = ('xform', 'qt2', 'qt3', 'qt4', 'gtk') ),
> +allowed_values = ('qt2', 'qt3', 'qt4', 'gtk') ),
qt2 looks odd.
Unless you want to rename src/frontends/qt2 in the 1.4.x branch to
qt3. The existence of that directory, by the way, is a signature for
scons to tell 1
On Tuesday 11 July 2006 18:22, Andre Poenitz wrote:
> qt2 looks odd.
And it is wrong for 1.5.x, I only support qt3+ there.
> Andre'
--
José Abílio
On Mon, Jul 10, 2006 at 09:39:39PM +0200, Michael Gerz wrote:
> Subject says it all.
>
> Michael
>
> Index: SConstruct
> ===
> --- SConstruct (Revision 14416)
> +++ SConstruct (Arbeitskopie)
> @@ -122,7 +122,7 @@
> opts.AddOptions(
Subject says it all.
Michael
Index: SConstruct
===
--- SConstruct (Revision 14416)
+++ SConstruct (Arbeitskopie)
@@ -122,7 +122,7 @@
opts.AddOptions(
# frontend
EnumOption('frontend', 'Main GUI', default_frontend,
-
Hi,
I also missed these places.
Michael
Index: src/Makefile.am
===
--- src/Makefile.am (Revision 14401)
+++ src/Makefile.am (Arbeitskopie)
@@ -31,11 +31,11 @@
bin_PROGRAMS = lyx
noinst_PROGRAMS = $(FRONTENDS_PROGS)
-EXTRA_
Am Dienstag, den 07.02.2006, 21:58 + schrieb John Spray:
> Attached patch continues work on GTK preferences dialog.
Oops, that patch contained some random extraneous stuff outside of
frontends/gtk, please ignore that, only gtk stuff was committed.
John
Hi,
Attached patch continues work on GTK preferences dialog.
It uses Gtk::FileChooserButton, which means that gtkmm-2.4 version >=
2.6.0 is now a non-negotiable dependency.
John
? newfile1.pdf
? newfile1.ps
? out
? frontends/gnome/.deps
? frontends/gnome/Makefile
? frontends/gnome/Makefile.in
?
On Wed, May 18, 2005 at 11:38:38PM +0200, Michael Schmitt wrote:
> some more text message changes. This patch (almost) finishes my cleanup.
This is fine
john
Michael Schmitt wrote:
> Anybody out there willing and able to apply the patch? I like clean
> working copies :-)
Done.
Georg
Jean-Marc Lasgouttes wrote:
Michael> Hello, some more text message changes. This patch (almost)
Michael> finishes my cleanup.
Michael> Please check and apply.
This looks good to me.
Anybody out there willing and able to apply the patch? I like clean
working copies :-)
Michael
> "Michael" == Michael Schmitt <[EMAIL PROTECTED]> writes:
Michael> Hello, some more text message changes. This patch (almost)
Michael> finishes my cleanup.
Michael> Please check and apply.
This looks good to me.
JMarc
Hello,
some more text message changes. This patch (almost) finishes my cleanup.
Please check and apply.
Michael
Index: BufferView.C
===
RCS file: /cvs/lyx/lyx-devel/src/BufferView.C,v
retrieving revision 1.260
diff -u -p -r1.260 Buffer
Martin Vermeer wrote:
> On Sun, Mar 20, 2005 at 01:02:43PM +, John Spray wrote:
>> On Sun, 2005-03-20 at 12:42 +, Angus Leeming wrote:
>> > Add an extra 'const':
>> > char const * const encodings[] = ...
>> Done. Someone might want to do the same for QDocument.C, since that's
>> where I r
On Sun, Mar 20, 2005 at 01:15:46PM +, John Spray wrote:
> On Sun, 2005-03-20 at 15:10 +0200, Martin Vermeer wrote:
> >
> > Hmmm... is there a way to _include_ things like this between frontends,
> > rather than _copy_ them?
>
> In this particular case, the list is slightly different between
>
On Sun, 2005-03-20 at 15:10 +0200, Martin Vermeer wrote:
> On Sun, Mar 20, 2005 at 01:02:43PM +, John Spray wrote:
> > On Sun, 2005-03-20 at 12:42 +, Angus Leeming wrote:
> > > Add an extra 'const':
> > > char const * const encodings[] = ...
> > Done. Someone might want to do the same for
On Sun, Mar 20, 2005 at 01:02:43PM +, John Spray wrote:
> On Sun, 2005-03-20 at 12:42 +, Angus Leeming wrote:
> > Add an extra 'const':
> > char const * const encodings[] = ...
> Done. Someone might want to do the same for QDocument.C, since that's
> where I ripped it from (I can only comm
On Sun, 2005-03-20 at 12:42 +, Angus Leeming wrote:
> Add an extra 'const':
> char const * const encodings[] = ...
Done. Someone might want to do the same for QDocument.C, since that's
where I ripped it from (I can only commit to gtk directory).
> Hmmm
> // Be a cheesy bastard, fo
John Spray wrote:
>
> I've now done Page, Margin, and Language tabs of the gtk document
> dialog: attached.
>
> John
Looks good. Minor nits:
Add an extra 'const':
char const * const encodings[] = ...
Hmmm
// Be a cheesy bastard, for the moment
bc().valid();
I thought the lett
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
| This patch adds configure switches for:
| - precompiled headers
| - concept checks
| - libstdc++ debug mode
This is the updated patch that I am going to commit.
? Config
? config-1.diff
? cppflags-1.diff
? cppflags-2.diff
? enable-
Lars Gullik Bjønnes wrote:
> | Lars Gullik Bjønnes wrote:
>>> what you also can try is to ask make why it thinks rebuilding
>>> pch.h.gch is necessary.
>>>
>>> make -d pch.h.gch
>>>
>>> (will give a lot of output, interesting stuff at end I think)
>>
> | Lars, could you run this for me please. He
Angus Leeming <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
>> what you also can try is to ask make why it thinks rebuilding
>> pch.h.gch is necessary.
>>
>> make -d pch.h.gch
>>
>> (will give a lot of output, interesting stuff at end I think)
>
| Lars, could you run this for me pleas
Lars Gullik Bjønnes wrote:
> what you also can try is to ask make why it thinks rebuilding
> pch.h.gch is necessary.
>
> make -d pch.h.gch
>
> (will give a lot of output, interesting stuff at end I think)
Lars, could you run this for me please. Here's what I get:
$ cd build/make
$ make -d pch.h
Angus Leeming <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
>> | Ok, Lars, here's the output of
>> | $ make > make.log 2>&1
>>>
>> | Note all those unnecessary compilations of the precompiled headers.
>> | Note also that the executables were not linked, so somehow make knows
>> | that t
Lars Gullik Bjønnes wrote:
> | Ok, Lars, here's the output of
> | $ make > make.log 2>&1
>>
> | Note all those unnecessary compilations of the precompiled headers.
> | Note also that the executables were not linked, so somehow make knows
> | that these steps were unnecessary.
>
> "all those" I see
Angus Leeming <[EMAIL PROTECTED]> writes:
| Ok, Lars, here's the output of
| $ make > make.log 2>&1
>
| Note all those unnecessary compilations of the precompiled headers. Note
| also that the executables were not linked, so somehow make knows that
| these steps were unnecessary.
"all those" I se
Angus Leeming wrote:
>> | On the subject of precompiled headers, can you stop them being
>> | compiled unnecessarily? Every time I run make...
>>
>> That is not the case here. I have no idea why pch.h.gch is regenerated
>> on your box.
>>
>> So: better bug report please
>
> I'll investigate furt
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
>> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
>
| Lars> a check on host-triplet? Will be a followup patch. (and what is
| Lars> the host triplet for darwin?)
>
| It seems to be powerpc-apple-darwin.
Ok. Later.
| I am not sure an
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
| Why not make them default to yes for gcc 3.4+ ?
Lars> But I did! Why do you say otherwise?
To annoy you? Naaa...
OK, false positive.
| It would be a good time to disable them with gcc3.3/darwin
Lars> a check on host-triplet? Wi
Angus Leeming <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
>
>> What about "--enable-stdlib-debug"
>> I don't like to have "++" in the string...
>
| The concept checks are a feature of GNU's implementation of the standard
| C++ library. Why not "--enable-gnucxx-debug" ?
Other standar
Lars Gullik Bjønnes wrote:
> What about "--enable-stdlib-debug"
> I don't like to have "++" in the string...
The concept checks are a feature of GNU's implementation of the standard
C++ library. Why not "--enable-gnucxx-debug" ?
--
Angus
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
>> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
>
| Lars> This patch adds configure switches for:
>
| Lars> - precompiled headers
>
| Why not make them default to yes for gcc 3.4+ ?
But I did!
Why do you say otherwise?
>
| Lars>
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
Lars> This patch adds configure switches for:
Lars> - precompiled headers
Why not make them default to yes for gcc 3.4+ ?
Lars> - concept checks
It would be a good time to disable them with gcc3.3/darwin
Lars> - libstdc++ debu
Lars Gullik Bjønnes wrote:
> | On the subject of precompiled headers, can you stop them being compiled
> | unnecessarily? Every time I run make...
>
> That is not the case here. I have no idea why pch.h.gch is regenerated
> on your box.
>
> So: better bug report please
I'll investigate further t
Angus Leeming <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
>
>> This patch adds configure switches for:
>> - precompiled headers
>> - concept checks
>> - libstdc++ debug mode
>>
>> I'll commit this later today.
>
| On the subject of precompiled headers, can you stop the
Lars Gullik Bjønnes wrote:
> This patch adds configure switches for:
> - precompiled headers
> - concept checks
> - libstdc++ debug mode
>
> I'll commit this later today.
On the subject of precompiled headers, can you stop them being compiled
unnecessarily? Every time I run make..
This patch adds configure switches for:
- precompiled headers
- concept checks
- libstdc++ debug mode
I'll commit this later today.
Index: config/lyxinclude.m4
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/config/lyx
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
Lars> This patch is good. Just apply it.
Done.
JMarc
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
| Index: Makefile.am
| ===
| RCS file: /usr/local/lyx/cvsroot/lyx-devel/Makefile.am,v
| retrieving revision 1.48
| diff -u -p -r1.48 Makefile.am
| --- Makefile.am 9 Jun 2004 13:14
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes:
Lars> It would be nice if people could check that this works with
Lars> automake older than 1.8.3 and 1.7.8. I have tested those with
Lars> distcheck. (Or do we now require automake > 1.7?) (what version
Lars> of automake is in RH9?)
On Wed, Jun 09, 2004 at 01:38:33AM +0200, Lars Gullik Bj?nnes wrote:
> Ok, thanks. You didn't try the patch did you?
ah, you know me so well
john
John Levon <[EMAIL PROTECTED]> writes:
| On Tue, Jun 08, 2004 at 07:42:08PM +0200, Lars Gullik Bj?nnes wrote:
>
>> (Or do we now require automake > 1.7?) (what version of automake is in
>> RH9?)
>
| 1.6.3
Ok, thanks. You didn't try the patch did you?
--
Lgb
On Tue, Jun 08, 2004 at 07:42:08PM +0200, Lars Gullik Bj?nnes wrote:
> (Or do we now require automake > 1.7?) (what version of automake is in
> RH9?)
1.6.3
john
It would be nice if people could check that this works with automake
older than 1.8.3 and 1.7.8. I have tested those with distcheck.
(Or do we now require automake > 1.7?) (what version of automake is in
RH9?)
Index: Makefile.am
===
Andre Poenitz wrote:
>> Please note that the end iterator now is DocumentIterator(inset) or
>> DocumentIteratorEnd(inset), which was the begin() iterator before.
>
> Is there any place where we actually need the end() iterator +
> operator--() combo? The user code is not simpler after your change
On Mon, Mar 29, 2004 at 01:10:58PM +0200, Alfredo Braunstein wrote:
> this patch
>
> 1) makes DocumentIterator (btw, too long name)
Change it to 'DocIterator' then. Would be consitent with the file name,
too.
> store an inset * member. With this we can come back from the
> past-the-last positio
Alfredo Braunstein wrote:
>> It looks *much* more readable to my novice eyes. Although I'm used
>> to lower case when it comes to iterators.
>
> Updated patch in lowercase.
Doesn't it look just beautiful?
;-)
--
Angus
Angus Leeming wrote:
> It looks *much* more readable to my novice eyes. Although I'm used to
> lower case when it comes to iterators.
Updated patch in lowercase.
Alfredo
? DviOut-1.4.0.lyx
? Markers.C
? Markers.h
? PosIterator.C-bold
? PosIterator.h-bold
? lyxrow_funcs.C-bad1
? paragraph.C-bad1
Angus Leeming wrote:
Thanks for the answer!
> It looks *much* more readable to my novice eyes. Although I'm used to
> lower case when it comes to iterators.
>
> const_par_iterator it = par_iterator_begin();
> const_par_iterator const end = par_iterator_end();
should be solvable
Alfredo Braunstein wrote:
> this patch
>
> 1) makes DocumentIterator (btw, too long name) store an inset *
> member. With this we can come back from the past-the-last position
> (and go forward from the one-before-start one, which is the same
> one)
>
> I've introduced then stale functions
> Doc
this patch
1) makes DocumentIterator (btw, too long name) store an inset * member. With
this we can come back from the past-the-last position (and go forward from
the one-before-start one, which is the same one)
I've introduced then stale functions DocumentIterator{Begin,End}(InsetBase
&) that r
On Mon, Feb 16, 2004 at 02:05:54PM +0100, Alfredo Braunstein wrote:
> Switch to absolute coordinates in LyXText::setCursorFromCoords
>
> actually cures a bit of problems as we assumed that this was done already in
> some places.
This certainly looks good.
Andre'
Switch to absolute coordinates in LyXText::setCursorFromCoords
actually cures a bit of problems as we assumed that this was done already in
some places.
Alfredo
? ChangeLog-old
? PosIterator.C-save
? PosIterator.h-save
? bfri.C
? textcursor.C-save
? textcursor.h-save
? insets/insetcollapsable-sav
1 - 100 of 438 matches
Mail list logo
