On Mon, Mar 29, 2004 at 01:10:58PM +0200, Alfredo Braunstein wrote:
> this patch 
> 
> 1) makes DocumentIterator (btw, too long name)

Change it to 'DocIterator' then. Would be consitent with the file name,
too.

> store an inset * member. With this we can come back from the
> past-the-last position (and go forward from the one-before-start one,
> which is the same one)

Ok.
 
> I've introduced then stale functions DocumentIterator{Begin,End}(InsetBase
> &) that return iterators.

WrongNaming for a function.

> Please note that the end iterator now is DocumentIterator(inset) or
> DocumentIteratorEnd(inset), which was the begin() iterator before.

Is there any place where we actually need the end() iterator +
operator--() combo? The user code is not simpler after your changes...

[But I don't care too much, if you are happy with it, just commit]

> Added Begin,End also for {Par,ParConst,Inset}Iterator.
> 
> 2) implements DocumentIterator::backwardPos.

That's nice. Thank you.

Andre'

Reply via email to