Re: [Patch] Re: [patch] key event queue

2005-06-06 Thread Martin Vermeer
On Mon, 2005-06-06 at 15:17, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > I am fine with this. > (I'd better be...) Done. - Martin signature.asc Description: This is a digitally signed message part

Re: [Patch] Re: [patch] key event queue

2005-06-06 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: I am fine with this. (I'd better be...) -- Lgb

Re: [Patch] Re: [patch] key event queue

2005-06-06 Thread Martin Vermeer
On Mon, 2005-06-06 at 11:46, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > | On Wed, Jun 01, 2005 at 03:12:05PM +0300, Martin Vermeer wrote: > >> On Wed, Jun 01, 2005 at 01:31:55PM +0200, Lars Gullik Bjønnes wrote: > >> > Martin Vermeer <[EMAIL PROTECTED]> writes: > >

Re: [Patch] Re: [patch] key event queue

2005-06-06 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Wed, Jun 01, 2005 at 03:12:05PM +0300, Martin Vermeer wrote: >> On Wed, Jun 01, 2005 at 01:31:55PM +0200, Lars Gullik Bjønnes wrote: >> > Martin Vermeer <[EMAIL PROTECTED]> writes: > | ... | >> OK, that settles it then for me: put in the event que

Re: [Patch] Re: [patch] key event queue

2005-06-05 Thread Martin Vermeer
On Wed, Jun 01, 2005 at 03:12:05PM +0300, Martin Vermeer wrote: > On Wed, Jun 01, 2005 at 01:31:55PM +0200, Lars Gullik Bjønnes wrote: > > Martin Vermeer <[EMAIL PROTECTED]> writes: ... > OK, that settles it then for me: put in the event queue and reverse the > new stuff in workAreaKeyPress to

Re: [Patch] Re: [patch] key event queue

2005-06-03 Thread Helge Hafting
Lars Gullik Bjønnes wrote: Martin Vermeer <[EMAIL PROTECTED]> writes: [...] | No, I meant that just the other way around. The fact that fast mouse | scrolling exists allows us to make keyboard scrolling slow... as your | event queue for ex. does. The slowness will drive people to use the

Re: [Patch] Re: [patch] key event queue

2005-06-01 Thread Martin Vermeer
On Wed, Jun 01, 2005 at 01:31:55PM +0200, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > | On Wed, Jun 01, 2005 at 10:55:24AM +0200, Lars Gullik Bjønnes wrote: > >> Martin Vermeer <[EMAIL PROTECTED]> writes: > > > | ... > | > >> What the event queue accomplishes is t

Re: [Patch] Re: [patch] key event queue

2005-06-01 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Wed, Jun 01, 2005 at 10:55:24AM +0200, Lars Gullik Bjønnes wrote: >> Martin Vermeer <[EMAIL PROTECTED]> writes: > | ... | >> What the event queue accomplishes is to say that: "We do not allow >> auto-repeat events to queue up faster than we are abl

Re: [Patch] Re: [patch] key event queue

2005-06-01 Thread Martin Vermeer
On Wed, Jun 01, 2005 at 10:55:24AM +0200, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: ... > What the event queue accomplishes is to say that: "We do not allow > auto-repeat events to queue up faster than we are able to handle > them." How does your event queue affect

Re: [Patch] Re: [patch] key event queue

2005-06-01 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: >> how do you know when you get there? > | 1) You go to almost the right place using key repeat and the scrollbar. > | 2) You tap the PgDn key so it doesn't repeat, until you are there. > | The same as aiming a telescope: release fine motion, swing to the

Re: [Patch] Re: [patch] key event queue

2005-06-01 Thread Jean-Marc Lasgouttes
Martin> + if (s == "Up" || s == "Down" || s == "Left" || s == "Right") Martin> + screen().showCursor(*bv_); Of course testing directly keys is not acceptable, but we could imagine to have a LyXAction flag that tells whether an action requires a screen update... JMarc

Re: [Patch] Re: [patch] key event queue

2005-06-01 Thread Martin Vermeer
On Wed, 2005-06-01 at 11:55, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > | On Wed, 2005-06-01 at 11:05, Lars Gullik Bjønnes wrote: > >> Martin Vermeer <[EMAIL PROTECTED]> writes: > >> > >> >> Ok. I did my tests. > >> >> > >> >> I must admit that I now find it unu

Re: [Patch] Re: [patch] key event queue

2005-06-01 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Wed, 2005-06-01 at 11:05, Lars Gullik Bjønnes wrote: >> Martin Vermeer <[EMAIL PROTECTED]> writes: >> >> >> Ok. I did my tests. >> >> >> >> I must admit that I now find it unusable. No feedback on screen when >> >> using cursor keys for movement (o

Re: [Patch] Re: [patch] key event queue

2005-06-01 Thread Martin Vermeer
On Wed, 2005-06-01 at 11:05, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > >> Ok. I did my tests. > >> > >> I must admit that I now find it unusable. No feedback on screen when > >> using cursor keys for movement (on auto-repeat) > >> > >> Same with PageDown/PageUp.

Re: [Patch] Re: [patch] key event queue

2005-06-01 Thread Martin Vermeer
On Tue, May 31, 2005 at 10:38:35PM +0200, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > | On Tue, 2005-05-31 at 09:55, Lars Gullik Bjønnes wrote: > >> Martin Vermeer <[EMAIL PROTECTED]> writes: > >> > >> >> So it seems to fix most problems we have and feels uniforml

Re: [Patch] Re: [patch] key event queue

2005-06-01 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: >> Ok. I did my tests. >> >> I must admit that I now find it unusable. No feedback on screen when >> using cursor keys for movement (on auto-repeat) >> >> Same with PageDown/PageUp. (except from the scrollbar) > | Which I think is good enough. | I don't

Re: [Patch] Re: [patch] key event queue

2005-06-01 Thread Martin Vermeer
On Tue, May 31, 2005 at 10:38:35PM +0200, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > | On Tue, 2005-05-31 at 09:55, Lars Gullik Bjønnes wrote: > >> Martin Vermeer <[EMAIL PROTECTED]> writes: > >> > >> >> So it seems to fix most problems we have and feels uniforml

Re: [Patch] Re: [patch] key event queue

2005-05-31 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Tue, 2005-05-31 at 09:55, Lars Gullik Bjønnes wrote: >> Martin Vermeer <[EMAIL PROTECTED]> writes: >> >> >> So it seems to fix most problems we have and feels uniformly better that >> >> what we have right now? If so... >> > >> | Yes, I believe so.

Re: [Patch] Re: [patch] key event queue

2005-05-31 Thread Martin Vermeer
On Tue, 2005-05-31 at 09:55, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > >> So it seems to fix most problems we have and feels uniformly better that > >> what we have right now? If so... > > > | Yes, I believe so. > > > | Therefore I will commit the attached, if no

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: >> So it seems to fix most problems we have and feels uniformly better that >> what we have right now? If so... > | Yes, I believe so. > | Therefore I will commit the attached, if no new objections come up. I | have somewhat thoroughly tested this with t

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Martin Vermeer
On Mon, 2005-05-30 at 16:01, Andre Poenitz wrote: > On Mon, May 30, 2005 at 12:15:19PM +0300, Martin Vermeer wrote: > > > How "asynchrounous" is Martin's approach, i.e. how long will LyX be busy > > > after a user released PageDown? > > > > The time it takes to render one screen (or slightly over)

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> Key events are not coalesced (or have you dont something I have | Lars> not noticed?) without my patch. Sure my patch also does not do | Lars> it, but it could... Note that p

Re: [patch] key event queue

2005-05-30 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: > | | | this is kindo a proof-of-concept. >> | | This is a revised version of the patch. This time is also prunes key | | events that is caused by auto-repeat. (Gives imho very nice behavior.) > | And

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Andre Poenitz
On Mon, May 30, 2005 at 12:15:19PM +0300, Martin Vermeer wrote: > > How "asynchrounous" is Martin's approach, i.e. how long will LyX be busy > > after a user released PageDown? > > The time it takes to render one screen (or slightly over). I see no > large backlogs. So it seems to fix most proble

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Martin Vermeer
On Mon, 2005-05-30 at 12:50, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > | On Mon, 2005-05-30 at 10:56, Lars Gullik Bjønnes wrote: > >> Martin Vermeer <[EMAIL PROTECTED]> writes: > >> > >> | On Sat, May 28, 2005 at 12:12:07AM +0200, Lars Gullik Bjønnes wrote: > >

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Mon, 2005-05-30 at 12:46, Lars Gullik Bjønnes wrote: >> Martin Vermeer <[EMAIL PROTECTED]> writes: >> >> >> How "asynchrounous" is Martin's approach, i.e. how long will LyX be busy >> >> after a user released PageDown? >> > >> | The time it takes to

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Martin Vermeer
On Mon, 2005-05-30 at 12:46, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > >> How "asynchrounous" is Martin's approach, i.e. how long will LyX be busy > >> after a user released PageDown? > > > | The time it takes to render one screen (or slightly over). I see no > |

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> Key events are not coalesced (or have you dont something I have | Lars> not noticed?) without my patch. Sure my patch also does not do | Lars> it, but it could... Note that p

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Key events are not coalesced (or have you dont something I have Lars> not noticed?) without my patch. Sure my patch also does not do Lars> it, but it could... Note that pruning is only done if the screen Lars> update cannot keep

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Mon, 2005-05-30 at 10:56, Lars Gullik Bjønnes wrote: >> Martin Vermeer <[EMAIL PROTECTED]> writes: >> >> | On Sat, May 28, 2005 at 12:12:07AM +0200, Lars Gullik Bjønnes wrote: >> >> | Actually I have now had time to think about this for two weeks, a

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: >> How "asynchrounous" is Martin's approach, i.e. how long will LyX be busy >> after a user released PageDown? > | The time it takes to render one screen (or slightly over). I see no | large backlogs. Try that on a slower computer... -- Lgb

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Martin Vermeer
On Mon, 2005-05-30 at 11:49, Andre Poenitz wrote: > On Mon, May 30, 2005 at 09:56:06AM +0200, Lars Gullik Bjønnes wrote: > > | I have the feeling that pruning repeat key events is not wrong in > > | principle, but at best not needed. Without it, you know precisely > > | (under my scheme) that keepi

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Martin Vermeer
On Mon, 2005-05-30 at 10:56, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > | On Sat, May 28, 2005 at 12:12:07AM +0200, Lars Gullik Bjønnes wrote: > >> | Actually I have now had time to think about this for two weeks, and my > >> | considered opinion is a bit different

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Andre Poenitz
On Mon, May 30, 2005 at 09:56:06AM +0200, Lars Gullik Bjønnes wrote: > | I have the feeling that pruning repeat key events is not wrong in > | principle, but at best not needed. Without it, you know precisely > | (under my scheme) that keeping the PgDown key down for 0.5 secs will get > | you 10 sc

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Sun, May 29, 2005 at 09:58:22PM +0300, Martin Vermeer wrote: >> On Sat, May 28, 2005 at 12:12:07AM +0200, Lars Gullik Bjønnes wrote: | >> > | +inline flags operator|(flags const f, flags const g) >> > | +{ >> > | +int const intf(static_ca

Re: [Patch] Re: [patch] key event queue

2005-05-30 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Sat, May 28, 2005 at 12:12:07AM +0200, Lars Gullik Bjønnes wrote: >> | Actually I have now had time to think about this for two weeks, and my >> | considered opinion is a bit different... >> >> What you write belowe seems very sane. But I think that

Re: [Patch] Re: [patch] key event queue

2005-05-29 Thread Martin Vermeer
On Sun, May 29, 2005 at 09:58:22PM +0300, Martin Vermeer wrote: > On Sat, May 28, 2005 at 12:12:07AM +0200, Lars Gullik Bjønnes wrote: > > | +inline flags operator|(flags const f, flags const g) > > | +{ > > | + int const intf(static_cast(f)); > > | + int const intg(static_cast(g)); > > | + ret

Re: [Patch] Re: [patch] key event queue

2005-05-29 Thread Martin Vermeer
On Sat, May 28, 2005 at 12:12:07AM +0200, Lars Gullik Bjønnes wrote: > | Actually I have now had time to think about this for two weeks, and my > | considered opinion is a bit different... > > What you write belowe seems very sane. But I think that my keyevent > queue is still needed? (but to fix

Re: [Patch] Re: [patch] key event queue

2005-05-27 Thread Lars Gullik Bjønnes
| Actually I have now had time to think about this for two weeks, and my | considered opinion is a bit different... What you write belowe seems very sane. But I think that my keyevent queue is still needed? (but to fix a different problem) | +inline flags operator|(flags const f, flags const g)

Re: [Patch] Re: [patch] key event queue

2005-05-27 Thread Martin Vermeer
On Fri, May 27, 2005 at 04:28:32PM -0400, Bennett Helm wrote: > On May 27, 2005, at 2:59 PM, Martin Vermeer wrote: > > >Actually I have now had time to think about this for two weeks, and my > >considered opinion is a bit different... > > This patch fixes problems on the Mac with dropping charact

Re: [Patch] Re: [patch] key event queue

2005-05-27 Thread Bennett Helm
On May 27, 2005, at 2:59 PM, Martin Vermeer wrote: Actually I have now had time to think about this for two weeks, and my considered opinion is a bit different... This patch fixes problems on the Mac with dropping characters and with reordering characters. Also, scrolling feels much better.

[Patch] Re: [patch] key event queue

2005-05-27 Thread Martin Vermeer
On Thu, May 19, 2005 at 09:46:27AM +0200, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | On Thu, May 12, 2005 at 06:47:50PM +0200, Lars Gullik Bjønnes wrote: > >> this is kindo a proof-of-concept. > > > | Is there a specific reason this queue is in the frontend and no

Re: [patch] key event queue

2005-05-19 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Thu, May 12, 2005 at 06:47:50PM +0200, Lars Gullik Bjønnes wrote: >> this is kindo a proof-of-concept. > | Is there a specific reason this queue is in the frontend and not in the | core? > | If it were in the core we could have an 'update' lfuns, and

Re: [patch] key event queue

2005-05-16 Thread Andre Poenitz
On Mon, May 16, 2005 at 11:36:42AM -0400, Bennett Helm wrote: > 1.0%62.8% LyX lengthcombo.C:72 > 0.7%60.2% LyX lengthcombo.C:72 > 57.6% 59.1% LyX lengthcombo.C:72 > 0.7%0.7%LyX NO_SRC_FILE:? > 0.6%0

Re: [patch] key event queue

2005-05-16 Thread Bennett Helm
On May 13, 2005, at 3:54 PM, Martin Vermeer wrote: On Fri, May 13, 2005 at 03:23:16PM -0400, Bennett Helm wrote: On May 13, 2005, at 10:56 AM, Martin Vermeer wrote: (I tried doing a "Function Trace" within Shark, specifying QFontEngineMac::doTextTask as the function to trace, but I get the followin

Re: [patch] key event queue

2005-05-16 Thread Bennett Helm
On May 13, 2005, at 4:38 PM, Andre Poenitz wrote: On Fri, May 13, 2005 at 10:39:16AM -0400, Bennett Helm wrote: Setting granularity to be "Source Line" gives the following: 59.4% 61.3% LyX lengthcombo.C:63 0.8%0.8%LyX NO_SRC_FILE:? 0.7%0.8%

[Discussion patch :-)] Re: [patch] key event queue

2005-05-15 Thread Martin Vermeer
On Sun, May 15, 2005 at 07:11:02PM +0200, Helge Hafting wrote: > On Sun, May 15, 2005 at 05:09:39PM +0300, Martin Vermeer wrote: > > Lars, > > > > Now that I have had some time to think it over, I am more and more > > inclined to suspect that there is something to my dark fear. > > > > As I under

Re: [patch] key event queue

2005-05-15 Thread Andre Poenitz
On Sun, May 15, 2005 at 05:09:39PM +0300, Martin Vermeer wrote: > qt-mt, doesn't that mean Qt multi-threading? Or am I holding the wrong > end of the stick? I think that's the thread-safe version of the library. It does not use multiple threads by itself. Andre'

Re: [patch] key event queue

2005-05-15 Thread Helge Hafting
On Sun, May 15, 2005 at 05:09:39PM +0300, Martin Vermeer wrote: > Lars, > > Now that I have had some time to think it over, I am more and more > inclined to suspect that there is something to my dark fear. > > As I understand it, LyX, Qt and X all process events in a "linear" > fashion. This mean

Re: [patch] key event queue

2005-05-15 Thread Martin Vermeer
On Fri, May 13, 2005 at 06:10:54PM +0200, Lars Gullik Bjønnes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > | On Fri, May 13, 2005 at 05:37:18PM +0200, Lars Gullik Bjønnes wrote: > > > | ... > | Yet I have a dark fear that somewhere in that 25 ms a > | processEvents-handled keystroke

Re: [patch] key event queue

2005-05-14 Thread Juergen Spitzmueller
Andre Poenitz wrote: > Could you just comment out the whole body of LengthCombo::noPercents() > in src/frontend/qt2/lengthcombo.C  (this is lines 62-69 or so) > and try again? It would certainly be a big surprise if that function would be called while typing. Jürgen

Re: [patch] key event queue

2005-05-13 Thread Andre Poenitz
On Fri, May 13, 2005 at 10:39:16AM -0400, Bennett Helm wrote: > Setting granularity to be "Source Line" gives the following: > > 59.4% 61.3% LyX lengthcombo.C:63 > 0.8%0.8%LyX NO_SRC_FILE:? > 0.7%0.8%LyX lengthcombo.C:63 >

Re: [patch] key event queue (was: Profiling LyX-140 on Mac)

2005-05-13 Thread Andre Poenitz
On Thu, May 12, 2005 at 06:47:50PM +0200, Lars Gullik Bjønnes wrote: > this is kindo a proof-of-concept. Is there a specific reason this queue is in the frontend and not in the core? If it were in the core we could have an 'update' lfuns, and a 'dont need up-to-date cache' lfun flags and play ga

Re: [patch] key event queue

2005-05-13 Thread Martin Vermeer
On Fri, May 13, 2005 at 03:23:16PM -0400, Bennett Helm wrote: > On May 13, 2005, at 10:56 AM, Martin Vermeer wrote: > > >>(I tried doing a "Function Trace" within Shark, specifying > >>QFontEngineMac::doTextTask as the function to trace, but I get the > >>following error message: "Failed to subver

Re: [patch] key event queue

2005-05-13 Thread Bennett Helm
On May 13, 2005, at 10:56 AM, Martin Vermeer wrote: (I tried doing a "Function Trace" within Shark, specifying QFontEngineMac::doTextTask as the function to trace, but I get the following error message: "Failed to subvert traced functions. Verify that all of the symbols to trace exist in the target

Re: [patch] key event queue

2005-05-13 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Fri, May 13, 2005 at 05:37:18PM +0200, Lars Gullik Bjønnes wrote: > | ... | >> Note that we now send keyevents to the core every 25ms (+ the time it >> takes to handle them) 25ms should not be noticable when typing unless >> (as the case is on your

Re: [patch] key event queue

2005-05-13 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | Bennett Helm <[EMAIL PROTECTED]> writes: > | | On May 12, 2005, at 8:07 PM, Lars Gullik Bjønnes wrote: >> >>> [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: >>> >>> | | this is kindo a proof-of-concept. >>> | This is a revised version of the

Re: [patch] key event queue

2005-05-13 Thread Martin Vermeer
On Fri, May 13, 2005 at 05:37:18PM +0200, Lars Gullik Bjønnes wrote: ... > Note that we now send keyevents to the core every 25ms (+ the time it > takes to handle them) 25ms should not be noticable when typing unless > (as the case is on your box) the time to handle the event is really > long...

Re: [patch] key event queue

2005-05-13 Thread Lars Gullik Bjønnes
Bennett Helm <[EMAIL PROTECTED]> writes: | On May 12, 2005, at 8:07 PM, Lars Gullik Bjønnes wrote: > >> [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: >> >> | | this is kindo a proof-of-concept. >>> >> | This is a revised version of the patch. This time is also prunes key >> | events that is caus

Re: [patch] key event queue

2005-05-13 Thread Jose' Matos
On Friday 13 May 2005 13:41, Jean-Marc Lasgouttes wrote: > > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > > Lars> Hmm... what part of "song" did you not understand? > > I do not think the event is broadcasted on the radio, but I may be > mistaken. That only proves you didn't r

Re: [patch] key event queue

2005-05-13 Thread Martin Vermeer
On Fri, May 13, 2005 at 10:39:16AM -0400, Bennett Helm wrote: > Jean-Marc - > > I'm not sure what I'm doing here, but here goes anyway. ... > >I think that there is a way with Shark.app to have a profile of the > >code in a function. Could you try that with > >QFontEngineMac::doTextTask? I am c

Re: [patch] key event queue

2005-05-13 Thread Bennett Helm
Jean-Marc - I'm not sure what I'm doing here, but here goes anyway. On May 13, 2005, at 9:43 AM, Jean-Marc Lasgouttes wrote: Your latest profile showed that a _lot_ of time is spent in QFontEngineMac::doTextTask, with mostly none of that dispatched to the lower-level functions. Can you confirm that

Re: [patch] key event queue

2005-05-13 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> With this new version of the patch, I cannot duplicate either Bennett> the re-ordering problem or the problem of dropping Bennett> characters. However, typing feels a bit slower than before, Bennett> with characters appearing on

Re: [patch] key event queue

2005-05-13 Thread Bennett Helm
On May 12, 2005, at 8:07 PM, Lars Gullik Bjønnes wrote: [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | | this is kindo a proof-of-concept. | This is a revised version of the patch. This time is also prunes key | events that is caused by auto-repeat. (Gives imho very nice behavior.) And I clea

Re: [patch] key event queue

2005-05-13 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Hmm... what part of "song" did you not understand? I do not think the event is broadcasted on the radio, but I may be mistaken. And seriously, most of the interest of the show is visual... JMarc

Re: [patch] key event queue

2005-05-13 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Jose'" == Jose' Matos <[EMAIL PROTECTED]> writes: > | Jose'> The paper shows the UK is in tune with the remaining Europe | Jose'> when voting, while perhaps surprisingly France is out of tune. | Jose'> Thus we conclude that Jean-Marc does

Re: [patch] key event queue

2005-05-13 Thread Jean-Marc Lasgouttes
> "Jose'" == Jose' Matos <[EMAIL PROTECTED]> writes: Jose'> The paper shows the UK is in tune with the remaining Europe Jose'> when voting, while perhaps surprisingly France is out of tune. Jose'> Thus we conclude that Jean-Marc does not care about it. (Now Jose'> this is far fetched...) We

Re: [patch] key event queue

2005-05-13 Thread Jose' Matos
On Friday 13 May 2005 00:16, Lars Gullik Bjønnes wrote: > > >> | Do you want more comments or are you feeling fragile? > >> > >> Keep it comming. > >> (Rock on, baby!) > | > | I bet you're excited by the up-coming Eurovision song contest :) > > Hey, do you follow that? Sure they do, as a proof o

Re: [patch] key event queue

2005-05-12 Thread Martin Vermeer
On Fri, May 13, 2005 at 02:07:53AM +0200, Lars Gullik Bjønnes wrote: > [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: > > | | this is kindo a proof-of-concept. > > > | This is a revised version of the patch. This time is also prunes key > | events that is caused by auto-repeat. (Gives imho very n

Re: [patch] key event queue

2005-05-12 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > | Creation sounds a bit biblical. "For recruits" is what I was > | suggesting. > > I thought you wanted be to pound the dateing scene harder (there got to > be a pun in there...) Never pound too hard on an all male m/l... > I was never much of a bug fixer... (unless

Re: [patch] key event queue

2005-05-12 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: > >> Angus Leeming <[EMAIL PROTECTED]> writes: >> >> | Can you advertise? >> >> For creation of recruits? > | Creation sounds a bit biblical. "For recruits" is what I was suggesting. I thought you wanted be to pound the date

Re: [patch] key event queue

2005-05-12 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > Angus Leeming <[EMAIL PROTECTED]> writes: > > | Can you advertise? > > For creation of recruits? Creation sounds a bit biblical. "For recruits" is what I was suggesting. > (I have a lot of code buried away... just waiting for 1.5.x to pop > up...) Thank goodness M

Re: [patch] key event queue

2005-05-12 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | | this is kindo a proof-of-concept. > | This is a revised version of the patch. This time is also prunes key | events that is caused by auto-repeat. (Gives imho very nice behavior.) And I cleaned it up a bit. If people feels that this make behavi

Re: [patch] key event queue

2005-05-12 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Can you advertise? For creation of recruits? (I have a lot of code buried away... just waiting for 1.5.x to pop up...) -- Lgb

Re: [patch] key event queue

2005-05-12 Thread Angus Leeming
Lars Gullik Bjønnes wrote: >>> That was awfully nice of you. >> > | I'm a nice guy. > > Prove it. Come to Paris and let me re-verify again. I'm working on it. Life's a bit messy ATM, but a Eurostar to Paris for the w/e is something I'm striving for. > I might be a new recruit, but I know how to

Re: [patch] key event queue

2005-05-12 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: >> >> That was awfully nice of you. > | I'm a nice guy. Prove it. Come to Paris and let me re-verify again. | FC4 test 3. Actually it was FC3... >> with what is supplied there, there are no such problems. > | Well, you seem quite happy to use 'new',

Re: [patch] key event queue

2005-05-12 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > Angus Leeming <[EMAIL PROTECTED]> writes: > > | It was only a small patch. Anyway, I have a rule not to be nasty to new > | recruits. > > That was awfully nice of you. I'm a nice guy. > I see that with gcc 3.3.3 and qt 3.3.3 it is not possible to default > construc

Re: [patch] key event queue

2005-05-12 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | It was only a small patch. Anyway, I have a rule not to be nasty to new | recruits. That was awfully nice of you. I see that with gcc 3.3.3 and qt 3.3.3 it is not possible to default construct QKeyEvents... this means that they are impossible to store

Re: [patch] key event queue

2005-05-12 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > | Do I have to add a smiley? > > Smilies are for sissies. Good. >>> | Do you want more comments or are you feeling fragile? >>> >>> Keep it comming. >>> (Rock on, baby!) >> > | I bet you're excited by the up-coming Eurovision song contest :) > > Hey, do you follow

Re: [patch] key event queue

2005-05-12 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: >> | sync_non_user_events() doesn't appear to be used. >> >> only becuase you didn't get a diff of all my modifications... >> I make the sync_non_user_events for testing... I added it to the token >> loop when reading lyx files... > | Then don't ask me to

Re: [patch] key event queue

2005-05-12 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > I think > > qApp->processEvents(5); > > is just the same thing. Does that exist for earlier qt versions? doc.troll.no ? Certainly, QEventLoop does not exist for Qt < 3.1 > | sync_non_user_events() doesn't appear to be used. > > only becuase you didn't get a diff o

Re: [patch] key event queue

2005-05-12 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: >> | Lars Gullik Bjønnes wrote: Comments bitte please por favor. >>> >> | It's a very small patch... >> >> That is the nice thing about it... > | Why isn't step_timer a QContentPane member? artifact of proof-of-concept I

Re: [patch] key event queue

2005-05-12 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > | Lars Gullik Bjønnes wrote: >>> Comments bitte please por favor. >> > | It's a very small patch... > > That is the nice thing about it... Why isn't step_timer a QContentPane member? More than one LyX window? Why create step_timer on the heap and not on the stack? Pu

Re: [patch] key event queue

2005-05-12 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: >> - most likely a check for update in progress is needed in the >> keyeventTimeout >> - event coalescing would be nice... (may be 1.5 stuff if we go this route) > | On risk of appearing dense, would you please go over this patch step by | step and expl

Re: [patch] key event queue

2005-05-12 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: >> Comments bitte please por favor. > | It's a very small patch... That is the nice thing about it... Index: QContentPane.C === RCS file: /usr/local/lyx/cvsroot/

Re: [patch] key event queue

2005-05-12 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > Comments bitte please por favor. It's a very small patch... -- Angus

Re: [patch] key event queue (was: Profiling LyX-140 on Mac)

2005-05-12 Thread Martin Vermeer
On Thu, May 12, 2005 at 06:47:50PM +0200, Lars Gullik Bjønnes wrote: > [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: > > | | Then we just need a timer that kicks in some 10-20 times a second to > | | check the queue and do the real work. > > > | and with the queue doing the right thing we can ac

Re: [patch] key event queue

2005-05-12 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: > | | | Then we just need a timer that kicks in some 10-20 times a second to | | | check the queue and do the real work. >> | | and with the queue doing the right thing we can actually put | | process

Re: [patch] key event queue

2005-05-12 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | I think the reordering problem would go when using the eventLoop version | of processEvents, when available. I.e. _without_ the ExcludeUserInput | arg, the intended behaviour of which (storing up keystrokes rather than | dropping them) is now done by th

Re: [patch] key event queue

2005-05-12 Thread Lars Gullik Bjønnes
Bennett Helm <[EMAIL PROTECTED]> writes: | On May 12, 2005, at 12:56 PM, Lars Gullik Bjønnes wrote: > >> [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: >> >> | Would be nice if people could try this a bit and see if the problems >> | seen earlier can be reproduced with this patch applied. >>> >>

Re: [patch] key event queue

2005-05-12 Thread Martin Vermeer
On Thu, 2005-05-12 at 20:16, Bennett Helm wrote: > On May 12, 2005, at 12:56 PM, Lars Gullik BjÃnnes wrote: > > > [EMAIL PROTECTED] (Lars Gullik BjÃnnes) writes: > > > > | Would be nice if people could try this a bit and see if the problems > > | seen earlier can be reproduced with this patch appl

Re: [patch] key event queue

2005-05-12 Thread Lars Gullik Bjønnes
Martin Vermeer <[EMAIL PROTECTED]> writes: | On Thu, 2005-05-12 at 19:56, Lars Gullik Bjønnes wrote: >> [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: >> >> | Would be nice if people could try this a bit and see if the problems >> | seen earlier can be reproduced with this patch applied. >> > >>

Re: [patch] key event queue

2005-05-12 Thread Bennett Helm
On May 12, 2005, at 12:56 PM, Lars Gullik Bjønnes wrote: [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | Would be nice if people could try this a bit and see if the problems | seen earlier can be reproduced with this patch applied. | - most likely a check for update in progress is needed in the

Re: [patch] key event queue

2005-05-12 Thread Martin Vermeer
On Thu, 2005-05-12 at 19:56, Lars Gullik BjÃnnes wrote: > [EMAIL PROTECTED] (Lars Gullik BjÃnnes) writes: > > | Would be nice if people could try this a bit and see if the problems > | seen earlier can be reproduced with this patch applied. > > > | - most likely a check for update in progress is n

Re: [patch] key event queue

2005-05-12 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | Would be nice if people could try this a bit and see if the problems | seen earlier can be reproduced with this patch applied. > | - most likely a check for update in progress is needed in the | keyeventTimeout | - event coalescing would be nice.

[patch] key event queue (was: Profiling LyX-140 on Mac)

2005-05-12 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | | Then we just need a timer that kicks in some 10-20 times a second to | | check the queue and do the real work. > | and with the queue doing the right thing we can actually put | processEvents allover as much as we want to to make the interactive