Re: [patch] fix bug 808

2006-09-27 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > So what do we get from that? From the FAQ, I gather that it only works > for tables not in a float. What happens in a float? One solution would be to wrap the table in a minipage whenever it includes a footnote. Or, probably much better, support threeparttable. BTW

Re: [patch] fix bug 808

2006-09-27 Thread Georg Baum
Jean-Marc Lasgouttes wrote: >> "Georg" == Georg Baum >> <[EMAIL PROTECTED]> >> writes: > > Georg> Then I propose to put this patch (1.4 version) in trunk and > Georg> 1.4. OK? > > So what do we get from that? From the FAQ, I gather that it only works > for tables not in a float. What

Re: [patch] fix bug 808

2006-09-27 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Then I propose to put this patch (1.4 version) in trunk and Georg> 1.4. OK? So what do we get from that? From the FAQ, I gather that it only works for tables not in a float. What happens in a float? JMarc

Re: [patch] fix bug 808

2006-09-27 Thread Juergen Spitzmueller
Georg Baum wrote: > Then I propose to put this patch (1.4 version) in trunk and 1.4. OK? Looks very reasonable to me. Jürgen

Re: [patch] fix bug 808

2006-09-27 Thread Georg Baum
Juergen Spitzmueller wrote: > Georg Baum wrote: >> I don't understand. Maybe we do not talk about the same thing? This is my >> test document: All footnotes appear and none is swallowed. >> Maybe you mean that they may not appear on the same page where the table >> is? > > Not only that. For me,

Re: [patch] fix bug 808

2006-09-26 Thread Juergen Spitzmueller
Georg Baum wrote: > I don't understand. Maybe we do not talk about the same thing? This is my > test document: All footnotes appear and none is swallowed. > Maybe you mean that they may not appear on the same page where the table > is? Not only that. For me, some footnotes of your test document a

Re: [patch] fix bug 808

2006-09-26 Thread Georg Baum
Juergen Spitzmueller wrote: > Georg Baum wrote: >> But: does it really work inside floats? >> >> For me: Yes. I tried both figure and table floats. It is not possible to >> enter footnotes in a float directly, but if I cheat and insert it with a >> text editor in the .lyx file it works. A footnote

Re: [patch] fix bug 808

2006-09-26 Thread Georg Baum
Jean-Marc Lasgouttes wrote: >> "Georg" == Georg Baum >> <[EMAIL PROTECTED]> >> writes: > > Georg> Only once. addExternalPreamble() ensures that: If the argument > Georg> is already there, then it is not added again. > > Nice. I guess this should be renamed to something else, if it is

Re: [patch] fix bug 808

2006-09-26 Thread Juergen Spitzmueller
Georg Baum wrote: > But: does it really work inside floats? > > For me: Yes. I tried both figure and table floats. It is not possible to > enter footnotes in a float directly, but if I cheat and insert it with a > text editor in the .lyx file it works. A footnote in a table in a float > works also

Re: [patch] fix bug 808

2006-09-26 Thread Georg Baum
Jean-Marc Lasgouttes wrote: >> "Georg" == Georg Baum >> <[EMAIL PROTECTED]> >> writes: > + for (; it != end; ++it) { > + if (it->lyxCode() == InsetBase::FOOT_CODE) { > + features.require("footnote"); > + features.addExternalPreamb

Re: [patch] fix bug 808

2006-09-26 Thread Juergen Spitzmueller
Georg Baum wrote: > This surprisingly simple patch (for 1.4) fixes bug 808 (footnotes in > tables) which has been discussed several times. I do not consider this a > file format change, since footnotes should work even in tables and floats, > so I think it is suitable for 1.4. I do not know whether

Re: [patch] fix bug 808

2006-09-26 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Jean-Marc Lasgouttes wrote: >>> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: >> Georg> Only once. addExternalPreamble() ensures that: If the argument Georg> is already there, then it is not added again. >> Nice. I guess this

Re: [patch] fix bug 808

2006-09-26 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Jean-Marc Lasgouttes wrote: >>> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: >> + for (; it != end; ++it) { + if (it->lyxCode() == >> InsetBase::FOOT_CODE) { + features.require("footnote"); + >> features.addExternalPreamble( +

Re: [patch] fix bug 808

2006-09-26 Thread Georg Baum
Juergen Spitzmueller wrote: > Georg Baum wrote: >> This surprisingly simple patch (for 1.4) fixes bug 808 (footnotes in >> tables) which has been discussed several times. I do not consider this a >> file format change, since footnotes should work even in tables and >> floats, so I think it is suit

Re: [patch] fix bug 808

2006-09-26 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> This surprisingly simple patch (for 1.4) fixes bug 808 Georg> (footnotes in tables) which has been discussed several times. I Georg> do not consider this a file format change, since footnotes Georg> should work even in tables and float

[patch] fix bug 808

2006-09-26 Thread Georg Baum
This surprisingly simple patch (for 1.4) fixes bug 808 (footnotes in tables) which has been discussed several times. I do not consider this a file format change, since footnotes should work even in tables and floats, so I think it is suitable for 1.4. I do not know whether/how it interferes with wo

Re: [patch] fix bug 808

2006-09-26 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> This surprisingly simple patch (for 1.4) fixes bug 808 Georg> (footnotes in tables) which has been discussed several times. I Georg> do not consider this a file format change, since footnotes Georg> should work even in tables and float