On Wed, Apr 05, 2006 at 09:27:13PM +0200, Georg Baum wrote:
> Am Mittwoch, 5. April 2006 03:39 schrieb Enrico Forestieri:
> > I also fixed the bug about the checkbox status in QPrefs.C, as it is
> > very annoying that it does the contrary of what its label says
> > (inverted logic).
>
> What abou
On Wed, Apr 05, 2006 at 09:27:13PM +0200, Georg Baum wrote:
> Am Mittwoch, 5. April 2006 03:39 schrieb Enrico Forestieri:
> > I also fixed the bug about the checkbox status in QPrefs.C, as it is
> > very annoying that it does the contrary of what its label says
> > (inverted logic).
>
> What about
On Wed, Apr 05, 2006 at 09:27:13PM +0200, Georg Baum wrote:
> Am Mittwoch, 5. April 2006 03:39 schrieb Enrico Forestieri:
> > I also fixed the bug about the checkbox status in QPrefs.C, as it is
> > very annoying that it does the contrary of what its label says
> > (inverted logic).
>
> What about
Am Mittwoch, 5. April 2006 03:39 schrieb Enrico Forestieri:
> I also fixed the bug about the checkbox status in QPrefs.C, as it is
> very annoying that it does the contrary of what its label says
> (inverted logic).
What about qt4, xforms, gtk? Please send a patch if one of them needs this
fix, t
On Tue, Apr 04, 2006 at 10:13:40PM +0200, Georg Baum wrote:
> Am Montag, 3. April 2006 11:58 schrieb Enrico Forestieri:
> > Only a small glitch, Georg. In os_cygwin.C, the test "p.length() < 1"
> > in is_posix_path() and is_windows_path() should be changed to
> > "p.length() <= 1"
>
> I forgot th
Am Dienstag, 4. April 2006 22:18 schrieb Enrico Forestieri:
> On Tue, Apr 04, 2006 at 09:50:15PM +0200, Georg Baum wrote:
> > Please add a comment why this is necessary.
>
> I tried to explain this one here:
> http://bugzilla.lyx.org/show_bug.cgi?id=2344
>
> Does it suffice mentioning bug 2344 in
On Tue, Apr 04, 2006 at 09:50:15PM +0200, Georg Baum wrote:
> > Index: src/support/environment.C
> > ===
> > --- src/support/environment.C (revision 13547)
> > +++ src/support/environment.C (working copy)
> > @@ -95,7 +95,11 @@ vo
Am Montag, 3. April 2006 11:58 schrieb Enrico Forestieri:
> Only a small glitch, Georg. In os_cygwin.C, the test "p.length() < 1"
> in is_posix_path() and is_windows_path() should be changed to
> "p.length() <= 1"
I forgot that, please fix thsi together with the comment.
Georg
Am Montag, 3. April 2006 10:15 schrieb Enrico Forestieri:
> On Sun, Apr 02, 2006 at 10:20:35PM +0200, Georg Baum wrote:
>
> > Am Sonntag, 2. April 2006 17:57 schrieb Enrico Forestieri:
> > > enum path_target {
> > > DEFAULT,
> > > LATEX
> > > }
> > >
> > > std::string internal_path(std::s
On Mon, Apr 03, 2006 at 11:40:03AM +0200, Jean-Marc Lasgouttes wrote:
> > "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
>
> >> Georg, cygwin runs on windows and it understands both posix and
> >> win-style paths. So, what is external and what is internal? In the
> >> win32 version C:/xxx
On Mon, Apr 03, 2006 at 11:22:48AM +0200, Georg Baum wrote:
> Enrico Forestieri wrote:
>
> > No, it is not because of that. The point is that
> > lyx::support::latex_path() calls ChangeExtensions, which in turn
> > calls internal_path(), which would turn the path into posix in
> > cygwin.
>
> I
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
>> Georg, cygwin runs on windows and it understands both posix and
>> win-style paths. So, what is external and what is internal? In the
>> win32 version C:/xxx is the internal representation, in the *nix
>> version /c/xxx is the internal rep
Enrico Forestieri wrote:
> No, it is not because of that. The point is that
> lyx::support::latex_path() calls ChangeExtensions, which in turn
> calls internal_path(), which would turn the path into posix in
> cygwin.
I see. Calling internal_path() in ChangeExtension seems wrong to me. I'll
have
On Sun, Apr 02, 2006 at 10:20:35PM +0200, Georg Baum wrote:
> Am Sonntag, 2. April 2006 17:57 schrieb Enrico Forestieri:
> > Well, I am facing a problem related to it now. Please, help this
> > C++ newbie to solve the following problem.
> >
> > I had already the need to add an enum argument to in
Am Sonntag, 2. April 2006 17:57 schrieb Enrico Forestieri:
> Well, I am facing a problem related to it now. Please, help this
> C++ newbie to solve the following problem.
>
> I had already the need to add an enum argument to internal_path.
> Its natural declaration was in "support/os.h" in the
> l
On Sun, Apr 02, 2006 at 04:54:44PM +, Angus Leeming wrote:
> Enrico Forestieri <[EMAIL PROTECTED]> writes:
> > In C I would simply "#include " within
> > "support/filetools.h", but I don't think this is the correct C++
> > solution.
>
> You can't forward declare enums, so your
> proposed solu
Enrico Forestieri <[EMAIL PROTECTED]> writes:
> In C I would simply "#include " within
> "support/filetools.h", but I don't think this is the correct C++
> solution.
You can't forward declare enums, so your
proposed solution is fine for now.
An alternative would be to define a class that
is conve
On Sun, Apr 02, 2006 at 01:14:09PM +0200, Georg Baum wrote:
> Am Samstag, 1. April 2006 21:17 schrieb Enrico Forestieri:
> > On Sat, Apr 01, 2006 at 05:55:07PM +0200, Georg Baum wrote:
> > > Almost. No boolean please (that would circumvent the whole idea of
> > > internal/external path). Simply h
Am Samstag, 1. April 2006 21:17 schrieb Enrico Forestieri:
> On Sat, Apr 01, 2006 at 05:55:07PM +0200, Georg Baum wrote:
> > Almost. No boolean please (that would circumvent the whole idea of
> > internal/external path). Simply hardcode the decision in internal_path
> > and external_path. Later w
On Sat, Apr 01, 2006 at 05:55:07PM +0200, Georg Baum wrote:
> Am Samstag, 1. April 2006 17:07 schrieb Enrico Forestieri:
> > Understood. I'll leave the checkbox thing as it is now, i.e., the user
> > can subvert the configure script decisions (a really bad idea) and
> > arrange things such that L
Am Samstag, 1. April 2006 17:07 schrieb Enrico Forestieri:
> Understood. I'll leave the checkbox thing as it is now, i.e., the user
> can subvert the configure script decisions (a really bad idea) and
> arrange things such that LyX internally uses the format decided by
> internal_path(). My idea i
On Sat, Apr 01, 2006 at 01:46:39PM +0200, Georg Baum wrote:
> I fear we have been talking past each other. I never wanted a "dirty"
> patch. I wanted a correct one, but split up in smaller chunks. For
> example, the additional check box could be left out in the first version,
> hardcoding win s
Am Freitag, 31. März 2006 21:56 schrieb Enrico Forestieri:
> Here is a minimal patch for cygwin. It fixes bug 2344 and the following
> two bugs:
>
> - Export to latex fails when cygwin_path_fix is true, because
> prefixIs(p1,p2) in copyFile() fails to recognize that p2 is prefix of
> p1 when t
On Fri, Mar 31, 2006 at 09:56:41PM +0200, Enrico Forestieri wrote:
> The correct fix to this problem is my other patch in the thread
> "Cygwin polishing", which however, I admit tries to solve too much
> things in a single shot.
This is to reaffirm what I said. I just discovered another bug relat
Here is a minimal patch for cygwin. It fixes bug 2344 and the following
two bugs:
- Export to latex fails when cygwin_path_fix is true, because
prefixIs(p1,p2) in copyFile() fails to recognize that p2 is prefix of
p1 when they are in different styles.
- When a file is exported to latex and t
25 matches
Mail list logo
