On Tue, Apr 04, 2006 at 09:50:15PM +0200, Georg Baum wrote:
> > Index: src/support/environment.C
> > ===================================================================
> > --- src/support/environment.C (revision 13547)
> > +++ src/support/environment.C (working copy)
> > @@ -95,7 +95,11 @@ void setEnvPath(string const & name, vec
> > for (; it != end; ++it) {
> > if (it != begin)
> > ss << separator;
> > +#if defined(__CYGWIN__) || defined(__CYGWIN32__)
> > + ss << os::internal_path(*it);
> > +#else
> > ss << os::external_path(*it);
> > +#endif
>
> Please add a comment why this is necessary.
I tried to explain this one here:
http://bugzilla.lyx.org/show_bug.cgi?id=2344
Does it suffice mentioning bug 2344 in a comment?
> Attached is my modified version of the patch (without changelogs). Please
> test whether it still works.
I had a glance and think it is ok. However, I will test it later.
I see that you did not correct the "p.length() < 1" to "p.length() <= 1"
in is_posix_path() and is_windows_path() (that was an oversight on my
part), so I will do it.
Many thanks Georg!
--
Enrico
