Re: [patch] fix bug 2344 and paths issues on cygwin

[Enrico Forestieri]

On Wed, Apr 05, 2006 at 09:27:13PM +0200, Georg Baum wrote:
> Am Mittwoch, 5. April 2006 03:39 schrieb Enrico Forestieri:
> > I also fixed the bug about the checkbox status in QPrefs.C, as it is
> > very annoying that it does the contrary of what its label says
> > (inverted logic).
> 
> What about qt4, xforms, gtk? Please send a patch if one of them needs this 
> fix, too.

Here it is. I found no cygwin traces in gtk. I think that the gtk libs
are even available as official cygwin packages, as you can see from the
attached snapshot. I have never tried them, though.

The log msg could be:

        * src/frontends/qt4/QPrefsDialog.C:
        (QPrefsDialog::apply, QPrefsDialog::update): fix inverted logic
        of rc.cygwin_path_fix
        
        * src/frontends/xforms/FormPreferences.C:
        (FormPreferences::OutputsMisc::apply,
        FormPreferences::OutputsMisc::update): fix inverted logic of
        rc.cygwin_path_fix

-- 
Enrico

Index: src/frontends/qt4/QPrefsDialog.C
===================================================================
--- src/frontends/qt4/QPrefsDialog.C    (revision 13559)
+++ src/frontends/qt4/QPrefsDialog.C    (working copy)
@@ -1147,7 +1147,7 @@ void QPrefsDialog::apply(LyXRC & rc) con
 
 
 #if defined(__CYGWIN__) || defined(__CYGWIN32__)
-       rc.cygwin_path_fix = cygwinpathModule->pathCB->isChecked();
+       rc.cygwin_path_fix = !cygwinpathModule->pathCB->isChecked();
 #endif
 
 
@@ -1459,7 +1459,7 @@ void QPrefsDialog::update(LyXRC const & 
 
 
 #if defined(__CYGWIN__) || defined(__CYGWIN32__)
-       cygwinpathModule->pathCB->setChecked(rc.cygwin_path_fix);
+       cygwinpathModule->pathCB->setChecked(!rc.cygwin_path_fix);
 #endif
 
 
Index: src/frontends/xforms/FormPreferences.C
===================================================================
--- src/frontends/xforms/FormPreferences.C      (revision 13559)
+++ src/frontends/xforms/FormPreferences.C      (working copy)
@@ -2077,7 +2077,7 @@ void FormPreferences::OutputsMisc::apply
        rc.auto_reset_options = 
fl_get_button(dialog_->check_autoreset_classopt);
 
 #if defined(__CYGWIN__) || defined(__CYGWIN32__)
-       rc.cygwin_path_fix = fl_get_button(dialog_->check_cygwin_path);
+       rc.cygwin_path_fix = !fl_get_button(dialog_->check_cygwin_path);
 #endif
 }
 
@@ -2175,7 +2175,7 @@ void FormPreferences::OutputsMisc::updat
        fl_set_button(dialog_->check_autoreset_classopt,
                      rc.auto_reset_options);
 #if defined(__CYGWIN__) || defined(__CYGWIN32__)
-       fl_set_button(dialog_->check_cygwin_path, rc.cygwin_path_fix);
+       fl_set_button(dialog_->check_cygwin_path, !rc.cygwin_path_fix);
 #endif
 }
 

setup.png
Description: PNG image