On Tuesday 15 May 2007 21:38:02 Dov Feldstern wrote:
> The only thing (with turning RTL off again) is, as Darren (who already
> ran into the crash due to this) pointed out, how are we going to find
> out what problems there are with it if we don't leave it on? Wouldn't it
> be better to keep it in,
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Dov Feldstern wrote:
>> Again, if this doesn't go in, RTL should be turned off, because
>> that *will* cause crashes without this!
Abdelrazak> Jose, as far as I see this patch seems OK but I didn't
Abdelrazak> look at
Abdelrazak Younes wrote:
Dov Feldstern wrote:
Again, if this doesn't go in, RTL should be turned off, because that
*will* cause crashes without this!
Jose, as far as I see this patch seems OK but I didn't look at it very
closely nor tested it. JMarc will probably do a better job than me
revi
Dov Feldstern wrote:
Again, if this doesn't go in, RTL should be turned off, because that
*will* cause crashes without this!
Jose, as far as I see this patch seems OK but I didn't look at it very
closely nor tested it. JMarc will probably do a better job than me
reviewing it. If JMarc cannot
Dov Feldstern wrote:
Dov Feldstern wrote:
Dov Feldstern wrote:
Fixed. Everything seems to be working fine now. I would still
appreciate it if someone could review the whole patch carefully,
because this does affect general code (not just RTL).
Not everything: I just ran into a new crash whi
Dov Feldstern wrote:
Dov Feldstern wrote:
Fixed. Everything seems to be working fine now. I would still appreciate
it if someone could review the whole patch carefully, because this does
affect general code (not just RTL).
Not everything: I just ran into a new crash which was introduced by m
Dov Feldstern wrote:
Dov Feldstern wrote:
Abdelrazak Younes wrote:
One problem with the current patch --- it breaks the solutions we've
been working on for cursor movement --- exiting insets from the
beginning seems to be broken again --- either with or without my fix.
I'm sure it can be work
Abdelrazak Younes wrote:
Looks sensible.
Sorry Dov, I won't have time to work on this before the next beta.
Sure, thanks for letting me know, though. That'll give me a little time
to work out the kinks.
Abdel.
Dov Feldstern wrote:
Abdelrazak Younes wrote:
I had a crash while navigating with the right and left arrow keys with
the attached document.
The problem is that (pos - start_ = -1) in:
pos_type Bidi::level(pos_type pos) const
{
return (start_ == -1) ? 0 : levels_[pos - start_];
}
pos = 33
Dov Feldstern wrote:
Abdelrazak Younes wrote:
One problem with the current patch --- it breaks the solutions we've
been working on for cursor movement --- exiting insets from the
beginning seems to be broken again --- either with or without my fix.
I'm sure it can be worked out, but it'll requ
Abdelrazak Younes wrote:
I had a crash while navigating with the right and left arrow keys with
the attached document.
The problem is that (pos - start_ = -1) in:
pos_type Bidi::level(pos_type pos) const
{
return (start_ == -1) ? 0 : levels_[pos - start_];
}
pos = 33 and start_ = 34.
The
11 matches
Mail list logo
