Re: [patch] GuiSymbols

2008-02-07 Thread Abdelrazak Younes
José Matos wrote: On Sunday 03 February 2008 16:09:08 Jürgen Spitzmüller wrote: I've set up a symbols dialog for trunk. The dialog displays all characters that can be used in the given encoding (at cursor position), including those from the unicodesymbols list. It's quite similar to the symbols

Re: [patch] GuiSymbols

2008-02-07 Thread José Matos
On Sunday 03 February 2008 16:09:08 Jürgen Spitzmüller wrote: > I've set up a symbols dialog for trunk. The dialog displays all characters > that can be used in the given encoding (at cursor position), including > those from the unicodesymbols list. It's quite similar to the symbols > dialogs you k

Re: [patch] GuiSymbols

2008-02-07 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: You should have used QChar::category(c) instead of QChar(c).category(). I'll fix that and commit it with my other cleanup if you don't mind. yes, go ahead. I've done that but it seems that there are some bugs with Dialog::checkStatus(). The

Re: [patch] GuiSymbols

2008-02-07 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > You should have used QChar::category(c) instead of QChar(c).category(). > I'll fix that and commit it with my other cleanup if you don't mind. yes, go ahead. Jürgen

Re: [patch] GuiSymbols

2008-02-07 Thread Abdelrazak Younes
Abdelrazak Younes wrote: You should have used QChar::category(c) instead of QChar(c).category(). I'll fix that and commit it with my other cleanup if you don't mind. Hum, you also did not take into account potential ucs4 characters, I corrected that too. Abdel.

Re: [patch] GuiSymbols

2008-02-07 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: I've done that now. Please have a look at it, you will see that you'll need less code and you'll have a more powerful dialog. I've done that, but I found it rather clumsy (probably because it didn't fully understand it). For instance, the but

Re: [patch] GuiSymbols

2008-02-07 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: I see that you insisted on implementing initialiseParams() and clearParams(), that's why. You are still 'tainted' by the serialization way ;-) How would the new approach look? Something like this (untested yet). Abdel. Index: GuiSymbols.cpp

Re: [patch] GuiSymbols

2008-02-07 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: I see that you insisted on implementing initialiseParams() and clearParams(), that's why. You are still 'tainted' by the serialization way ;-) How would the new approach look? I am working on it. Abdel.

Re: [patch] GuiSymbols

2008-02-07 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > I see that you insisted on implementing initialiseParams() and > clearParams(), that's why. You are still 'tainted' by the serialization > way ;-) How would the new approach look? Jürgen

Re: [patch] GuiSymbols

2008-02-07 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Right, but in this case I think the whole dialog should be disabled instead. No. The dialog can also be used as a ressource of information (about what symbols are available), which should be possible in a read-only document (same applies to

Re: [patch] GuiSymbols

2008-02-07 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > Right, but in this case I think the whole dialog should be disabled > instead. No. The dialog can also be used as a ressource of information (about what symbols are available), which should be possible in a read-only document (same applies to the paragraph dialog) Jür

Re: [patch] GuiSymbols

2008-02-07 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: I've done that now. Please have a look at it, you will see that you'll need less code and you'll have a more powerful dialog. I've done that, but I found it rather clumsy (probably because it didn't fully understand it). I see that you insi

Re: [patch] GuiSymbols

2008-02-07 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > I've done that now. Please have a look at it, you will see that you'll > need less code and you'll have a more powerful dialog. I've done that, but I found it rather clumsy (probably because it didn't fully understand it). For instance, the button enabling has to be imp

Re: [patch] GuiSymbols

2008-02-05 Thread Darren Freeman
On Sun, 2008-02-03 at 17:09 +0100, Jürgen Spitzmüller wrote: > from the unicodesymbols list. It's quite similar to the symbols dialogs you > know from the word processors (screenshot attached). > Comments welcome. Wow, you use LyX in black and white? I should send you a new video card and monit

Re: [patch] GuiSymbols

2008-02-04 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Jürgen Spitzmüller wrote: I've set up a symbols dialog for trunk. The dialog displays all characters that can be used in the given encoding (at cursor position), including those from the unicodesymbols list. It's quite similar to the symbols dialogs you know from the w

Re: [patch] GuiSymbols

2008-02-04 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: I've set up a symbols dialog for trunk. The dialog displays all characters that can be used in the given encoding (at cursor position), including those from the unicodesymbols list. It's quite similar to the symbols dialogs you know from the word processors (screenshot

[patch] GuiSymbols

2008-02-04 Thread Jürgen Spitzmüller
I've set up a symbols dialog for trunk. The dialog displays all characters that can be used in the given encoding (at cursor position), including those from the unicodesymbols list. It's quite similar to the symbols dialogs you know from the word processors (screenshot attached). One thing whic