Jürgen Spitzmüller wrote:
Abdelrazak Younes wrote:
I've done that now. Please have a look at it, you will see that you'll
need less code and you'll have a more powerful dialog.
I've done that, but I found it rather clumsy (probably because it didn't fully
understand it). For instance, the button enabling has to be implemented
manually in each dialog, right? I really miss the button controller
organization. BTW, the paragraph dialog fails at button controlling: the
buttons are not disabled in a read-only document (I've implemented that
manually in the Symbols dialog, and actually got more code than with the old
scheme).
Anyway, the thing is in.
It does not compile here:
GuiSymbols.cpp
..\..\..\..\..\src\frontends\qt4\GuiSymbols.cpp(255) : error C2440:
'<function-style-cast>' : cannot convert from 'lyx::char_type' to 'QChar'
No constructor could take the source type, or constructor
overload resolution was ambiguous
..\..\..\..\..\src\frontends\qt4\GuiSymbols.cpp(255) : error C2228: left
of '.category' must have class/struct/union
..\..\..\..\..\src\frontends\qt4\GuiSymbols.cpp(256) : error C2440:
'<function-style-cast>' : cannot convert from 'lyx::char_type' to 'QChar'
No constructor could take the source type, or constructor
overload resolution was ambiguous
..\..\..\..\..\src\frontends\qt4\GuiSymbols.cpp(256) : error C2228: left
of '.category' must have class/struct/union
..\..\..\..\..\src\frontends\qt4\GuiSymbols.cpp(258) : error C2440:
'<function-style-cast>' : cannot convert from 'lyx::char_type' to 'QChar'
You should have used QChar::category(c) instead of QChar(c).category().
I'll fix that and commit it with my other cleanup if you don't mind.
Abdel.
