Jürgen Spitzmüller wrote:
I've set up a symbols dialog for trunk. The dialog displays all characters
that can be used in the given encoding (at cursor position), including those
from the unicodesymbols list. It's quite similar to the symbols dialogs you
know from the word processors (screenshot attached).
This looks Jurgen but I have some questions/remark:
1) For new dialog we should move away from the old design using the
serialization and the button controller, i.e GuiDialog. You'd do me (and
you) a favor if you just base it on DialogView instead. I know that it
is only used by GuiParagraph for now (and badly at that) but the
resulting code and flexibility should be better. I'll cleanup
GuiParagraph so that it gives a proper show case.
2) Related to the above point, your design depends on the cursor
position at the time the dialog is launched whereas it should be
dependent on the _current_ cursor location. This is done like this in
the paragraph dialog.
One thing which is rather clumsy is the implementation of the "categories"
(i.e. Unicode blocks). Unfortunately, Qt does not provide very much
information on the unicode categorization of a given char. So I had to set up
a table with the unicode blocks.
Those are not going to change so this is OK I guess.
Abdel.
