Re: [patch] Cygwin polishing

2006-04-03 Thread Enrico Forestieri
On Mon, Apr 03, 2006 at 11:11:40AM +0200, Jean-Marc Lasgouttes wrote: > > "Enrico" == Enrico Forestieri <[EMAIL PROTECTED]> writes: > > Enrico> Moreover, nuking the checkbox maybe be seen as a regression... > > Nuking a checkbox is not a regression per se. Adding a pref just > because we can

Re: [patch] Cygwin polishing

2006-04-03 Thread Jean-Marc Lasgouttes
> "Enrico" == Enrico Forestieri <[EMAIL PROTECTED]> writes: Enrico> Moreover, nuking the checkbox maybe be seen as a regression... Nuking a checkbox is not a regression per se. Adding a pref just because we can't make up our mind is bad. Considering that cygwin users who want such or such kin

Re: [patch] Cygwin polishing

2006-04-03 Thread Jean-Marc Lasgouttes
> "Enrico" == Enrico Forestieri <[EMAIL PROTECTED]> writes: Enrico> Don't get me wrong. I think that he did a superb job. I was Enrico> talking about the cygwin target. My impression is that it does Enrico> not received sufficient attention and my fear was that it was Enrico> going down the si

Re: [patch] Cygwin polishing

2006-04-03 Thread Enrico Forestieri
On Sun, Apr 02, 2006 at 10:07:54PM +0200, Georg Baum wrote: > Am Sonntag, 2. April 2006 17:26 schrieb Enrico Forestieri: > > Well, I think that I cannot hardcode a format in external_path as > > this would be a regression. > > The fixes should go to 1.5svn first, and IMO it is acceptable if 1.5sv

Re: [patch] Cygwin polishing

2006-04-03 Thread Enrico Forestieri
On Sun, Apr 02, 2006 at 07:45:39PM +0200, Abdelrazak Younes wrote: > Enrico Forestieri a écrit : > > On Sun, Apr 02, 2006 at 07:02:08PM +0200, Abdelrazak Younes wrote: > > > >> Enrico Forestieri a écrit : > >>> On Sun, Apr 02, 2006 at 06:16:34PM +0200, Abdelrazak Younes wrote: > >> [...] > >> > >

Re: [patch] Cygwin polishing

2006-04-02 Thread Georg Baum
Am Sonntag, 2. April 2006 17:26 schrieb Enrico Forestieri: > Well, I think that I cannot hardcode a format in external_path as > this would be a regression. The fixes should go to 1.5svn first, and IMO it is acceptable if 1.5svn is temporarily broken in that aspect, so I would not care about that

Re: [patch] Cygwin polishing

2006-04-02 Thread Abdelrazak Younes
Enrico Forestieri a écrit : On Sun, Apr 02, 2006 at 07:02:08PM +0200, Abdelrazak Younes wrote: Enrico Forestieri a écrit : On Sun, Apr 02, 2006 at 06:16:34PM +0200, Abdelrazak Younes wrote: [...] It always contains paths with forward slashes, but according to the logic currently used, an ab

Re: [patch] Cygwin polishing

2006-04-02 Thread Enrico Forestieri
On Sun, Apr 02, 2006 at 07:02:08PM +0200, Abdelrazak Younes wrote: > Enrico Forestieri a écrit : > > On Sun, Apr 02, 2006 at 06:16:34PM +0200, Abdelrazak Younes wrote: > [...] > > > It always contains paths with forward slashes, but according to > > the logic currently used, an absolute path may

Re: [patch] Cygwin polishing

2006-04-02 Thread Abdelrazak Younes
Enrico Forestieri a écrit : On Sun, Apr 02, 2006 at 06:16:34PM +0200, Abdelrazak Younes wrote: [...] It always contains paths with forward slashes, but according to the logic currently used, an absolute path may appear in the .lyx file. In the win32 version this is in a C:/xxx path style, wher

Re: [patch] Cygwin polishing

2006-04-02 Thread Enrico Forestieri
On Sun, Apr 02, 2006 at 06:16:34PM +0200, Abdelrazak Younes wrote: > Enrico Forestieri a écrit : > > On Sun, Apr 02, 2006 at 01:11:50PM +0200, Georg Baum wrote: > >> - Implicit format change of .lyx files. I know that there are currently > >> problems in this area due to the mixup, but for the fu

Re: [patch] Cygwin polishing

2006-04-02 Thread Enrico Forestieri
On Sun, Apr 02, 2006 at 05:26:37PM +0200, Enrico Forestieri wrote: > Come on, Georg, there are many choices by the configure script > that cannot be undone by the user! Think about dvipng which once > detected dictates the instant-preview image formats, and if it > doesn't work correctly (how alre

Re: [patch] Cygwin polishing

2006-04-02 Thread Abdelrazak Younes
Enrico Forestieri a écrit : On Sun, Apr 02, 2006 at 01:11:50PM +0200, Georg Baum wrote: - Implicit format change of .lyx files. I know that there are currently problems in this area due to the mixup, but for the future I would like to have only one representation of file names in .lyx files for

Re: [patch] Cygwin polishing

2006-04-02 Thread Enrico Forestieri
On Sun, Apr 02, 2006 at 01:11:50PM +0200, Georg Baum wrote: > Am Samstag, 1. April 2006 18:48 schrieb Enrico Forestieri: > > On Sat, Apr 01, 2006 at 05:44:55PM +0200, Georg Baum wrote: > > > Let us please postpone the user visible paths for now, and first get > > > the > > > internal representat

Re: [patch] Cygwin polishing

2006-04-02 Thread Michael Gerz
Enrico Forestieri wrote: Michael, the point is that I think a cygwin version of LyX is potentially better than a native version. This is my opinion and I do not want to convince anybody of it. You should understand that there may be someone who doesn't like what you like and viceversa ;-) I

Re: [patch] Cygwin polishing

2006-04-02 Thread Georg Baum
Am Samstag, 1. April 2006 18:48 schrieb Enrico Forestieri: > On Sat, Apr 01, 2006 at 05:44:55PM +0200, Georg Baum wrote: > > Let us please postpone the user visible paths for now, and first get the > > internal representation right. Pretty please!!! > In the actual implementation external_path

Re: [patch] Cygwin polishing

2006-04-01 Thread Enrico Forestieri
On Sat, Apr 01, 2006 at 05:44:55PM +0200, Georg Baum wrote: > Am Samstag, 1. April 2006 16:37 schrieb Enrico Forestieri: > > This is exactly what my patch does. I do not agree about the > > confusion. > > Here I meant confusion for programmers, not users. It simply does not make > sense to make

Re: [patch] Cygwin polishing

2006-04-01 Thread Georg Baum
Am Samstag, 1. April 2006 16:37 schrieb Enrico Forestieri: > On Sat, Apr 01, 2006 at 01:24:00PM +0200, Georg Baum wrote: > > > Am Freitag, 31. März 2006 15:21 schrieb Enrico Forestieri: > > > > I do not understand why os::internal_path can return paths like C:/xxx > > > in the win32 version and

Re: [patch] Cygwin polishing

2006-04-01 Thread Enrico Forestieri
On Sat, Apr 01, 2006 at 01:24:00PM +0200, Georg Baum wrote: > Am Freitag, 31. März 2006 15:21 schrieb Enrico Forestieri: > > I do not understand why os::internal_path can return paths like C:/xxx > > in the win32 version and cannot for the cygwin version. Note that the > > test for an absolute pa

Re: [patch] Cygwin polishing

2006-04-01 Thread Georg Baum
Am Freitag, 31. März 2006 15:21 schrieb Enrico Forestieri: > On Fri, Mar 31, 2006 at 01:59:09PM +0200, Georg Baum wrote: > > Enrico Forestieri wrote: > > > > However, you could also use other native apps apart from miktex, so it > > > is useful that both 1) and 2) return either posix- or win-styl

Re: [patch] Cygwin polishing

2006-03-31 Thread Enrico Forestieri
On Fri, Mar 31, 2006 at 08:05:10PM +0200, Michael Gerz wrote: > Just my two cents: > > I agree with Jean-Marc that we should keep things simple. We don't have > to support each and every conceivable configuration. If we manage to > provide the Windows world with a working LyX - no matter how -

Re: [patch] Cygwin polishing

2006-03-31 Thread Michael Gerz
Jean-Marc Lasgouttes wrote: Enrico> cygwin-without-cygwin? what's that? ;-) Isn't the point of this thread to support compiling with cygwin -mnocygwin and (perhaps separately, I am not sure anymore) to have a binary that can either be cygwin-based or not depending on the phase of the moon? It m

Re: 'Re: [patch] Cygwin polishing' - MARC

2006-03-31 Thread Enrico Forestieri
On Fri, Mar 31, 2006 at 09:53:45AM -0800, Stephen Harris wrote: > http://marc.theaimsgroup.com/?l=lyx-devel&m=114381524012218&w=2 > > Enrico wrote: > Why miktex is outputting non-text characters is beyond me, though. > > --- > > http://groups.google.com/group/comp.editors/browse_thread/t

'Re: [patch] Cygwin polishing' - MARC

2006-03-31 Thread Stephen Harris
http://marc.theaimsgroup.com/?l=lyx-devel&m=114381524012218&w=2 Enrico wrote: Why miktex is outputting non-text characters is beyond me, though. --- http://groups.google.com/group/comp.editors/browse_thread/thread/1b8a2d71bce3eb33 /99fc8b9a55bf799f?lnk=st&q=%22%5EM%22++EOL&rnum=1&hl=en#

Re: [patch] Cygwin polishing

2006-03-31 Thread Enrico Forestieri
On Thu, Mar 30, 2006 at 10:23:38PM +0200, Enrico Forestieri wrote: > For example, while testing I just got this assertion from boost: > > assertion "src.size() == std::strlen( src.c_str() )" failed: file > "../../../../../boost/libs/filesystem/src/path_posix_windows.cpp", line 235 > > I don't g

Re: [patch] Cygwin polishing

2006-03-31 Thread Jean-Marc Lasgouttes
> "Enrico" == Enrico Forestieri <[EMAIL PROTECTED]> writes: Enrico> Ok, let's take a more pragmatic approach. I am going to post a Enrico> patch #1 which simply solves the two problems above. I would Enrico> like them fixed in 1.4.1 such that the binary I'll made Enrico> available will not be

Re: [patch] Cygwin polishing

2006-03-31 Thread Enrico Forestieri
On Fri, Mar 31, 2006 at 02:33:08PM +0200, Georg Baum wrote: > Enrico Forestieri wrote: > > > I think that it is better to proceed step by step. Is it okay with you > > if I start from scratch and do the minimum necessary to fix real bugs? > > You don't need to start from scratch, since you solved

Re: [patch] Cygwin polishing

2006-03-31 Thread Enrico Forestieri
On Fri, Mar 31, 2006 at 02:11:25PM +0200, Jean-Marc Lasgouttes wrote: > > "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: > > >> However, you could also use other native apps apart from miktex, so > >> it is useful that both 1) and 2) return either posix- or win-style > >> paths. This is to

Re: [patch] Cygwin polishing

2006-03-31 Thread Enrico Forestieri
On Fri, Mar 31, 2006 at 01:59:09PM +0200, Georg Baum wrote: > Enrico Forestieri wrote: > > However, you could also use other native apps apart from miktex, so it > > is useful that both 1) and 2) return either posix- or win-style paths. > > This is to be independent from the cygwin_path_fix switch

Re: [patch] Cygwin polishing

2006-03-31 Thread Georg Baum
Enrico Forestieri wrote: > I think that it is better to proceed step by step. Is it okay with you > if I start from scratch and do the minimum necessary to fix real bugs? You don't need to start from scratch, since you solved a lot of probelsm already. I like the step by step approach, and would

Re: [patch] Cygwin polishing

2006-03-31 Thread Enrico Forestieri
On Fri, Mar 31, 2006 at 12:34:36PM +0200, Jean-Marc Lasgouttes wrote: > > "Enrico" == Enrico Forestieri <[EMAIL PROTECTED]> writes: > > Enrico> I beg your pardon, next time I'll check more closely > Enrico> quotations. > > No problem, I would be more useful if I actually manage to understand

Re: [patch] Cygwin polishing

2006-03-31 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: >> However, you could also use other native apps apart from miktex, so >> it is useful that both 1) and 2) return either posix- or win-style >> paths. This is to be independent from the cygwin_path_fix switch >> and in my patch it is done thr

Re: [patch] Cygwin polishing

2006-03-31 Thread Georg Baum
Enrico Forestieri wrote: > In Windows one could use miktex or tetex (by cygwin). But, as things > stand now, tetex cannot be used because, for reasons not known to me, > it gives an error when a path like "C:/xxx" is output to a .tex file. > I think that it is related to the fact that a check for

Re: [patch] Cygwin polishing

2006-03-31 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : "Enrico" == Enrico Forestieri <[EMAIL PROTECTED]> writes: Enrico> cygwin-without-cygwin? what's that? ;-) Isn't the point of this thread to support compiling with cygwin -mnocygwin and (perhaps separately, I am not sure anymore) to have a binary that can either

Re: [patch] Cygwin polishing

2006-03-31 Thread Jean-Marc Lasgouttes
> "Enrico" == Enrico Forestieri <[EMAIL PROTECTED]> writes: Enrico> I beg your pardon, next time I'll check more closely Enrico> quotations. No problem, I would be more useful if I actually manage to understand how cygwin stuff should work. JMarc

Re: [patch] Cygwin polishing

2006-03-31 Thread Enrico Forestieri
On Fri, Mar 31, 2006 at 12:10:14PM +0200, Jean-Marc Lasgouttes wrote: > > "Enrico" == Enrico Forestieri <[EMAIL PROTECTED]> writes: > > Enrico> cygwin-without-cygwin? what's that? ;-) > >> Isn't the point of this thread to support compiling with cygwin > >> -mnocygwin and (perhaps separately,

Re: [patch] Cygwin polishing

2006-03-31 Thread Jean-Marc Lasgouttes
> "Enrico" == Enrico Forestieri <[EMAIL PROTECTED]> writes: Enrico> cygwin-without-cygwin? what's that? ;-) >> Isn't the point of this thread to support compiling with cygwin >> -mnocygwin and (perhaps separately, I am not sure anymore) to have >> a binary that can either be cygwin-based or n

Re: [patch] Cygwin polishing

2006-03-31 Thread Enrico Forestieri
On Fri, Mar 31, 2006 at 10:59:18AM +0200, Jean-Marc Lasgouttes wrote: > > "Enrico" == Enrico Forestieri <[EMAIL PROTECTED]> writes: > > Enrico> On Thu, Mar 30, 2006 at 06:39:39PM +0200, Jean-Marc Lasgouttes > Enrico> wrote: > >> I think this cygwin-without-cygwin stuff is becoming stranger and

Re: [patch] Cygwin polishing

2006-03-31 Thread Jean-Marc Lasgouttes
> "Enrico" == Enrico Forestieri <[EMAIL PROTECTED]> writes: Enrico> On Thu, Mar 30, 2006 at 06:39:39PM +0200, Jean-Marc Lasgouttes Enrico> wrote: >> I think this cygwin-without-cygwin stuff is becoming stranger and >> stranger. Enrico> cygwin-without-cygwin? what's that? ;-) Isn't the point

Re: [patch] Cygwin polishing

2006-03-30 Thread Enrico Forestieri
On Thu, Mar 30, 2006 at 10:21:53PM +0200, Georg Baum wrote: > Am Mittwoch, 29. März 2006 20:49 schrieb Enrico Forestieri: > > > I have reorganized things in this way: > > 1) The kind of path style to be written into .tex files is only > >    decided by the configure script which checks what the co

Re: [patch] Cygwin polishing

2006-03-30 Thread Enrico Forestieri
On Thu, Mar 30, 2006 at 05:44:17PM +0200, Abdelrazak Younes wrote: > I am using TortoiseSVN which has a very good GUI that can show visual > comparison between revisions or even 3-way comparisons. With this GUI > you can reject a change, revert to an older version, etc. I definitely > prefer th

Re: [patch] Cygwin polishing

2006-03-30 Thread Enrico Forestieri
On Thu, Mar 30, 2006 at 05:01:52PM +0200, Jean-Marc Lasgouttes wrote: > > "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > Abdelrazak> Message to the main lyx developers: > > Abdelrazak> IMHO, if you want to encourage new contributions, you > Abdelrazak> should relax a bit th

Re: [patch] Cygwin polishing

2006-03-30 Thread Enrico Forestieri
On Thu, Mar 30, 2006 at 06:39:39PM +0200, Jean-Marc Lasgouttes wrote: > I think this cygwin-without-cygwin stuff is becoming stranger and > stranger. cygwin-without-cygwin? what's that? ;-) -- Enrico

Re: [patch] Cygwin polishing

2006-03-30 Thread Enrico Forestieri
On Thu, Mar 30, 2006 at 05:33:31PM +0200, Georg Baum wrote: > I did not yet have time to comment on Enricos patch, I just had a quick look > and the cygwin ifdefs he introduced in frontends/qt2/FileDialog.C don't > seem right. If they are really needed (which I doubt currently, but that > may chan

Re: [patch] Cygwin polishing

2006-03-30 Thread Georg Baum
Am Donnerstag, 30. März 2006 18:39 schrieb Jean-Marc Lasgouttes: > I think this cygwin-without-cygwin stuff is becoming stranger and > stranger. Indeed. We should keep this as simple as possible. IMO a cygwin ignorant person (such as me) should be able to understand the code without even touchin

Re: [patch] Cygwin polishing

2006-03-30 Thread Enrico Forestieri
On Thu, Mar 30, 2006 at 03:56:02PM +0200, Abdelrazak Younes wrote: > Just for confirmation, is /cygdrive is present on any cygwin installation? > But in the special case where a user has a c:\cygdrive and lyx is > installed on the same drive, this test doesn't work (I just made the > test). Is t

Re: [patch] Cygwin polishing

2006-03-30 Thread Georg Baum
Am Mittwoch, 29. März 2006 20:49 schrieb Enrico Forestieri: > I have reorganized things in this way: > 1) The kind of path style to be written into .tex files is only >    decided by the configure script which checks what the correct >    style is (miktex vs cygwin tetex). > 2) The "Use Cygwin-sty

Re: [patch] Cygwin polishing

2006-03-30 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: I don't understand what is wrong with an #ifdef? I personally prefer always compiletime checks rather than runtime checks if it is possible. Why do a hackish runtime test if the same thing can be achie

Re: [patch] Cygwin polishing

2006-03-30 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> I don't understand what is wrong with an #ifdef? I personally >> prefer always compiletime checks rather than runtime checks if it >> is possible. Why do a hackish runtime test if the same thing can be >> achieved at compile ti

Re: [patch] Cygwin polishing

2006-03-30 Thread Abdelrazak Younes
Georg Baum a écrit : Abdelrazak Younes wrote: Abdelrazak Younes a écrit : #include bool isCygwin() { return access("/cygdrive", F_OK) == 0; } Just for confirmation, is /cygdrive is present on any cygwin installation? But in the special case where a user has a c:\cygdrive and lyx is inst

Re: [patch] Cygwin polishing

2006-03-30 Thread Abdelrazak Younes
Jean-Marc Lasgouttes a écrit : "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Message to the main lyx developers: Abdelrazak> IMHO, if you want to encourage new contributions, you Abdelrazak> should relax a bit the implicit process of reviewing for Abdelrazak> trunk.

Re: [patch] Cygwin polishing

2006-03-30 Thread Georg Baum
Abdelrazak Younes wrote: > Abdelrazak Younes a écrit : >> #include >> >> bool isCygwin() >> { >> return access("/cygdrive", F_OK) == 0; >> } >> >> Just for confirmation, is /cygdrive is present on any cygwin >> installation? But in the special case where a user has a c:\cygdrive and >> lyx

Re: [patch] Cygwin polishing

2006-03-30 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Message to the main lyx developers: Abdelrazak> IMHO, if you want to encourage new contributions, you Abdelrazak> should relax a bit the implicit process of reviewing for Abdelrazak> trunk. I think that external devel

Re: [patch] Cygwin polishing

2006-03-30 Thread Abdelrazak Younes
Abdelrazak Younes a écrit : #include bool isCygwin() { return access("/cygdrive", F_OK) == 0; } Just for confirmation, is /cygdrive is present on any cygwin installation? But in the special case where a user has a c:\cygdrive and lyx is installed on the same drive, this test doesn't work

Re: [patch] Cygwin polishing

2006-03-30 Thread Abdelrazak Younes
Enrico Forestieri a écrit : [...] So, I agree with you that a part of the fix can also be applied to the plain win32 target, but I do not think that we can avoid all the "#ifdef __CYGWIN__" switches. Maybe not all but any which can be deleted is good. Is there a simple way to check at runtime if

Re: [patch] Cygwin polishing

2006-03-30 Thread Enrico Forestieri
On Thu, Mar 30, 2006 at 01:16:56PM +0200, Abdelrazak Younes wrote: > Enrico Forestieri a écrit : > >That indeed would be great, but I think that the cygwin target has > >some peculiarities not easily mimicked by a native build. > > IMHO, no need to mimic anything, he who want a cygwin functionali

Re: [patch] Cygwin polishing

2006-03-30 Thread Abdelrazak Younes
Enrico Forestieri a écrit : On Thu, Mar 30, 2006 at 11:01:29AM +0200, Abdelrazak Younes wrote: Enrico Forestieri a écrit : I have reviewed all (I think) possible problems related to paths in cygwin. The attached is the patch I come up with. I hope that it can be applied for 1.4.1 as it doesn't

Re: [patch] Cygwin polishing

2006-03-30 Thread Enrico Forestieri
On Thu, Mar 30, 2006 at 11:01:29AM +0200, Abdelrazak Younes wrote: > Enrico Forestieri a écrit : > >I have reviewed all (I think) possible problems related to paths in > >cygwin. The attached is the patch I come up with. I hope that it can > >be applied for 1.4.1 as it doesn't harm the other target

Re: [patch] Cygwin polishing

2006-03-30 Thread Abdelrazak Younes
Enrico Forestieri a écrit : I have reviewed all (I think) possible problems related to paths in cygwin. The attached is the patch I come up with. I hope that it can be applied for 1.4.1 as it doesn't harm the other targets and is really needed for cygwin. Hello Enrico, Having had a (quick) loo

[patch] Cygwin polishing

2006-03-29 Thread Enrico Forestieri
I have reviewed all (I think) possible problems related to paths in cygwin. The attached is the patch I come up with. I hope that it can be applied for 1.4.1 as it doesn't harm the other targets and is really needed for cygwin. I have reorganized things in this way: 1) The kind of path style to be