Re: [Updated PATCH] Transfer theCoords global variable to BufferView

2006-10-15 Thread Abdelrazak Younes
Andre Poenitz wrote: On Fri, Oct 13, 2006 at 05:06:42PM +0200, Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> OK, I got rid of the global pointer. All CoordCache access Abdelrazak> are done via BufferView::cordCache() now. I had to modify A

Re: [Updated PATCH] Transfer theCoords global variable to BufferView

2006-10-15 Thread Andre Poenitz
On Fri, Oct 13, 2006 at 05:06:42PM +0200, Jean-Marc Lasgouttes wrote: > > "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > Abdelrazak> OK, I got rid of the global pointer. All CoordCache access > Abdelrazak> are done via BufferView::cordCache() now. I had to modify > Abdelraza

Re: [Updated PATCH] Transfer theCoords global variable to BufferView

2006-10-15 Thread Andre Poenitz
On Fri, Oct 13, 2006 at 05:38:29PM +0200, Abdelrazak Younes wrote: > After a double check of the code this would also mean that we use Cursor > instead of DocIterator in LyXText::drawSelection(), bruteFind() and > bruteFind3(). AFAIK, Cursor iteration is slower than DocIterator > iteration, isn'

Re: [Updated PATCH] Transfer theCoords global variable to BufferView

2006-10-13 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> OK, I got rid of the global pointer. All CoordCache access Abdelrazak> are done via BufferView::cordCache() now. I had to modify Abdelrazak>

Re: [Updated PATCH] Transfer theCoords global variable to BufferView

2006-10-13 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> OK, I got rid of the global pointer. All CoordCache access Abdelrazak> are done via BufferView::cordCache() now. I had to modify Abdelrazak> a number of methods to pas

Re: [Updated PATCH] Transfer theCoords global variable to BufferView

2006-10-13 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> OK, I got rid of the global pointer. All CoordCache access Abdelrazak> are done via BufferView::cordCache() now. I had to modify Abdelrazak> a number of methods to pass BufferView but the resul

Re: [Updated PATCH] Transfer theCoords global variable to BufferView

2006-10-13 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> OK, I got rid of the global pointer. All CoordCache access Abdelrazak> are done via BufferView::cordCache() now. I had to modify Abdelrazak> a number of methods to pass BufferView but the result is Abdelrazak> better a

[Updated PATCH] Transfer theCoords global variable to BufferView

2006-10-13 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Hello, In order to support multiple LyXView each BufferView needs its own CoordCache. This is what's implemented in this patch. theCoords is now a global pointer instead of a global variable. It is set at each BufferView::updateMetrics() call. I am not very happy with