Andre Poenitz wrote:
On Fri, Oct 13, 2006 at 05:06:42PM +0200, Jean-Marc Lasgouttes wrote:
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> OK, I got rid of the global pointer. All CoordCache access
Abdelrazak> are done via BufferView::cordCache() now. I had to modify
Abdelrazak> a number of methods to pass BufferView but the result is
Abdelrazak> better as agreed with JMarc.
Abdelrazak> This is going in soon.
It looks good, except maybe this:
- Point const p = bv_funcs::getPos(cursor_, cursor_.boundary());
+ Point const p = bv_funcs::getPos(*this, cursor_,
cursor_.boundary());
It looks like bv_funcs::getPos should take a cursor as argument
instead of a DocIterator. This would avoid passing an extra
bufferview.
I'd really like to separate view (bv) and model (dociterator) related
data.
Put that in your TODO list for Denmark ;-)
[And I know I lumped them together in Cursor myself...]
One cannot be perfect all the time ;-)
Abdel.
