Abdelrazak Younes wrote:
Abdelrazak Younes wrote:
Jean-Marc Lasgouttes wrote:
"Abdelrazak" == Abdelrazak Younes
<[EMAIL PROTECTED]> writes:
Abdelrazak> OK, I got rid of the global pointer. All CoordCache access
Abdelrazak> are done via BufferView::cordCache() now. I had to modify
Abdelrazak> a number of methods to pass BufferView but the result is
Abdelrazak> better as agreed with JMarc.
Abdelrazak> This is going in soon.
It looks good, except maybe this:
- Point const p = bv_funcs::getPos(cursor_, cursor_.boundary());
+ Point const p = bv_funcs::getPos(*this, cursor_,
cursor_.boundary());
It looks like bv_funcs::getPos should take a cursor as argument
instead of a DocIterator. This would avoid passing an extra
bufferview.
Year, I thought about this but decided to pass BufferView instead. Do
you remember the discussion with Andre that Cursor should probably not
be the gateway to everything?
Passing BufferView to a bv_funcs seems natural to me. But I don't have
a strong opinion about that so if you really insist I will do the change.
I will commit my patch now and will modify the getPos() method once we
agree on something. I hope you don't mind.
Abdel.
