Re: [Patch] Use global clipboard and delete BufferView::repaintAll() methods

2006-07-15 Thread Martin Vermeer
On Mon, Jul 03, 2006 at 02:27:57PM +0200, Abdelrazak Younes wrote: > Hello, > > This patch continue the BufferView cleanup series. There are only two > changes in this patch. See Lars? I am improving ;-) ... > Second, it deletes the delete "BufferView::repaintAll()" methods. These > methods

Re: [Patch] Use global clipboard and delete BufferView::repaintAll() methods

2006-07-06 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | > My plan was to do this merge yeasterday, but real life intervened. | > | | You should have started with this instead of merging the most | > recent patch. | > Why? | > The recent path was

Re: [Patch] Use global clipboard and delete BufferView::repaintAll() methods

2006-07-06 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | OK, I'll let you handle that then. FYI, my next cleanup target is the | boost signal "LyXView::view_state_changed()". This should be deleted. Ok. -- Lgb

Re: [Patch] Use global clipboard and delete BufferView::repaintAll() methods

2006-07-06 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | > My plan was to do this merge yeasterday, but real life intervened. | > | | You should have started with this instead of merging the most | > recent patch. | > Why? | > The recent path was ortogonal to the first. |

Re: [Patch] Use global clipboard and delete BufferView::repaintAll() methods

2006-07-06 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | > My plan was to do this merge yeasterday, but real life intervened. | > | | You should have started with this instead of merging the most | > recent patch. | > Why? | > The recent path was ortogonal to the first. | | Because I have to do a lot

Re: [Patch] Use global clipboard and delete BufferView::repaintAll() methods

2006-07-06 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | This needsredraw() function is right now necessary because the | BufferView::update() method is used all other the place. But the plan | is to remove the needRedraw() method. Ok... so the need to redraw of not will even

Re: [Patch] Use global clipboard and delete BufferView::repaintAll() methods

2006-07-06 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | This needsredraw() function is right now necessary because the | BufferView::update() method is used all other the place. But the plan | is to remove the needRedraw() method. Ok... so the need to redraw of not will eventually be done through a func

Re: [Patch] Use global clipboard and delete BufferView::repaintAll() methods

2006-07-06 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Abdelrazak Younes wrote: | > Lars Gullik Bjønnes wrote: | >> Abdelrazak Younes <[EMAIL PROTECTED]> writes: | >> | >> | Abdelrazak Younes wrote: | >> | > I will commit this to the younes branch as I don't have to do a | >>

Re: [Patch] Use global clipboard and delete BufferView::repaintAll() methods

2006-07-06 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Abdelrazak Younes wrote: | > Lars Gullik Bjønnes wrote: | >> Abdelrazak Younes <[EMAIL PROTECTED]> writes: | >> | >> | Abdelrazak Younes wrote: | >> | > I will commit this to the younes branch as I don't have to do a | >> | > merge to | >> | | as I d

Re: [Patch] Use global clipboard and delete BufferView::repaintAll() methods

2006-07-05 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Abdelrazak Younes wrote: | > I will commit this to the younes branch as I don't have to do a | > merge to | | as I don't have _the_ _time_ to do a merge now ... I split it and merged it. Thank

Re: [Patch] Use global clipboard and delete BufferView::repaintAll() methods

2006-07-05 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Abdelrazak Younes wrote: | > I will commit this to the younes branch as I don't have to do a | > merge to | | as I don't have _the_ _time_ to do a merge now ... I split it and merged it. Thanks but you only merged my

Re: [Patch] Use global clipboard and delete BufferView::repaintAll() methods

2006-07-03 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Abdelrazak Younes wrote: | > I will commit this to the younes branch as I don't have to do a | > merge to | | as I don't have _the_ _time_ to do a merge now ... I split it and merged it. -- Lgb

Re: [Patch] Use global clipboard and delete BufferView::repaintAll() methods

2006-07-03 Thread Abdelrazak Younes
Abdelrazak Younes wrote: I will commit this to the younes branch as I don't have to do a merge to as I don't have _the_ _time_ to do a merge now ... Bye, Abdel.

[Patch] Use global clipboard and delete BufferView::repaintAll() methods

2006-07-03 Thread Abdelrazak Younes
Hello, This patch continue the BufferView cleanup series. There are only two changes in this patch. See Lars? I am improving ;-) First it erase the clipboard methods from BufferView and change the code to use the global clipboard directly via the indirection "BufferView::owner()->gui().clipboa