On Mon, Jul 03, 2006 at 02:27:57PM +0200, Abdelrazak Younes wrote: > Hello, > > This patch continue the BufferView cleanup series. There are only two > changes in this patch. See Lars? I am improving ;-)
... > Second, it deletes the delete "BufferView::repaintAll()" methods. These > methods were used as a temporary variable inside rowpainter.C for > some recursive function. This temporary variable (refresh_inside_) was > never initialized and its value is always saved and restored for each > operation so it is _not_ BufferView dependant. > > This methods replace the use of the repaintAll() methods with the > variable refreshInside which is local to rowpainter.C. This rowpainter > code needs some cleanup. Hmmm. ... HMMMM. > * BufferView and Bufferview::pimpl: repaintAll() methods deleted. > > * rowpainter.C: > - refreshInside : new variable in the anonymous namespace. When I wrote this code I was in dubio whether to use a static here, but decided against because I expected it to be shot down as being "dirty". You're right, it is much cleaner this way. > - use of refreshInside instead of the repaintAll() methods > - Martin
