Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Abdelrazak Younes wrote:
| > Lars Gullik Bjønnes wrote:
| >> Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| >>
| >> | Abdelrazak Younes wrote:
| >> | > I will commit this to the younes branch as I don't have to do a
| >> | > merge to
| >> | | as I don't have _the_ _time_ to do a merge now ...
| >>
| >> I split it and merged it.
| > Thanks but you only merged my last patch... I will take care of the
| > rest.
|
| Which will be hard because I have many conflicts due to the partially
| applied patches.
|
| What did you left out from my tree exactly? "Only" the guiCursor deletion?
There are a couple of parts from it that I have not got to yet. The
move of the guicursor is one, and the 'needsredraw' (but I am not sure
I agree with this solution. Why should the bufferview keep a variable
that says that the drawing is dirty? Why not emit a signal, call a
function etc. To notify its the drawer. Then the drawer can choose to
wait or draw at once.) Move of drawing is the other.
Lars, together with the patch, you should read sometimes the SVN log and
the mail text accompanying the patch. But maybe I wasn't clear enough so
here is a new lengthy explanation:
The end goal is that BufferView forget about WorkArea and LyXView
_completely_. Right now this is not the case because of the two way
communication between the kernel (BufferView) and the frontend (WorkArea
and LyXView). I want WorkArea to use the associated BufferView instance,
no signal, no callback, just simple, well understandable function calls.
This needsredraw() function is right now necessary because the
BufferView::update() method is used all other the place. But the plan is
to remove the needRedraw() method.
Eventually, when the cleanup is done the command flow will be like this:
User press a key.
WorkArea::processKey(...) {
BufferView::processKey(...) {
...
BufferView::update(); // _no_ call to any LyXView method in there.
}
WorkArea::redraw();
}
Abdel.
My plan was to do this merge yeasterday, but real life intervened.
You should have started with this instead of merging the most recent patch.
Abdel.
