Re: [Patch] Kill FileInfo

2005-01-31 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > | H, I see it's gone in, but it looks to me like this patch has the > | potential to break Cygwin and Windows builds. > > Sure... unfortunately it seems that the only way to get (cyg)Win > people to comment on the patch is to check it in and wait for breakage > rep

Re: [Patch] Kill FileInfo

2005-01-31 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: >> | This patch kills all uses and replace it with calls to >> | boost.filesystem (+ a couple of new functions). >>> >> | Everything seems to work just fine to me... >>> >> | So unless I get unfavourable comments this goes in t

Re: [Patch] Kill FileInfo

2005-01-31 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > | This patch kills all uses and replace it with calls to > | boost.filesystem (+ a couple of new functions). >> > | Everything seems to work just fine to me... >> > | So unless I get unfavourable comments this goes in tomorrow evening. > > Updated it a bit. > > - got

Re: [Patch] Kill FileInfo

2005-01-30 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | Hmm... you are right... wronly will also return 1 .. and it should | return -1 I rewrote all callers of IsFileWriteable and removed the function completely. Besides I found a place where it was used wrong as well... -- Lgb

Re: [Patch] Kill FileInfo

2005-01-30 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | On Sun, Jan 30, 2005 at 10:48:56PM +0100, Lars Gullik Bj?nnes wrote: > >> This patch kills all uses and replace it with calls to >> boost.filesystem (+ a couple of new functions). > | int IsFileWriteable(string const & path) | { | - FileInfo fi(path

Re: [Patch] Kill FileInfo

2005-01-30 Thread John Levon
On Sun, Jan 30, 2005 at 10:48:56PM +0100, Lars Gullik Bj?nnes wrote: > This patch kills all uses and replace it with calls to > boost.filesystem (+ a couple of new functions). int IsFileWriteable(string const & path) { - FileInfo fi(path); - - if (fi.access(FileInfo::wperm|FileInfo: