Lars Gullik Bjønnes wrote: > | This patch kills all uses and replace it with calls to > | boost.filesystem (+ a couple of new functions). >> > | Everything seems to work just fine to me... >> > | So unless I get unfavourable comments this goes in tomorrow evening. > > Updated it a bit. > > - got rid of IsFileWriteable > - got rid of DeleteAllFilesInDir > - rewrote DirList
Hmmmm, I see it's gone in, but it looks to me like this patch has the potential to break Cygwin and Windows builds. You construct fs::path objects on the fly from the filename strings that we (LyX) store. That's fine on posix machines because we store all filenames as posix-like paths. Will things continue to work on Cygwin and on Windows? IMO you should ping Kayvan and ask him to test this stuff out on his Cygwin boxes. Who is using LyX 1.4.x in anger on a Windows box? Michael Schmitt? Perhaps you might drop him a line too. -- Angus
