Angus Leeming <[EMAIL PROTECTED]> writes:

| Lars Gullik Bjønnes wrote:
>> | This patch kills all uses and replace it with calls to
>> | boost.filesystem (+ a couple of new functions).
>>>
>> | Everything seems to work just fine to me...
>>>
>> | So unless I get unfavourable comments this goes in tomorrow evening.
>> 
>> Updated it a bit.
>> 
>> - got rid of IsFileWriteable
>> - got rid of DeleteAllFilesInDir
>> - rewrote DirList
>
| Hmmmm, I see it's gone in, but it looks to me like this patch has the 
| potential to break Cygwin and Windows builds. 

Sure... unfortunately it seems that the only way to get (cyg)Win
people to comment on the patch is to check it in and wait for breakage
reports.

| You construct fs::path objects on the fly from the filename strings that 
| we (LyX) store. That's fine on posix machines because we store all 
| filenames as posix-like paths.

There was no special handling in FileInfo for differences like this,
we just used what we got... should be the same now.

| Will things continue to work on Cygwin and 
| on Windows?

No. functions is fs_extras are not implemented for win.

Testing is not quite enought... we need some doer as well.

-- 
        Lgb

Reply via email to