Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-22 Thread Andre Poenitz
On Mon, Aug 21, 2006 at 12:34:20PM +0200, Lars Gullik Bjønnes wrote: > | Didn't you notice the hundred commits that got rid of QT3_SUPPORT? > > Sure did. > > But the argument put forward was that we don't have to do anything > since QT3_SUPPORT is a supported part of Qt4. The argument was: QT3_S

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-21 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | > | >>> Conclusion: this is not a valid objection. Besides Peter is | > | > | >>> committed to get rid of those compat methods. | > | > | >> Then let's convince Lars t

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-21 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | >>> Conclusion: this is not a valid objection. Besides Peter is | > | >>> committed to get rid of those compat methods. | > | >> Then let's convince Lars that this is not a showstopper :-) | > | > Trolltech considers

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-21 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | >>> Conclusion: this is not a valid objection. Besides Peter is | > | >>> committed to get rid of those compat methods. | > | >> Then let's convince Lars that this is not a showstopper :-) | > | > Trolltech considers the QT3 compat stuff as regul

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-21 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Andre Poenitz wrote: | > On Tue, Aug 15, 2006 at 11:06:16PM +0200, Michael Gerz wrote: | >> Abdel, | >> | I don't know the status regarding (1) - is there anything | missing? Are there any changes to qt3 that ha

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-20 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Andre Poenitz wrote: | > On Tue, Aug 15, 2006 at 11:06:16PM +0200, Michael Gerz wrote: | >> Abdel, | >> | I don't know the status regarding (1) - is there anything | missing? Are there any changes to qt3 that haven't been ported to | q

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-19 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> Survival of the fittest. And only the fittest... Abdelrazak> That's qt4 for now :-) You mean 'survival of the bulliest'? ;-) JMarc

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-19 Thread Abdelrazak Younes
Andre Poenitz wrote: On Tue, Aug 15, 2006 at 11:06:16PM +0200, Michael Gerz wrote: Abdel, I don't know the status regarding (1) - is there anything missing? Are there any changes to qt3 that haven't been ported to qt4? I think qt4 has now the same feature set as qt3 plus some more candy: And

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-19 Thread Abdelrazak Younes
Andre Poenitz wrote: On Wed, Aug 16, 2006 at 09:54:06AM +0200, Abdelrazak Younes wrote: Leuven, E. wrote: 5) Some new code needs to be ported from the qt3 frontend, look at the svn log: 5-a) I remember the QNote thing from Martin, he even sent a preliminar patch for qt4 but I did not have the

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-19 Thread Andre Poenitz
On Tue, Aug 15, 2006 at 11:06:16PM +0200, Michael Gerz wrote: > Abdel, > > >>I don't know the status regarding (1) - is there anything missing? Are > >>there any changes to qt3 that haven't been ported to qt4? > > >I think qt4 has now the same feature set as qt3 plus some more candy: > >And qt4

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-19 Thread Andre Poenitz
On Wed, Aug 16, 2006 at 09:54:06AM +0200, Abdelrazak Younes wrote: > Leuven, E. wrote: > >>> 5) Some new code needs to be ported from the qt3 frontend, look at > >>>the svn log: 5-a) I remember the QNote thing from Martin, he even sent > >>>a preliminar patch for qt4 but I did not have the time t

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-16 Thread Enrico Forestieri
On Wed, Aug 16, 2006 at 10:39:45AM +0200, Abdelrazak Younes wrote: > Enrico Forestieri wrote: > > On Wed, Aug 16, 2006 at 12:05:47AM +0200, Abdelrazak Younes wrote: > > > >> Michael Gerz wrote: > >> > 5-b) I remember some work from Georg and Enrico about some math > >> > symbols. I thing Georg

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-16 Thread Edwin Leuven
Abdelrazak Younes wrote: snapshot attached, and gonna commit unless people object Go ahead. it's in

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-16 Thread Abdelrazak Younes
Edwin Leuven wrote: Enrico Forestieri wrote: On Wed, Aug 16, 2006 at 12:05:47AM +0200, Abdelrazak Younes wrote: Michael Gerz wrote: > 5-b) I remember some work from Georg and Enrico about some math > symbols. I thing Georg put a FIXME in qt4 for that. Done by Edwin IIRC. Nope. The FIXME i

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-16 Thread Edwin Leuven
Enrico Forestieri wrote: On Wed, Aug 16, 2006 at 12:05:47AM +0200, Abdelrazak Younes wrote: Michael Gerz wrote: > 5-b) I remember some work from Georg and Enrico about some math > symbols. I thing Georg put a FIXME in qt4 for that. Done by Edwin IIRC. Nope. The FIXME is still there in QDel

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-16 Thread Abdelrazak Younes
Leuven, E. wrote: 5) Some new code needs to be ported from the qt3 frontend, look at the svn log: 5-a) I remember the QNote thing from Martin, he even sent a preliminar patch for qt4 but I did not have the time to look at it yet. Not sure this was done yet, Edwin, Martin? not by me, but we

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-16 Thread Abdelrazak Younes
Enrico Forestieri wrote: On Wed, Aug 16, 2006 at 12:05:47AM +0200, Abdelrazak Younes wrote: Michael Gerz wrote: > 5-b) I remember some work from Georg and Enrico about some math > symbols. I thing Georg put a FIXME in qt4 for that. Done by Edwin IIRC. Nope. The FIXME is still there in QDel

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-16 Thread Abdelrazak Younes
Leuven, E. wrote: 5) Some new code needs to be ported from the qt3 frontend, look at the svn log: 5-a) I remember the QNote thing from Martin, he even sent a preliminar patch for qt4 but I did not have the time to look at it yet. Not sure this was done yet, Edwin, Martin? not by me, but we

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-16 Thread Abdelrazak Younes
Leuven, E. wrote: 5) Some new code needs to be ported from the qt3 frontend, look at the svn log: 5-a) I remember the QNote thing from Martin, he even sent a preliminar patch for qt4 but I did not have the time to look at it yet. Not sure this was done yet, Edwin, Martin? not by me, but we

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-15 Thread Enrico Forestieri
On Wed, Aug 16, 2006 at 12:05:47AM +0200, Abdelrazak Younes wrote: > Michael Gerz wrote: > > 5-b) I remember some work from Georg and Enrico about some math > > symbols. I thing Georg put a FIXME in qt4 for that. > > Done by Edwin IIRC. Nope. The FIXME is still there in QDelimiterDialog.C. --

RE: Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-15 Thread Leuven, E.
> >5) Some new code needs to be ported from the qt3 frontend, look at > > the svn log: 5-a) I remember the QNote thing from Martin, he even sent > > a preliminar patch for qt4 but I did not have the time to look at it > > yet. > > Not sure this was done yet, Edwin, Martin? not by me, but we sh

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-15 Thread Abdelrazak Younes
Michael Gerz wrote: Abdel, I don't know the status regarding (1) - is there anything missing? Are there any changes to qt3 that haven't been ported to qt4? I think qt4 has now the same feature set as qt3 plus some more candy: And qt4 has a much nicer code base now, most notably for: How ab

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-15 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Abdelrazak Younes wrote: Hello, This patch continue my tedious cleanup work. Basically it transfer most of the LyXView use from BufferView to WorkArea, most notably: LyXView::updateLayoutChoice(); LyXView::updateToolbars(); LyXView::getLyXFunc().processKeySym(key, st

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-15 Thread Michael Gerz
Abdel, I don't know the status regarding (1) - is there anything missing? Are there any changes to qt3 that haven't been ported to qt4? I think qt4 has now the same feature set as qt3 plus some more candy: And qt4 has a much nicer code base now, most notably for: How about http://www.mail-a

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-15 Thread Michael Gerz
Well, I compiled qt4 by myself to make sure that there is really no need to keep qt3 :-) - Original Message - From: "Georg Baum" <[EMAIL PROTECTED]> To: Sent: Tuesday, August 15, 2006 10:19 PM Subject: Re: [Patch] Further BufferView <-> WorkArea reorganisat

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-15 Thread Georg Baum
Am Dienstag, 15. August 2006 21:03 schrieb Michael Gerz: > mainly replacing qt3 function calls by qt4 function calls. BTW: Last week, I > compiled qt4 on my old SuSE 9.3 machine - absolutely problem-free! No need to do that - the opensuse people provide qt4 rpms for 9.3, but they are well hidde

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-15 Thread Abdelrazak Younes
Michael Gerz wrote: Hi Abdel, The same argument applies to qt3. Furthermore, qt4 is feature complete now thanks to Edwin latest Bullet patch. So please, let's just drop it. I think that Lars isn't fully against dropping qt3. In one of his recent emails (about two weeks ago), he said that the

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-15 Thread Michael Gerz
Hi Abdel, The same argument applies to qt3. Furthermore, qt4 is feature complete now thanks to Edwin latest Bullet patch. So please, let's just drop it. I think that Lars isn't fully against dropping qt3. In one of his recent emails (about two weeks ago), he said that there are mainly two thi

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-15 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Hello, This patch continue my tedious cleanup work. Basically it transfer most of the LyXView use from BufferView to WorkArea, most notably: LyXView::updateLayoutChoice(); LyXView::updateToolbars(); LyXView::getLyXFunc().processKeySym(key, state); LyXView::dispatch(cm

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-15 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> I would like to commit it and wait for some kind soul to Abdelrazak> verify that it also compile and work for qt3 and gtk. gtk build: - when resizing, the screen goes black. If I click somewhe

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-14 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> I would like to commit it and wait for some kind soul to Abdelrazak> verify that it also compile and work for qt3 and gtk. gtk build: - when resizing, the screen goes black. If I click somewhere, it is repaint correct

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-14 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> I would like to commit it and wait for some kind soul to Abdelrazak> verify that it also compile and work for qt3 and gtk. The code in frontends/gtk compiles. JMarc

Re: [Patch] Further BufferView <-> WorkArea reorganisation

2006-08-14 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Hello, This patch continue my tedious cleanup work. Abdelrazak> Basically it transfer most of the LyXView use from Abdelrazak> BufferView to WorkArea, most notably: Abdelrazak> LyXView::updateLayoutChoice(); LyXView::

[Patch] Further BufferView <-> WorkArea reorganisation

2006-08-14 Thread Abdelrazak Younes
Hello, This patch continue my tedious cleanup work. Basically it transfer most of the LyXView use from BufferView to WorkArea, most notably: LyXView::updateLayoutChoice(); LyXView::updateToolbars(); LyXView::getLyXFunc().processKeySym(key, state); LyXView::dispatch(cmd); This patch has been t